[Roll] draft-ietf-roll-efficient-npdao review

Peter van der Stok <stokcons@bbhmail.nl> Thu, 06 September 2018 13:10 UTC

Return-Path: <stokcons@bbhmail.nl>
X-Original-To: roll@ietfa.amsl.com
Delivered-To: roll@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9A160130E1D; Thu, 6 Sep 2018 06:10:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.898
X-Spam-Level:
X-Spam-Status: No, score=-1.898 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JWCPPdyaH93M; Thu, 6 Sep 2018 06:10:33 -0700 (PDT)
Received: from smtprelay.hostedemail.com (smtprelay0036.hostedemail.com [216.40.44.36]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0FE46130E42; Thu, 6 Sep 2018 06:10:29 -0700 (PDT)
Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id 61EC8100E86C1; Thu, 6 Sep 2018 13:10:28 +0000 (UTC)
X-Session-Marker: 73746F6B636F6E73406262686D61696C2E6E6C
X-Spam-Summary: 50, 0, 0, , d41d8cd98f00b204, stokcons@bbhmail.nl, :::, RULES_HIT:41:72:152:355:379:582:800:962:967:968:973:983:988:989:1152:1189:1208:1221:1260:1263:1313:1314:1345:1431:1436:1437:1516:1517:1518:1535:1543:1575:1588:1589:1592:1594:1711:1730:1776:1792:2194:2199:2525:2553:2561:2564:2682:2685:2693:2829:2859:2894:2898:2899:2902:2911:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3355:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4118:4250:4321:4425:4659:5007:6119:6261:6298:6659:7903:8603:9010:9015:9025:9108:9177:9388:10004:10400:10450:10455:10848:10904:11232:11658:11914:12043:12109:12114:12295:12555:12679:12895:12986:13071:13138:13139:13161:13199:13229:13231:13439:13618:13846:14096:14180:14181:14721:19904:19999:21060:21080:21433:21451:21625:21691:21740, 0, RBL:216.40.42.5:@bbhmail.nl:.lbl8.mailshell.net-62.8.55.100 66.201.201.201, CacheIP:none, Bayesian:0.5, 0.5, 0.5, Netcheck:none, DomainCache:0, MSF:not bulk, SP
X-HE-Tag: plant59_3e3004c4cb049
X-Filterd-Recvd-Size: 7693
Received: from mail.bbhmail.nl (imap-ext [216.40.42.5]) (Authenticated sender: webmail@stokcons@bbhmail.nl) by omf06.hostedemail.com (Postfix) with ESMTPA; Thu, 6 Sep 2018 13:10:27 +0000 (UTC)
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="=_d67a234adc92cecd8f40dc2466f8d029"
Date: Thu, 06 Sep 2018 15:10:26 +0200
From: Peter van der Stok <stokcons@bbhmail.nl>
To: draft-ietf-roll-efficient-npdao@ietf.org
Cc: Roll <roll@ietf.org>
Organization: vanderstok consultancy
Reply-To: consultancy@vanderstok.org
Mail-Reply-To: consultancy@vanderstok.org
Message-ID: <65ac8a93279212d8757d1ecf24ac9e42@bbhmail.nl>
X-Sender: stokcons@bbhmail.nl
User-Agent: Roundcube Webmail/1.2.7
X-Originating-IP: [90.0.219.15]
Archived-At: <https://mailarchive.ietf.org/arch/msg/roll/22jCeLp511dxmuiSEmt9tc2TILg>
Subject: [Roll] draft-ietf-roll-efficient-npdao review
X-BeenThere: roll@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Routing Over Low power and Lossy networks <roll.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/roll>, <mailto:roll-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/roll/>
List-Post: <mailto:roll@ietf.org>
List-Help: <mailto:roll-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/roll>, <mailto:roll-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Sep 2018 13:10:41 -0000

Hi authors,

Many thanks for this work and solving an open important problem.

being the shepherd of this draft, I looked at the text to look for
improvements to facilitate the reading by the IESG.
I found the document difficult to read due to the use of multiple terms
for the same concept.
I would appreciate that the first 3 sections are improved, such that I
can continue the review afterwards without me wondering about my choices
in the interpretation of the text.

For example: is a sub-node the same thing as a child in the node? and
what is a dependent node?
Some suggestions to improve the document are written below.

Can you use, for example, the terms Switching-node (S-node)
After-switching parent (A-parent) and Before-switching parent
(B-parent); that will simplify the text and improve readability.
Please use consistently throughout one DODAG terminology like parent,
child, ancestor or another preferred terminology.
What does "target" mean: an endpoint of a path, a field in a packet, or
the S-node?
I thought that there can be many common ancestors on two paths with same
source and destination, and one of them is the first common ancestor.
BTW is the first one important; The rest of the text does not seem to
rely on it.

In section 1.4; to which what subtree do you refer?

In section 8.2.1 of RFC6550 it is mentioned that there can be a set of
preferred parents.
However, I have the impression that your assumption is the existence of
a single preferred parent, Some explanatory text would help.

Some textual suggestions:
Every first introduction of an acronym must be introduced with the full
name; for example: DAO must be written out both in the abstract as in
the text for the first use; please look for all the first instances in
the text.
In section 1.1 it will help if the list of used terms of RFC6550 is
added.

Section 3; a reminder that this applies only to storing mode may help.

3.1 How can transmission be tolerant to a link failure when the link has
disappeared completely or the node has been removed; some explanation is
needed here. It would help if the assumptions are listed: like there is
another path via ....

In section 3.1, 3.2 and 3.3 it should not be necessary to repeat what is
written in section 2.1, 2.2 and 2.3, just a reference to the
corresponding section will do.

Section 7 is rather short; I doubt that it will be accepted in this
form.
There have been earlier comments on the insufficiency of the security
considerations in RPL documents,

I hope I conveyed my problems sufficiently, and look forward to a new
version to continue the review.

All the best,

Peter

-- 
Peter van der Stok
vanderstok consultancy
mailto: consultancy@vanderstok.org, stokcons@bbhmail.nl
www: www.vanderstok.org [1]
tel NL: +31(0)492474673     F: +33(0)966015248 

Links:
------
[1] http://www.vanderstok.org