Re: [Roll] draft-ietf-roll-efficient-npdao review
Rahul Jadhav <rahul.ietf@gmail.com> Thu, 06 September 2018 16:07 UTC
Return-Path: <rahul.ietf@gmail.com>
X-Original-To: roll@ietfa.amsl.com
Delivered-To: roll@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 74FAC130EB1; Thu, 6 Sep 2018 09:07:26 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.2
X-Spam-Level:
X-Spam-Status: No, score=-1.2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, MIME_BOUND_DIGITS_15=0.798, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yuRusKozj6jy; Thu, 6 Sep 2018 09:07:24 -0700 (PDT)
Received: from mail-ua1-x931.google.com (mail-ua1-x931.google.com [IPv6:2607:f8b0:4864:20::931]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 10C9E130DE4; Thu, 6 Sep 2018 09:07:24 -0700 (PDT)
Received: by mail-ua1-x931.google.com with SMTP id m26-v6so9270191uap.2; Thu, 06 Sep 2018 09:07:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SLxU3pbnaksYh8V1btqU2PuyTQlCdFQ/x9Rqt4Qi1jA=; b=rzP8DNaMhf4yIqhXwMVQL70uQlLmjCRszqWCRv3KfJ7v+EHblBzkUqQIm9p9byWZK0 +s2iJSL+zHWLVqhQX6QIzkOLTPmfhVHskBefmmnWfP6HdVsfiJA938L5brTl9A+kEeea mFnE4EdNly3uQF0hCcSlVWwwut69eIDPYCIEio4hXO3cl2gZvLydvIBHQ219DRo3w1m6 LycIKcNR7Cqu8lDcTsRj45YKjSSMT9HikP7aVwAZz25VZajQ3bVEII8KNRPP8qAHdlBT n2XkWclQPVowicfSdmw+oUwZpL1I1p+lcMI9f3EEcew1a5n6lTMmc9oAE8cIV0w+O1ZB mk2w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SLxU3pbnaksYh8V1btqU2PuyTQlCdFQ/x9Rqt4Qi1jA=; b=cXqSsW8B1krP/LwgJwtwPogx/uITczkUnBdyIkwX7x6NRBOBTK1vmhiUp22pM9S2DM GBeyxDYqZCicwY9chjA8fhVele11Az3k7/cc7iTpP7w2KBBipBlXtT+Xbxqdi2fj8gCI GJZPdPG3hrYuJsTGBtlkz5FlN+KMEhVLyAnmknIKZDreINYSAMYjbqPXzsPMwmbsqJSw sszgSqpw1Hp3gfRcKOz50prdTO4Y7f4troWqeJ8QAfcIKo8u0GCxqAqo+gRjtszlce9/ S4vdBXx+cN/8BcEugu3vm62UfNKy+kDOfb4b28J8KUldkBMzLcjQm3uMSIqtigvCsDg9 RYyQ==
X-Gm-Message-State: APzg51CDCSx2LNZULK+5zwxP4ViP7JKXVSm9qrPptx8eVJ0VMQ3BVSEx dksjO16m8JRZvR7/Hh9sPEYONgxb8uFpXNHYKFdlug==
X-Google-Smtp-Source: ANB0VdbSFW6X5ly79IDPscvYiN8T91R/+TCiZwwNkbnjzFL/L+4YCg4z8RFHwic3zSdR8tNW1EQAE5f2rgvD8+pQVhE=
X-Received: by 2002:ab0:80e:: with SMTP id a14-v6mr1198087uaf.114.1536250042789; Thu, 06 Sep 2018 09:07:22 -0700 (PDT)
MIME-Version: 1.0
References: <65ac8a93279212d8757d1ecf24ac9e42@bbhmail.nl>
In-Reply-To: <65ac8a93279212d8757d1ecf24ac9e42@bbhmail.nl>
From: Rahul Jadhav <rahul.ietf@gmail.com>
Date: Thu, 06 Sep 2018 21:37:12 +0530
Message-ID: <CAO0Djp0HAMccSR+G6Zd=0TTPSmo0+mKv_XxAQG95vqQ+rDeN1w@mail.gmail.com>
To: consultancy@vanderstok.org
Cc: Roll <roll@ietf.org>, draft-ietf-roll-efficient-npdao@ietf.org
Content-Type: multipart/alternative; boundary="0000000000001635220575361647"
Archived-At: <https://mailarchive.ietf.org/arch/msg/roll/b3PxDufWObZqQBV2gEnte5jjjSA>
Subject: Re: [Roll] draft-ietf-roll-efficient-npdao review
X-BeenThere: roll@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Routing Over Low power and Lossy networks <roll.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/roll>, <mailto:roll-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/roll/>
List-Post: <mailto:roll@ietf.org>
List-Help: <mailto:roll-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/roll>, <mailto:roll-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Sep 2018 16:07:27 -0000
Many thanks Peter for the review. We will work on these comments and update the draft and provide detailed response soon. Thanks, Rahul On Thu, 6 Sep 2018 at 6:40 PM, Peter van der Stok <stokcons@bbhmail.nl> wrote: > Hi authors, > > Many thanks for this work and solving an open important problem. > > being the shepherd of this draft, I looked at the text to look for > improvements to facilitate the reading by the IESG. > I found the document difficult to read due to the use of multiple terms > for the same concept. > I would appreciate that the first 3 sections are improved, such that I can > continue the review afterwards without me wondering about my choices in the > interpretation of the text. > > For example: is a sub-node the same thing as a child in the node? and what > is a dependent node? > Some suggestions to improve the document are written below. > > Can you use, for example, the terms Switching-node (S-node) > After-switching parent (A-parent) and Before-switching parent (B-parent); > that will simplify the text and improve readability. > Please use consistently throughout one DODAG terminology like parent, > child, ancestor or another preferred terminology. > What does "target" mean: an endpoint of a path, a field in a packet, or > the S-node? > I thought that there can be many common ancestors on two paths with same > source and destination, and one of them is the first common ancestor. BTW > is the first one important; The rest of the text does not seem to rely on > it. > > In section 1.4; to which what subtree do you refer? > > In section 8.2.1 of RFC6550 it is mentioned that there can be a set of > preferred parents. > However, I have the impression that your assumption is the existence of a > single preferred parent, Some explanatory text would help. > > Some textual suggestions: > Every first introduction of an acronym must be introduced with the full > name; for example: DAO must be written out both in the abstract as in the > text for the first use; please look for all the first instances in the text. > In section 1.1 it will help if the list of used terms of RFC6550 is added. > > Section 3; a reminder that this applies only to storing mode may help. > > 3.1 How can transmission be tolerant to a link failure when the link has > disappeared completely or the node has been removed; some explanation is > needed here. It would help if the assumptions are listed: like there is > another path via .... > > In section 3.1, 3.2 and 3.3 it should not be necessary to repeat what is > written in section 2.1, 2.2 and 2.3, just a reference to the corresponding > section will do. > > Section 7 is rather short; I doubt that it will be accepted in this form. > There have been earlier comments on the insufficiency of the security > considerations in RPL documents, > > I hope I conveyed my problems sufficiently, and look forward to a new > version to continue the review. > > All the best, > > Peter > > > -- > Peter van der Stok > vanderstok consultancy > mailto: consultancy@vanderstok.org, stokcons@bbhmail.nl > www: www.vanderstok.org > tel NL: +31(0)492474673 F: +33(0)966015248 >
- [Roll] draft-ietf-roll-efficient-npdao review Peter van der Stok
- Re: [Roll] draft-ietf-roll-efficient-npdao review Rahul Jadhav
- Re: [Roll] draft-ietf-roll-efficient-npdao review Pascal Thubert (pthubert)
- Re: [Roll] draft-ietf-roll-efficient-npdao review Rahul Jadhav
- Re: [Roll] draft-ietf-roll-efficient-npdao review Rahul Jadhav
- Re: [Roll] draft-ietf-roll-efficient-npdao review Peter van der Stok
- Re: [Roll] draft-ietf-roll-efficient-npdao review Rahul Jadhav
- Re: [Roll] draft-ietf-roll-efficient-npdao review Peter van der Stok