Re: [spring] WG Adoption Call for draft-raza-spring-srv6-yang

Thanks Dhruv, Jeff, and Yingzhen for your comments.

The next rev of the model will take care of NMDA style as well as simplify the grouping.

On 2020-07-25, 7:53 PM, "spring on behalf of Yingzhen Qu" <spring-bounces@ietf.org on behalf of yingzhen.qu@futurewei.com> wrote:

    Hi,

    I agree with Dhruv's comments that there should not be separate configuration and state trees. 

    Also "grouping" is overly used in the model, and I'd suggest the authors remove some groups when updating the draft.

    Thanks,
    Yingzhen

    On 7/25/20, 10:23 AM, "spring on behalf of Dhruv Dhody" <spring-bounces@ietf.org on behalf of dhruv.ietf@gmail.com> wrote:

        Hi WG,

        I support the adoption of this work and I have thoughts on how to
        improve the document -

        Some questions/comments -
        - Can the title of the I-D be improved?
        - Why do you have the config and the state trees separately in Figures
        1 and 2? That's out of fashion with NMDA!
        - I hope this model is applicable for both the headend router as well
        as for the controller. If yes, we should highlight that as well as
        make sure the YANG model takes care of this. For example, counters,
        forwarding, etc
        - The node-capabilities are marked as read-only, but an operator may
        want to disable or enable these right?

        Suggestions for improving YANG -
        - Update copyright year
        - path-attrs-cmn is described as "Path properties -common for v4/v6",
        in that case, is this the right yang model for it? and should it be in
        the generic SR model instead?
        - Typedef for algorithm could be useful, it is unit32 here but uint8
        in draft-ietf-spring-sr-yang
        - What is the purpose of the empty containers end, end_psp, end_usp,
        end_psp_usp, end_usd, end_psp_usd, end_usp_usd, end_psp_usp_usd? Are
        they placeholders for something?
        - Run this "pyang -f yang --keep-comments --yang-line-length 69
        <FILE>" to help you with formatting the yang model.

        Thanks!
        Dhruv

        On Tue, Jul 14, 2020 at 3:22 AM James Guichard
        <james.n.guichard@futurewei.com> wrote:
        >
        > Dear WG:
        >
        >
        >
        > This email begins a 2 week WG adoption call for https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdatatracker.ietf.org%2Fdoc%2Fdraft-raza-spring-srv6-yang%2F&amp;data=02%7C01%7Cyingzhen.qu%40futurewei.com%7C0b316d999f4f41b2edb008d830bf6a89%7C0fee8ff2a3b240189c753a1d5591fedc%7C1%7C0%7C637312945993728664&amp;sdata=TgKml9vtVT8T4Gak6DUmVaNJ14BAF7cyfccIv4oqm1o%3D&amp;reserved=0 ending Monday 27th July 2020.
        >
        >
        >
        > Please speak up if you support or oppose adopting this document into the WG. Please also provide comments/reasons for that support (or lack thereof). Silence will not be considered consent.
        >
        >
        >
        > Thanks!
        >
        >
        >
        > Jim, Joel & Bruno
        >
        >
        >
        >
        >
        >
        >
        >
        >
        > _______________________________________________
        > spring mailing list
        > spring@ietf.org
        > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.ietf.org%2Fmailman%2Flistinfo%2Fspring&amp;data=02%7C01%7Cyingzhen.qu%40futurewei.com%7C0b316d999f4f41b2edb008d830bf6a89%7C0fee8ff2a3b240189c753a1d5591fedc%7C1%7C0%7C637312945993728664&amp;sdata=nKQLkDrLqa%2FkXT6WDFdXJKAf%2FSuaay1paSp6VHfScPg%3D&amp;reserved=0

        _______________________________________________
        spring mailing list
        spring@ietf.org
        https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.ietf.org%2Fmailman%2Flistinfo%2Fspring&amp;data=02%7C01%7Cyingzhen.qu%40futurewei.com%7C0b316d999f4f41b2edb008d830bf6a89%7C0fee8ff2a3b240189c753a1d5591fedc%7C1%7C0%7C637312945993728664&amp;sdata=nKQLkDrLqa%2FkXT6WDFdXJKAf%2FSuaay1paSp6VHfScPg%3D&amp;reserved=0

    _______________________________________________
    spring mailing list
    spring@ietf.org
    https://www.ietf.org/mailman/listinfo/spring