IETF Logo Mail Archive

Re: [yang-doctors] [Lsr] draft-ietf-isis-sr-yang and draft-ietf-ospf-sr-yang

Yingzhen Qu <yingzhen.ietf@gmail.com> Tue, 14 November 2023 17:16 UTC

Return-Path: <yingzhen.ietf@gmail.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0E389C1519B6; Tue, 14 Nov 2023 09:16:29 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.104
X-Spam-Level:
X-Spam-Status: No, score=-2.104 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Kkm17KrQZAOT; Tue, 14 Nov 2023 09:16:28 -0800 (PST)
Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 112A4C1522A0; Tue, 14 Nov 2023 09:16:28 -0800 (PST)
Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2c50ec238aeso83380391fa.0; Tue, 14 Nov 2023 09:16:27 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699982186; x=1700586986; darn=ietf.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=8unco7U4r8FVBnVhdSX/SD4WC1RL29TZUFnvzpUdNAs=; b=Hsb1u8L9mNfmiOamrVdFKmAjNlUihWSiOlbECQOLDbO39poR4fhNPdbU1PK5ITRVCJ UtsEO7R2zG0KlsY7vhbuAWe2mSqGBUfhZiStEzEGWeNe0J0/78tMkOZZnpDXjbFr8Ljp VK5xhIVLDqMgrhhmY7c/48g8RywL5Lz/4oNPlUt54s/T2yk/R/ABWhSL/Vua1RS34ZOZ 8VDXUlDOKoNfdTZkh2q6PFdwabmm+nxzfus/J8Q6Zd/hQ2XbYr47hv7brTq2DTv/Yf+U Mfj+CFltisemdhubStDQPz0w9oj0GwVx1SrtMxKSM7H5V/WQCam1/wdAc0QPEUe8OCof YeVw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699982186; x=1700586986; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8unco7U4r8FVBnVhdSX/SD4WC1RL29TZUFnvzpUdNAs=; b=m5iUr4YoC8Ey9EVifBOxLlnlNql3FOriICR1ZyJN+mlYIo22wnGUgSlKSqBFLbatXX ig5s0eBNBInkrhFHrQKVJeB5WosqRFTvIGnkq6RTPs8F7eJv/pM1helFZqvTud7PIxNk R9V8ITwjlA21YANz9saIU07Td/0HOsd3zstSro8AwnT8JdCIgpBt1j06x4hI2DLRYJ+X ji/QV497WctIoQvHm09bkTqqsOolWgx4Vamlm1Fp84XIqE36w6YBRiK4/FGr32kZFN/f QtdqVY7NmIxSkCPrqz1YVmnl4P+WtH2bO37SiGrR06DkDklnjUvrwyWf5jp6YddbPEmD LemQ==
X-Gm-Message-State: AOJu0YxneuTzrYSYiV4tLOpsueKFilquXRR705z5iAoc8FLvPi3RqfsW k3fh3yE5ILeWnRkYuudOKbiFV6skVXkF4NWRWQ==
X-Google-Smtp-Source: AGHT+IEkpRRVVSvNIUTM2R/ClOEKZ0kSP1Ilddkbx4CgHXfoZ5h7LHeFF1SwQRtfbohbnESpuhy/oWnIP8zLKUcO4pM=
X-Received: by 2002:a2e:aa19:0:b0:2c0:1fb4:446f with SMTP id bf25-20020a2eaa19000000b002c01fb4446fmr1852069ljb.14.1699982185354; Tue, 14 Nov 2023 09:16:25 -0800 (PST)
MIME-Version: 1.0
References: <519166882.977244.1698850736652.ref@mail.yahoo.com> <519166882.977244.1698850736652@mail.yahoo.com> <647196989.1856562.1699973710099@mail.yahoo.com>
In-Reply-To: <647196989.1856562.1699973710099@mail.yahoo.com>
From: Yingzhen Qu <yingzhen.ietf@gmail.com>
Date: Tue, 14 Nov 2023 09:16:14 -0800
Message-ID: <CABY-gOOiNU15Rhu8BwwVNr+dkLpPTi789BzsOwPfQm_EHF19qQ@mail.gmail.com>
To: Reshad Rahman <reshad@yahoo.com>
Cc: Lsr <lsr@ietf.org>, "Jan Lindblad (jlindbla)" <jlindbla@cisco.com>, YANG Doctors <yang-doctors@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000485c29060a1ff258"
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/HtWDiew0qUIctHkdmBmmfLpJF54>
Subject: Re: [yang-doctors] [Lsr] draft-ietf-isis-sr-yang and draft-ietf-ospf-sr-yang
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Nov 2023 17:16:29 -0000

Hi Reshad,

Thanks for the review.

I'll look into this issue and get back to you soon. We should
definitely try to keep these two models consistent.

Thanks,
Yingzhen



On Tue, Nov 14, 2023 at 6:55 AM Reshad Rahman <reshad=
40yahoo.com@dmarc.ietf.org> wrote:

> Hi,
>
> My suggestion is that authors of these 2 documents spend some time
> together to try to align the 2 documents. After that we can do YD review.
>
> Regards,
> Reshad.
>
> On Wednesday, November 1, 2023, 10:58:56 AM EDT, Reshad Rahman <
> reshad@yahoo.com> wrote:
>
>
> Hi,
>
> Background: those 2 documents have just been assigned YD review, I am
> reviewing OSPF and Jan is reviewing ISIS.
>
> Was an effort made to keep those 2 documents aligned/in-sync where
> possible/desirable? My expectation is that the SR specifics would be
> near-identical in the 2 documents. e.g. shouldn't the capabilities for the
> 2 protocols be very similar.
> Here are some differences which don't seem justified:
> - sr-algorithm in ISIS is a uint8 and in OSPF is an identityref
> - range-size is a uint32 in ISIS and is a uint24 in OSPF
>
>
>   augment /rt:routing/rt:control-plane-protocols
>           /rt:control-plane-protocol/isis:isis/isis:database
>           /isis:levels/isis:lsp/isis:router-capabilities:
>     +--ro sr-capability
>     |  +--ro sr-capability
>     |  |  +--ro sr-capability-bits*   identityref
>     |  +--ro global-blocks
>     |     +--ro global-block* []
>     |        +--ro range-size?    uint32
>     |        +--ro sid-sub-tlv
>     |           +--ro sid?   uint32
>     +--ro sr-algorithms
>     |  +--ro sr-algorithm*   uint8
>     +--ro local-blocks
>     |  +--ro local-block* []
>     |     +--ro range-size?    uint32
>     |     +--ro sid-sub-tlv
>     |        +--ro sid?   uint32
>     +--ro srms-preference
>        +--ro preference?   uint8
>
>
>     augment /rt:routing/rt:control-plane-protocols
>             /rt:control-plane-protocol/ospf:ospf/ospf:areas/ospf:area
>             /ospf:interfaces/ospf:interface/ospf:database
>             /ospf:link-scope-lsa-type/ospf:link-scope-lsas
>             /ospf:link-scope-lsa/ospf:version/ospf:ospfv2/ospf:ospfv2
>             /ospf:body/ospf:opaque/ospf:ri-opaque:
>       +--ro sr-algorithm-tlv
>       |  +--ro sr-algorithm*   identityref
>       +--ro sid-range-tlvs
>       |  +--ro sid-range-tlv* []
>       |     +--ro range-size?    rt-types:uint24
>       |     +--ro sid-sub-tlv
>       |        +--ro sid?   uint32
>       +--ro local-block-tlvs
>       |  +--ro local-block-tlv* []
>       |     +--ro range-size?    rt-types:uint24
>       |     +--ro sid-sub-tlv
>       |        +--ro sid?   uint32
>       +--ro srms-preference-tlv
>          +--ro preference?   uint8
>
>
>
> Disclaimer: I don't follow LSR...
>
> Regards,
> Reshad.
> _______________________________________________
> Lsr mailing list
> Lsr@ietf.org
> https://www.ietf.org/mailman/listinfo/lsr
>

v2.23.0 | Report a Bug | By Email