Re: [yang-doctors] [Lsr] draft-ietf-isis-sr-yang and draft-ietf-ospf-sr-yang

[Rahman <[e-mail]>]

Hi Yingzhen,

On PTO right now. I’ll review when I get back.

Regards,

Reshad.

Sent from my iPhone

On Nov 19, 2023, at 7:20 PM, Yingzhen Qu <[e-mail]> wrote:



Hi Reshad,

I've submitted an updated version of both the drafts, and tried to align the two models. Please review and let me know what you think.

Thanks,

Yingzhen

On Tue, Nov 14, 2023 at 1:42 PM Acee Lindem <[e-mail]> wrote:

> On Nov 14, 2023, at 10:32 AM, Mahesh Jethanandani <[e-mail]> wrote:
>
> Hi Acee,
>
> Can the commonality extend to having a common grouping that is used by both the models?

No - see my response to Reshad.

Acee


>
> Cheers.
>
>> On Nov 14, 2023, at 8:10 AM, Acee Lindem <[e-mail]> wrote:
>>
>> Thanks Reshad - are there any other notable discrepancies?
>>
>> Thanks,
>> Acee
>>
>>> On Nov 14, 2023, at 9:55 AM, Reshad Rahman <reshad=[e-mail]> wrote:
>>>
>>> Hi,
>>>
>>> My suggestion is that authors of these 2 documents spend some time together to try to align the 2 documents. After that we can do YD review.
>>>
>>> Regards,
>>> Reshad.
>>>
>>> On Wednesday, November 1, 2023, 10:58:56 AM EDT, Reshad Rahman <[e-mail]> wrote:
>>>
>>>
>>> Hi,
>>>
>>> Background: those 2 documents have just been assigned YD review, I am reviewing OSPF and Jan is reviewing ISIS.
>>>
>>> Was an effort made to keep those 2 documents aligned/in-sync where possible/desirable? My expectation is that the SR specifics would be near-identical in the 2 documents. e.g. shouldn't the capabilities for the 2 protocols be very similar.
>>> Here are some differences which don't seem justified:
>>> - sr-algorithm in ISIS is a uint8 and in OSPF is an identityref
>>> - range-size is a uint32 in ISIS and is a uint24 in OSPF
>>>
>>>
>>> augment /rt:routing/rt:control-plane-protocols
>>> /rt:control-plane-protocol/isis:isis/isis:database
>>> /isis:levels/isis:lsp/isis:router-capabilities:
>>> +--ro sr-capability
>>> | +--ro sr-capability
>>> | | +--ro sr-capability-bits* identityref
>>> | +--ro global-blocks
>>> | +--ro global-block* []
>>> | +--ro range-size? uint32
>>> | +--ro sid-sub-tlv
>>> | +--ro sid? uint32
>>> +--ro sr-algorithms
>>> | +--ro sr-algorithm* uint8
>>> +--ro local-blocks
>>> | +--ro local-block* []
>>> | +--ro range-size? uint32
>>> | +--ro sid-sub-tlv
>>> | +--ro sid? uint32
>>> +--ro srms-preference
>>> +--ro preference? uint8
>>>
>>> augment /rt:routing/rt:control-plane-protocols
>>> /rt:control-plane-protocol/ospf:ospf/ospf:areas/ospf:area
>>> /ospf:interfaces/ospf:interface/ospf:database
>>> /ospf:link-scope-lsa-type/ospf:link-scope-lsas
>>> /ospf:link-scope-lsa/ospf:version/ospf:ospfv2/ospf:ospfv2
>>> /ospf:body/ospf:opaque/ospf:ri-opaque:
>>> +--ro sr-algorithm-tlv
>>> | +--ro sr-algorithm* identityref
>>> +--ro sid-range-tlvs
>>> | +--ro sid-range-tlv* []
>>> | +--ro range-size? rt-types:uint24
>>> | +--ro sid-sub-tlv
>>> | +--ro sid? uint32
>>> +--ro local-block-tlvs
>>> | +--ro local-block-tlv* []
>>> | +--ro range-size? rt-types:uint24
>>> | +--ro sid-sub-tlv
>>> | +--ro sid? uint32
>>> +--ro srms-preference-tlv
>>> +--ro preference? uint8
>>>
>>>
>>>
>>> Disclaimer: I don't follow LSR...
>>>
>>> Regards,
>>> Reshad.
>>> _______________________________________________
>>> yang-doctors mailing list
>>> [e-mail]
>>> https://www.ietf.org/mailman/listinfo/yang-doctors" rel="noreferrer nofollow" target="_blank">https://www.ietf.org/mailman/listinfo/yang-doctors
>>
>> _______________________________________________
>> yang-doctors mailing list
>> [e-mail]
>> https://www.ietf.org/mailman/listinfo/yang-doctors" rel="noreferrer nofollow" target="_blank">https://www.ietf.org/mailman/listinfo/yang-doctors
>
>
> Mahesh Jethanandani
> [e-mail]
>
>
>
>
>
>

_______________________________________________
Lsr mailing list
[e-mail]
https://www.ietf.org/mailman/listinfo/lsr" rel="noreferrer nofollow" target="_blank">https://www.ietf.org/mailman/listinfo/lsr

_______________________________________________
Lsr mailing list
[e-mail]
https://www.ietf.org/mailman/listinfo/lsr