IETF Logo Mail Archive

Re: [yang-doctors] draft-ietf-isis-sr-yang and draft-ietf-ospf-sr-yang

Acee Lindem <acee.ietf@gmail.com> Tue, 14 November 2023 15:11 UTC

Return-Path: <acee.ietf@gmail.com>
X-Original-To: yang-doctors@ietfa.amsl.com
Delivered-To: yang-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4E8FFC14CE3F; Tue, 14 Nov 2023 07:11:08 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.106
X-Spam-Level:
X-Spam-Status: No, score=-7.106 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9UAI8qGaQEYh; Tue, 14 Nov 2023 07:11:07 -0800 (PST)
Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7560EC14CE30; Tue, 14 Nov 2023 07:11:02 -0800 (PST)
Received: by mail-qk1-x735.google.com with SMTP id af79cd13be357-7788ebea620so381046985a.3; Tue, 14 Nov 2023 07:11:02 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699974661; x=1700579461; darn=ietf.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Dq+TKmTCXgJCasIpZhgN9Vfn7BjLtr1NMYLgURGMvgI=; b=Sw6E5EP1cawtUNXj0jRPiNVznTagXERt8EvVhwBoxa1IBk/O+b7118G7xMhd5nLZNn 3hr0Vrta3myL+nPkKWZLQqMB3EN+f4tc8YPbW/61UPglCBc52ZyL7sy1NA5H/qyr8nyT 03ky1P3NvMQKA5EeF8JyRDeTE5lwEByMGIv2yy2nsOx/AgDlDVVIxp0OvoYh3LOwaaPB RkjGhozFzkwzB4XxtVXTsI2M4HfplNg6yoHYFN1K6ArcsMh27otnvBHuMjNaqt+ZhW5v r8FMe9eZ6ie3XqEN83W8jK8ySz9QMj7pXI5uCSLbMUidNHmXa3Sm4fC8TehfU/ya4Qdv 1PDg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699974661; x=1700579461; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Dq+TKmTCXgJCasIpZhgN9Vfn7BjLtr1NMYLgURGMvgI=; b=DF4lJcVoXm6JIXx/nrfXzVXo5fmDj+fJ/GTYqe3PEqtRqfwd1FOYFFHypa7hKcEuM4 qoBzeVo8kIl+XPdwSmHmTTzVYGej0GGdst9464UH/KRKiTIWLBtz7pgi6vKU6qC7iQKF 1sjXc8+DDcM2J/Y30g2kFhNFcPUN64IQxK9g6by5nRsfl5KROvU3O2RybTrLqYx0l6xY 5LH4lZx5xaC6tji4/mBBrf/kR7MxI4z6MR0AIkhczdYA3nCEslhss1UFOHA/RUDx5j/5 uvpNaXKCxriCqEIsPEzTI7W0C+iIaT5YvhQMB1UTNCif0wDNlBgA79vLPt16TMwW0oL4 JRyg==
X-Gm-Message-State: AOJu0YwwU5N5Voz59WLh+UwKGecYig6crMnGraw0KBEffajG95C+h4Lw NhRgTt1CE9+cJFXHnZhNS0A=
X-Google-Smtp-Source: AGHT+IHkpJCqPoYaxb5dVwGD4wDSjdSHTafOw1hTjalo2rQAh8yddIHlQnaDKTotD3y2NzedN0FDTg==
X-Received: by 2002:a05:620a:4d86:b0:76d:bb77:b295 with SMTP id uw6-20020a05620a4d8600b0076dbb77b295mr1948001qkn.78.1699974661342; Tue, 14 Nov 2023 07:11:01 -0800 (PST)
Received: from smtpclient.apple ([2605:a601:91bb:5200:9884:d8f9:be4a:e76d]) by smtp.gmail.com with ESMTPSA id az36-20020a05620a172400b0077580becd52sm2704434qkb.103.2023.11.14.07.11.00 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Nov 2023 07:11:00 -0800 (PST)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\))
From: Acee Lindem <acee.ietf@gmail.com>
In-Reply-To: <647196989.1856562.1699973710099@mail.yahoo.com>
Date: Tue, 14 Nov 2023 10:10:50 -0500
Cc: Lsr <lsr@ietf.org>, "Jan Lindblad (jlindbla)" <jlindbla@cisco.com>, YANG Doctors <yang-doctors@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <5AB7A387-3119-4529-B82B-85ED13B84388@gmail.com>
References: <519166882.977244.1698850736652.ref@mail.yahoo.com> <519166882.977244.1698850736652@mail.yahoo.com> <647196989.1856562.1699973710099@mail.yahoo.com>
To: Reshad Rahman <reshad@yahoo.com>
X-Mailer: Apple Mail (2.3731.700.6)
Archived-At: <https://mailarchive.ietf.org/arch/msg/yang-doctors/VnBZtNz9gzD0dCAES3xSwKbRsgM>
Subject: Re: [yang-doctors] draft-ietf-isis-sr-yang and draft-ietf-ospf-sr-yang
X-BeenThere: yang-doctors@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: Email list of the yang-doctors directorate <yang-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/yang-doctors/>
List-Post: <mailto:yang-doctors@ietf.org>
List-Help: <mailto:yang-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/yang-doctors>, <mailto:yang-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Nov 2023 15:11:08 -0000

Thanks Reshad - are there any other notable discrepancies? 

Thanks,
Acee

> On Nov 14, 2023, at 9:55 AM, Reshad Rahman <reshad=40yahoo.com@dmarc.ietf.org> wrote:
> 
> Hi,
> 
> My suggestion is that authors of these 2 documents spend some time together to try to align the 2 documents. After that we can do YD review.
> 
> Regards,
> Reshad.
> 
> On Wednesday, November 1, 2023, 10:58:56 AM EDT, Reshad Rahman <reshad@yahoo.com> wrote: 
> 
> 
> Hi,
> 
> Background: those 2 documents have just been assigned YD review, I am reviewing OSPF and Jan is reviewing ISIS.
> 
> Was an effort made to keep those 2 documents aligned/in-sync where possible/desirable? My expectation is that the SR specifics would be near-identical in the 2 documents. e.g. shouldn't the capabilities for the 2 protocols be very similar.
> Here are some differences which don't seem justified:
> - sr-algorithm in ISIS is a uint8 and in OSPF is an identityref
> - range-size is a uint32 in ISIS and is a uint24 in OSPF
> 
> 
> augment /rt:routing/rt:control-plane-protocols
> /rt:control-plane-protocol/isis:isis/isis:database
> /isis:levels/isis:lsp/isis:router-capabilities:
> +--ro sr-capability
> | +--ro sr-capability
> | | +--ro sr-capability-bits* identityref
> | +--ro global-blocks
> | +--ro global-block* []
> | +--ro range-size? uint32
> | +--ro sid-sub-tlv
> | +--ro sid? uint32
> +--ro sr-algorithms
> | +--ro sr-algorithm* uint8
> +--ro local-blocks
> | +--ro local-block* []
> | +--ro range-size? uint32
> | +--ro sid-sub-tlv
> | +--ro sid? uint32
> +--ro srms-preference
> +--ro preference? uint8
> 
> augment /rt:routing/rt:control-plane-protocols
> /rt:control-plane-protocol/ospf:ospf/ospf:areas/ospf:area
> /ospf:interfaces/ospf:interface/ospf:database
> /ospf:link-scope-lsa-type/ospf:link-scope-lsas
> /ospf:link-scope-lsa/ospf:version/ospf:ospfv2/ospf:ospfv2
> /ospf:body/ospf:opaque/ospf:ri-opaque:
> +--ro sr-algorithm-tlv
> | +--ro sr-algorithm* identityref
> +--ro sid-range-tlvs
> | +--ro sid-range-tlv* []
> | +--ro range-size? rt-types:uint24
> | +--ro sid-sub-tlv
> | +--ro sid? uint32
> +--ro local-block-tlvs
> | +--ro local-block-tlv* []
> | +--ro range-size? rt-types:uint24
> | +--ro sid-sub-tlv
> | +--ro sid? uint32
> +--ro srms-preference-tlv
> +--ro preference? uint8
> 
> 
> 
> Disclaimer: I don't follow LSR...
> 
> Regards,
> Reshad.
> _______________________________________________
> yang-doctors mailing list
> yang-doctors@ietf.org
> https://www.ietf.org/mailman/listinfo/yang-doctors

v2.23.0 | Report a Bug | By Email