Re: [yang-doctors] draft-ietf-isis-sr-yang and draft-ietf-ospf-sr-yang

["Jan Lindblad (jlindbla)" <[e-mail]>]

Mehmet, Reshad,

Interesting discussion unfolding about the alignment of these drafts. It is quite obvious Reshad is the better (more insightful) reviewer for these documents. Once they are aligned it's fine by me if you assign the review to Reshad. Or if you prefer, it's also ok by me that you assign them to us both. Since I reviewed an earlier version of one of the documents, I could follow up on my earlier comments.

Best Regards,
/jan

On 1 Nov 2023, at 16:23, [e-mail] wrote:

Hi Reshad, Jan,

I didn’t know about the relationship.
It might be interesting if the two drafts get reviewed by the same person.
If this is also what you think I can assign both to you or Jan.

PLMK.

Thanks,
Mehmet

From: yang-doctors <[e-mail]> On Behalf Of Reshad Rahman
Sent: Wednesday, November 1, 2023 5:59 PM
To: Lsr <[e-mail]>
Cc: Jan Lindblad (jlindbla) <[e-mail]>; YANG Doctors <[e-mail]>
Subject: [yang-doctors] draft-ietf-isis-sr-yang and draft-ietf-ospf-sr-yang

Hi,

Background: those 2 documents have just been assigned YD review, I am reviewing OSPF and Jan is reviewing ISIS.

Was an effort made to keep those 2 documents aligned/in-sync where possible/desirable? My expectation is that the SR specifics would be near-identical in the 2 documents. e.g. shouldn't the capabilities for the 2 protocols be very similar.
Here are some differences which don't seem justifie:
- sr-algorithm in ISIS is a uint8 and in OSPF is an identityref
- range-size is a uint32 in ISIS and is a uint24 in OSPF



  augment /rt:routing/rt:control-plane-protocols

          /rt:control-plane-protocol/isis:isis/isis:database

          /isis:levels/isis:lsp/isis:router-capabilities:

    +--ro sr-capability

    |  +--ro sr-capability

    |  |  +--ro sr-capability-bits*   identityref

    |  +--ro global-blocks

    |     +--ro global-block* []

    |        +--ro range-size?    uint32

    |        +--ro sid-sub-tlv

    |           +--ro sid?   uint32

    +--ro sr-algorithms

    |  +--ro sr-algorithm*   uint8

    +--ro local-blocks

    |  +--ro local-block* []

    |     +--ro range-size?    uint32

    |     +--ro sid-sub-tlv

    |        +--ro sid?   uint32

    +--ro srms-preference

       +--ro preference?   uint8



    augment /rt:routing/rt:control-plane-protocols

            /rt:control-plane-protocol/ospf:ospf/ospf:areas/ospf:area

            /ospf:interfaces/ospf:interface/ospf:database

            /ospf:link-scope-lsa-type/ospf:link-scope-lsas

            /ospf:link-scope-lsa/ospf:version/ospf:ospfv2/ospf:ospfv2

            /ospf:body/ospf:opaque/ospf:ri-opaque:

      +--ro sr-algorithm-tlv

      |  +--ro sr-algorithm*   identityref

      +--ro sid-range-tlvs

      |  +--ro sid-range-tlv* []

      |     +--ro range-size?    rt-types:uint24

      |     +--ro sid-sub-tlv

      |        +--ro sid?   uint32

      +--ro local-block-tlvs

      |  +--ro local-block-tlv* []

      |     +--ro range-size?    rt-types:uint24

      |     +--ro sid-sub-tlv

      |        +--ro sid?   uint32

      +--ro srms-preference-tlv

         +--ro preference?   uint8



Disclaimer: I don't follow LSR...

Regards,
Reshad.
_______________________________________________
yang-doctors mailing list
[e-mail]<mailto:[e-mail]>
https://www.ietf.org/mailman/listinfo/yang-doctors