Re: [Cbor] Reviews and shepherd for draft-ietf-cbor-cddl-more-control

"lgl island-resort.com" <lgl@island-resort.com> Thu, 11 April 2024 11:12 UTC

Return-Path: <lgl@island-resort.com>
X-Original-To: cbor@ietfa.amsl.com
Delivered-To: cbor@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 45164C14F5EF; Thu, 11 Apr 2024 04:12:51 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gahukayhspJd; Thu, 11 Apr 2024 04:12:46 -0700 (PDT)
Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2099.outbound.protection.outlook.com [40.107.94.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AE96BC14F5EE; Thu, 11 Apr 2024 04:12:46 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cfMdaapS6RPAYwzrQUai5Is1Nk/es/LLec5aDknAeQ/egEB3ZXqHKu05a/3mFvQM04CjqvpAn1X4ly+aNL6XQWQnuutdswWEeH+xh+RrlFDp69GqSLZGYz5vQVSzEtUxsf6keWD5qs/DQH/YyphqaUWT4DBmiRm5abV2SVpkwyDqLmHmkTD+JwFAj/XR55MtWwj3OhNlrhCmQBv5o4Zzx4WKu7M1L64d9hqG+JTwAMJE5kInBf4QDN3Lr+yruLwOk84XJMHVH0n1UVxXI2DXaJISceTwDhVbOPZRMo3/hDc4nCNfB56g5sgmLUVkHDrxoVYcUCxOnJO15r2WOerd3w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4ToApFcy9mkoTNBc/XJKlX7CtsJCml7vB0nS5y6/q1c=; b=PrpLca+98SY0NtpuoR0kOE6m54B56wmWGTjmn4jdiH0MlMpjPlmOqdb3M1SODs66Y+RD/OIiefaqVu/ptxr2TTlgU3RslqJz4p8N1hRGRbx+zBESx1IH9wpTIuR7DgfeL23yDlTOT52SZNMbwLFxKB4gmdcldBN1eF9LVZAGoBC9ukT05KNgS91EgMH4UleXYoCH/YFFQ1pNqYVmQ1sLyD7DKg4WGPP1Jk7zSSs7xFqXixVLm9ALedzT0baLdLz+yVNJ7BHnVn4zGc5OVWGYM2wpAiRIms5EVnXtex1Qt7t+SGPWCRa8GR7Z90MZJK4llGs3pCBX++WWcgqzGPbuJg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=island-resort.com; dmarc=pass action=none header.from=island-resort.com; dkim=pass header.d=island-resort.com; arc=none
Received: from PH7PR22MB3092.namprd22.prod.outlook.com (2603:10b6:510:13b::8) by SA1PR22MB3171.namprd22.prod.outlook.com (2603:10b6:806:23e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.55; Thu, 11 Apr 2024 11:12:42 +0000
Received: from PH7PR22MB3092.namprd22.prod.outlook.com ([fe80::1cab:7344:221c:bb8e]) by PH7PR22MB3092.namprd22.prod.outlook.com ([fe80::1cab:7344:221c:bb8e%5]) with mapi id 15.20.7409.042; Thu, 11 Apr 2024 11:12:42 +0000
From: "lgl island-resort.com" <lgl@island-resort.com>
To: Carsten Bormann <cabo@tzi.org>
CC: Christian Amsüss <christian@amsuess.com>, "cbor@ietf.org" <cbor@ietf.org>, "draft-ietf-cbor-cddl-more-control@ietf.org" <draft-ietf-cbor-cddl-more-control@ietf.org>
Thread-Topic: [Cbor] Reviews and shepherd for draft-ietf-cbor-cddl-more-control
Thread-Index: AQHaiaBHsJSaT6YN1UegnAVoy4cepLFgP1yAgAAKsYCAAqT9gA==
Date: Thu, 11 Apr 2024 11:12:42 +0000
Message-ID: <EF87DF03-8483-45DD-AA80-8E885BB78F75@island-resort.com>
References: <ZeMG7tpfKLyf3aSz@hephaistos.amsuess.com> <ZhPIC9DyzcpyhjPI@hephaistos.amsuess.com> <3FECD79D-C19A-4F04-BF04-A39AC4962C2D@island-resort.com> <31FEFB97-87CD-4B6D-86A7-06CBE12D51E8@tzi.org>
In-Reply-To: <31FEFB97-87CD-4B6D-86A7-06CBE12D51E8@tzi.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=island-resort.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: PH7PR22MB3092:EE_|SA1PR22MB3171:EE_
x-ms-office365-filtering-correlation-id: 92eafcfd-dee3-4036-fe8a-08dc5a184e86
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 4gSi9Eea6Lroe9G1uqqpM2mWoWkyIS9h2j1nRhr3VqwbsBpmb6fz5gOQGivwZlCgimlhIeBzgZKMIbDzL0PeK59f8dN5CG1Uj3Xh0OIKuQZ56IcwmyX0RvbiGFO9J7ye+qoZemv3Sl6m2g4rhML8pLymLdAPnhWtI85bQkOKIhlIinkFKsetMvy2/jbJ3m1XqT4fS2Z5OShLgBvqIYfL/1XZbG93w477r/7HiJUKkhK6VAi2OCfyOm1NdSFKG5RPDMI9+rZWSZ0Be9S8ft9Cm5nSuTOut5px7lFWBeu9HDTiTF/40OH6aB/pCGaZFpYP95X4ghl9Hp1v6eURflmsYVAzpAc43fkj1fVBRppWkTen82JJ2WcVVC0kQ50avN4nyqTQu+zDiOP73R1OWr8gY5SpTvIY4WP0KqZYVfLC0reuAR4jBJcx++AaHYyhPTKQP0lclvXHk22+YEjqwmuQxKKIC4vq2GGVuVVKYEP2gTc0GiMxFb7nBWeUIfRwWG6xl1hgPJovE7HerliwJ6JiXhEVIuOPFIAdZ8cI7sY7hd5tQM+MyEAROgFOqke9nPgt8/dX52XvIKWvTah4zCcuvyP20KLuDXcI+h/1C7O6/xOhysQ/+s2Eo3Mn36BRBl+lVKW7hvZS0cje15WVorQ7uc9b7GTeygyVKKjRLuwojlrDiwFhE0l6OdanmUq4uafgMYHIfa6faRLKF+MgxKkVe8FQnJg8+EhPb1JkFCqyW+0=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR22MB3092.namprd22.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015)(366007)(38070700009); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: eD3S/pPxX6l0uKwpWpVtNPmj1HFNuP7VTwnKVQ7Nl2OsjOK1M2504nrzdplXJ3IT9+f1pT9D52kx8q8CtT7V8AN8qLwkLMnlsCOAh4nljSz14WNuHJmYAxAleb8gB1K3+PWiKVaemHIFpI0SwxldnoBIfRRC2fBtJf8C+533CLEgbCAD3ktCQvGt3N6JYM3Vf+FAWk5J5LbM1llJzxchi0xfMJ4HjzMr5+La9FkPjwKE/1J+mbhdselvHGeVSn+xIXvjmidMSDg6tBnEL/PhTCGXplnO/ULfqO96fxISpo91wBfKiuyIOPKFfN5U5Krxc+NXl0Wkz/RGtxywzdM+WWbC4vkm7ObmzCiTEDQWx3jlY1Wt1iwA1++JWkEAqqf+b3cdQsxz9POfq/5QG1aS2kG2Nyl9TeRZB1W+jGZimfX8Mwh0wovqMn0QAf9Tb3cMKJviQrwSr04bmgSUwim7M2/eJ4oJS+jxRLNymtLlC+diD2k/QYaEl1VfZIAamBaJFAHcGsP0837dr3TaS0dFr7Qg5uz+957QJdGk1gRAiAFLVXBu1u2CmHy2dQ3YCQdBKP/7OrhDLSry7kJ80kd6rkvidCCQhVNgJ03cjhv4iB0b5lZbVQ3GqYCjkMLb2+vn2OG55ucKTWK/3XKRCNpRyGwav0+F3FoqmnVLrqtHE96WZ2iP3F8utUz/TiEfy0Ni/aYGbnPdNQtgMhSyV56W3zA+GoY09IsCG8O73DPzdnRo7RSam7EI7JUKl80ppaZ2aGhkVrhAm5nX4n8DfjEO1J4fcyRtzDFYNnejys/g/HkQ3ejjGypsLycL0A3/ceJTiOph/0Sx7Z7QU3ZrghTIAa0RL8n0Mi2t7EypppLhExy7V61YHjvPjIXTi4olSKLUAuxwCsotXlNGfDA2/gE2ZXkfr638HPifOJOgWnvfWW24pSB/phmQvcogrt6gfO5slP/rPvJuytjVIikvT/f977yVw3bmRCEsnxSDBvdzKdK5hKvUiemQSYnurvLp4MdBGo80c2XxhAmlfTwCg4qFh4GGBGXC9EyKAvmFgzCKHZtYzk5ynCPSvMyvrxemboHGB4A8FW9QKpRGmMSP5esw7poDr5bup43uqbbeumNnH7hAJ/E8qUPu7TRoME4Ezexvfwjo/ucPralT8mLXp5QJf1NPr33FnrQcEnJUgUGV+ES5KA+OePF0TO6518fNAHs3xZ8F/zx6i/alrk5Y1y59q77rAcVZaWl7a2FuQfv1PozWFsLgN4l6dWR5XwLlSACScjwSp0W+MYWVVbYLqDZ/QLYMw2idtEe0ZdnEUmatDGJIXSmiDdx0+Z1b9NT4NEZB3chb71Mp/yMsCdntrCvHpcrSJu0SA0I/S/mZFaWMrxkO9nNy55hSMvCer/66m5XKgPG6xIl5Jt2ukSvxyU9Opk/fmlsfAQAuCwLqRfhJdcHYWzuO7ZUk9CTIbmbDC4xbEH1gldJl+U2xsa5UgWL0y+TTwslorGKh5I7rNHgDFB+04RoWUy/lgDd55y5ff+D0byuerrPsedib9Ro0T2dHCzDZZ2cswp0grzr2boZIlTUAZuEM+elZCNp/ACTt7dHOMbJOYHblYysrppfEKDJgnA==
Content-Type: multipart/alternative; boundary="_000_EF87DF03848345DDAA808E885BB78F75islandresortcom_"
MIME-Version: 1.0
X-OriginatorOrg: island-resort.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH7PR22MB3092.namprd22.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 92eafcfd-dee3-4036-fe8a-08dc5a184e86
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2024 11:12:42.2429 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: ad4b5b91-a549-4435-8c42-a30bf94d14a8
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: GRzCrjyYIGKPsMM/MuO4ZcX01wESCo0njknv58JzG+dFT1vbP8LJx4gBTbBbopSP6xtmiGF4VeqKsJN5jleFYQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR22MB3171
Archived-At: <https://mailarchive.ietf.org/arch/msg/cbor/bh9P90Zt3liMy1DDM_KWbF5RK0g>
Subject: Re: [Cbor] Reviews and shepherd for draft-ietf-cbor-cddl-more-control
X-BeenThere: cbor@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "Concise Binary Object Representation \(CBOR\)" <cbor.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/cbor>, <mailto:cbor-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cbor/>
List-Post: <mailto:cbor@ietf.org>
List-Help: <mailto:cbor-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/cbor>, <mailto:cbor-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Apr 2024 11:12:51 -0000

On Apr 9, 2024, at 11:49 AM, Carsten Bormann <cabo@tzi.org> wrote:


Ideally, I’d try re doing the cddl for EAT with these to see how they work. EAT does a lot of CBOR-JSON mixing so it’s a good test. Thomas offered to help too. I’m not going to promise completing that, but I’ll give it a try.

That would certainly be a good, realistic test!

I've done some work on this, mostly putting .b64u to work. Much is good and makes the CDDL neater and validation more thorough. The interesting one is validating https://github.com/ietf-rats-wg/eat/blob/master/cddl/Example-Tokens/deb.json

b64u should work on text strings, not just on byte strings. In JWT, JSON-to-be signed is b64-encoded so we did the same in EAT. In deb.json, there are JSON-format Claims-Sets that are b64 encoded. The validation should be able to fully descend into them.

The controller for .json names a CDDL group that can be arbitrarily complex CDDL, right?

Plaining to try out .join to validate the JWT message, a series of b64 strings separated by “.”.

The wording in the draft for .b64u and friends should probably be more like standards language. For example:

    The target of .b64u MUST be a text string type

    The controller MUST be a byte string type (or a text string type)

Probably need to use “target” and “controller” in other places too.

All the members in the .join controller array must be text, right? It should say so.

So far not sure what to make of the comment about complex use of .join and switching to ABNF.  Seems more like tool documentation than a standards. Is there a second implementation of cddl validation?

It would be nice if the cddl tool had a —version option so you could know easily what you have and put version dependency in document validation scripts. I wasn’t planning on updating the CDDL in the to-be-published EAT because you can’t error out saying “you need a new version of the cddl tool”.

LL