Re: [codec] draft-ietf-codec-oggopus and "album" gain

Calvin Walton <calvin.walton@kepstin.ca> Mon, 04 August 2014 18:41 UTC

Return-Path: <calvin.walton@kepstin.ca>
X-Original-To: codec@ietfa.amsl.com
Delivered-To: codec@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6BB201A00FC for <codec@ietfa.amsl.com>; Mon, 4 Aug 2014 11:41:06 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.001
X-Spam-Level:
X-Spam-Status: No, score=-2.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QstNHguuCmzI for <codec@ietfa.amsl.com>; Mon, 4 Aug 2014 11:41:01 -0700 (PDT)
Received: from mail-ig0-x22b.google.com (mail-ig0-x22b.google.com [IPv6:2607:f8b0:4001:c05::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A6B7F1A0110 for <codec@ietf.org>; Mon, 4 Aug 2014 11:40:04 -0700 (PDT)
Received: by mail-ig0-f171.google.com with SMTP id l13so5822414iga.10 for <codec@ietf.org>; Mon, 04 Aug 2014 11:40:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kepstin.ca; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :content-type:mime-version:content-transfer-encoding; bh=ytkgxBxd0B3NrGT7GWjuDrG1N4KciiuxTg3wASK3IUk=; b=YajLcOpTFeUyKvqrB/cKXVmKJ+plq/bIWmK+iR9Rj6V4NrKWdXfBoTCrJ24UjJBDWG PlyTbn8qrlLgYGnVI41OBkG/vGejmLNIbDemNcSyDnM42+kS64ZwNRCfarnk0uilXShF zxBnYKuk9ttRJobJIlY4F4smpRu53QTiw2yCU=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-type:mime-version:content-transfer-encoding; bh=ytkgxBxd0B3NrGT7GWjuDrG1N4KciiuxTg3wASK3IUk=; b=KLT1kKnzqwzCVMZsTukd43Br2SBng9d3EBohFxoZ1NfBI8n6av5VFaD0ZlJI2aoPmz gM/pLQbu5WCNdUjGJUQPJOg7Y8FBWORoAw+TEK7glaV1SZY7ZPWRzjFsVtI4UIZS1hRX TlmavXcr+b01URU+I2xq69zBygpo34nRK/lilhYMkYpwf9uNTwBQiei8UKOKLQ15yRiW 4VlGppLKHowashTIAa2NRMT0mlxS4hfwcjPgE8FIJgul1TAg62MYFaL9mkdVJtdj/Bfk 5NWXYj2HS+YunPpOg+e5BLyUKpGzjPtr2PHRj8GnCynHlv3BlCo2UTw/xB4Aeb8hOvhj RMyg==
X-Gm-Message-State: ALoCoQkJoY30gWSHhFKqIpxnvEW85KW+JXamLvgDxlgkhp9NUEjeZmVPnnvAHFRV++79PDlv4NYZ
X-Received: by 10.50.142.97 with SMTP id rv1mr40513995igb.13.1407177603888; Mon, 04 Aug 2014 11:40:03 -0700 (PDT)
Received: from [10.210.0.33] ([12.160.0.155]) by mx.google.com with ESMTPSA id y14sm10638223igg.0.2014.08.04.11.40.03 for <multiple recipients> (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Aug 2014 11:40:03 -0700 (PDT)
Message-ID: <1407177600.963.1.camel@kepstin.ca>
From: Calvin Walton <calvin.walton@kepstin.ca>
To: Gregory Maxwell <greg@xiph.org>
Date: Mon, 04 Aug 2014 13:40:00 -0500
In-Reply-To: <CAAS2fgSL+LGVSUDN=hJ9Jxeu1u7_jrfs1E_b7U5b9Y2bF67CaA@mail.gmail.com>
References: <CAAS2fgSL+LGVSUDN=hJ9Jxeu1u7_jrfs1E_b7U5b9Y2bF67CaA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.4
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Archived-At: http://mailarchive.ietf.org/arch/msg/codec/wY9FWYuOrt9BfVX6cY7rM63ydto
Cc: codec@ietf.org
Subject: Re: [codec] draft-ietf-codec-oggopus and "album" gain
X-BeenThere: codec@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Codec WG <codec.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/codec>, <mailto:codec-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/codec/>
List-Post: <mailto:codec@ietf.org>
List-Help: <mailto:codec-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/codec>, <mailto:codec-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Aug 2014 18:41:06 -0000

Hi, I noticed a typo in the diff; see the inline note below.

Note that I'm still of the opinion that there should not be any language
in the spec that explicitly disallows use of the REPLAYGAIN_*_GAIN tags
as implemented in Vorbis; the use of these tags in Ogg Opus is already
interoperable with many applications including Rockbox, GStreamer-based
players like Rhythmbox, and foobar2000 (when added manually via an
external tool).

Perhaps there should be something that states that if both R128_*_GAIN
and REPLAYGAIN_*_GAIN tags are present, the application should use
either one set or the other, but not attempt to apply both.

On Thu, 1970-01-01 at 00:00 +0000, Gregory Maxwell wrote:
> There have been a comments from a number of implementers that their
> applications would like to know if "album" gain adjustment had been
> performed on a track. An album gain is a feature the replaygain
> tagging has which allowed the dynamics within a collection of tracks
> to be preserved while still normalizing the collection overall.
> 
> Right now, the draft just recommends the encoder store it in the
> header gain field— which works okay but doesn't allow a player to know
> for sure which gain is being applied.
> 
> To clear this up I'm proposing we add a R128_ALBUM_GAIN which works
> just like R128_TRACK_GAIN and which can be set to zero when the header
> gain matches the album gain.
> 
> Here is a diff against the current draft:

[...]

> -An Ogg Opus file MUST NOT have more than one such tag, and if present its
> - value MUST be an integer from -32768 to 32767, inclusive, represented in
> +An Ogg Opus file MUST NOT have more than one of each tags, and if present
> + their values MUST be an integer from -32768 to 32767, inclusive,
> represented in
>   ASCII with no whitespace.
> -If present, it MUST correctly represent the R128 normalization gain relative
> - to the 'output gain' field specified in the ID header.
> -If a player chooses to make use of the R128_TRACK_GAIN tag, it MUST be
> - applied <spanx style="emph">in addition</spanx> to the 'output gain' value.
> +If present, REPLAYGAIN_TRACK_GAIN MUST correctly represent the R128

This should be "R128_TRACK_GAIN"

> _______________________________________________
> codec mailing list
> codec@ietf.org
> https://www.ietf.org/mailman/listinfo/codec

-- 
Calvin Walton <calvin.walton@kepstin.ca>