Re: [core] progressing ietf-core-yang-cbor and ietf-core-sid

[Ivaylo Petrov <[e-mail]>]

That really sounds better. Thank you, Michael! I updated the
description in the YANG module as you suggested.

I added more clarification text at the end of Appendix B:

    Note that ".sid" file versions are specific to a YANG module
revision. For each
    new YANG module or each new revision of an existing YANG module, the version
    number of the initial ".sid" file should either be 0 or should not
be present.

Best regards,
Ivaylo


Ivaylo Petrov

Chief Architect

[phone]

www.ackl.io



CONFIDENTIALITY NOTICE: This email may contain confidential and
privileged material for the sole use of the intended recipient(s).

It is strictly forbidden to share any part of this message with any
third party, without the written consent of the sender.

If you have received this message by mistake, please notify the sender
immediately by email and delete the message and any file attached to
it. Thank you!



On Wed, Feb 5, 2020 at 1:45 PM Michael Richardson <[e-mail]> wrote:
>
>
> Ivaylo Petrov <[e-mail]> wrote:
>     > leaf sid-file-version {
>     > type sid-file-version-identifier;
>     > description
>     > "Version number of the \".sid\" file. Useful to distinguish \".sid\"
>     > files generated using different YANG module dependencies that might not
>     > be reflected in the YANG module revision.";
>     > }
>
> ...
>     > +In case of an update to an existing ".sid" file, an additional step is needed
>     > +that increments the ".sid" file version number. If there was no version number
>     > +in the previous version of the ".sid" file, 0 is assumed as the version number
>     > +of the old version of the ".sid" file and the version number is 1 for the new
>     > +".sid" file. Apart from that, changes of SID files can also be automated using
>     > +the same method described above, only unassigned YÀNG items are processed at
>     > +step #3. Already existing items in the SID file should not be given new SIDs.
>
> I don't think that this adequately makes it clear (hits them on the head...) that the
> sid-file-version-identifier is specific to the YANG module revision.
>
> Could you reword to:
> description
>  "The version number of the \".sid\" file. \".sid\" files and the version
>   sequence are specific to a given YANG module revision.
>   This number starts at zero when there is a YANG module update.
>   This number can distinguish updates to the SID file which are the result of
>   new processing, or the result of reported errata. ";
>
> --
> Michael Richardson <[e-mail]>, Sandelman Software Works
>  -= IPv6 IoT consulting =-
>
>
>