Re: [dnssd] WGLC for draft-ietf-dnssd-update-lease

Ted Lemon <mellon@fugue.com> Thu, 06 October 2022 15:38 UTC

Return-Path: <mellon@fugue.com>
X-Original-To: dnssd@ietfa.amsl.com
Delivered-To: dnssd@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9DD16C152584 for <dnssd@ietfa.amsl.com>; Thu, 6 Oct 2022 08:38:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.906
X-Spam-Level:
X-Spam-Status: No, score=-1.906 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=fugue-com.20210112.gappssmtp.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vo1S3GRMEEb5 for <dnssd@ietfa.amsl.com>; Thu, 6 Oct 2022 08:38:48 -0700 (PDT)
Received: from mail-yw1-x112a.google.com (mail-yw1-x112a.google.com [IPv6:2607:f8b0:4864:20::112a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 66886C14F719 for <dnssd@ietf.org>; Thu, 6 Oct 2022 08:38:48 -0700 (PDT)
Received: by mail-yw1-x112a.google.com with SMTP id 00721157ae682-349c4310cf7so21253127b3.3 for <dnssd@ietf.org>; Thu, 06 Oct 2022 08:38:47 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fugue-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=N6qtvzxwuKQDC0eXZdbTX81SYJCmxlullBT7JSMjwIk=; b=xHbUH5vk/JCHfEVvHYD8g1+fAQ6H5wO0+sg1RldSOjneB6lNV+Ver0G/qR16VIN1/H adgLEDpBxA43uOJES+aAWZu+2TtGy9LN8qg+gS4ed3xDkW04z5G9XQGSqTeD1HnrhWyw uJQv87nteofFnrGbICKUfYd/i16KaWehLEP/LXBWdKXm1ynABiq+6ZfanMnahgMu646G s4V8FoZveN+vSp7nw7m9LgV4mdjpIof0BVbkwGoZfvK6s4D6jLuNlLSaXKslMwE0Ej/a ycjJu9Yy890HWnC1X66mGUEoZt8A7OSLcriolkeSn1yd164BiwJRpotBknaRmjBqzieX VNuA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=N6qtvzxwuKQDC0eXZdbTX81SYJCmxlullBT7JSMjwIk=; b=RMqimqpAMbxroUGbFzPyRGdZAbmkZVvqceDp+oZx8VTGU+AvvYWVMoEvi/cfo4SDhR RlOkEoc7eoi+fFl1ebThgOtriLNmFX1OIUNBfuTsB0cXcLbqt2LNKkYqYFUZn8xhX4nL XrtS/INYYOHTrSWWb5SGxFVjMxjVz2x2kugPdkii6bC9eEvPDZ5CCJgUPxPUsR5RfTRK nb8PLMs3nGFKhchk9DmRF1lMIv7I8xruQO99VLiTx85R+Wsy4pB8K8uGoiQIOJYaWj+a dWP4Zf/Hv3WbmToD2zzlDU22M0HHlxl+CGmxZD2NdiHpymVNUOdsDywkexjIhiva5tPb fgJQ==
X-Gm-Message-State: ACrzQf3/35UQIUEQ7J0I1H6WLs+TkHehr3FIBnIRM/w1/Z3MGyaNkt+G XSdJDU9nVlj2+zPzeFq6x2yA62LYYVK659plmyJeYA==
X-Google-Smtp-Source: AMsMyM5iLugQV2qLsn4f9HcIHzO7s7F1k90zIPmK88X/OElEaL7Mfn6xrp6Fwe/JG6PMgYUkr0kx39Ecr1wvMlAuE6U=
X-Received: by 2002:a81:80c3:0:b0:349:8498:a05b with SMTP id q186-20020a8180c3000000b003498498a05bmr356745ywf.403.1665070726709; Thu, 06 Oct 2022 08:38:46 -0700 (PDT)
MIME-Version: 1.0
References: <CAPDSy+60hp4P2PKzkkwoP+fqG5ECrNAN_Wqzjkx8Gz6N2Ljdkg@mail.gmail.com> <DU0P190MB1978D98964F8B3CA948C4804FD6C9@DU0P190MB1978.EURP190.PROD.OUTLOOK.COM> <SG2PR02MB3782BCAF7BEEDBFA3415F42AC06F9@SG2PR02MB3782.apcprd02.prod.outlook.com> <8e0deeafc3ab4161967cc997e03bb7fa@infineon.com> <4d7601d8b5d5$7dadbff0$79093fd0$@yahoo.com> <CAJ5Rr7YWCv=mpPfxpnMjik6mN9mYCCmPxf8_9TKORYNqH6eNNA@mail.gmail.com>
In-Reply-To: <CAJ5Rr7YWCv=mpPfxpnMjik6mN9mYCCmPxf8_9TKORYNqH6eNNA@mail.gmail.com>
From: Ted Lemon <mellon@fugue.com>
Date: Thu, 06 Oct 2022 11:38:10 -0400
Message-ID: <CAPt1N1nDo33HXGsgpaiWqKh0TwvYMAqpBV_g0ByKXZgZbMaR-A@mail.gmail.com>
To: Kangping Dong <wgtdkp@google.com>
Cc: g_e_montenegro=40yahoo.com@dmarc.ietf.org, Steve.Hanna@infineon.com, nathan@nanoleaf.me, Esko Dijk <esko.dijk@iotconsultancy.nl>, dschinazi.ietf@gmail.com, DNSSD <dnssd@ietf.org>
Content-Type: multipart/alternative; boundary="00000000000031194d05ea5f7d9c"
Archived-At: <https://mailarchive.ietf.org/arch/msg/dnssd/Lg8JvKvJACBN56ATdAOGP0EizDc>
Subject: Re: [dnssd] WGLC for draft-ietf-dnssd-update-lease
X-BeenThere: dnssd@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "Discussion of extensions to DNS-based service discovery for routed networks." <dnssd.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dnssd>, <mailto:dnssd-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dnssd/>
List-Post: <mailto:dnssd@ietf.org>
List-Help: <mailto:dnssd-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dnssd>, <mailto:dnssd-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Oct 2022 15:38:52 -0000

I've made the following change based on your review:

diff --git a/draft-ietf-dnssd-update-lease.xml
b/draft-ietf-dnssd-update-lease.xml
index 88c9cf3..9b35323 100644
--- a/draft-ietf-dnssd-update-lease.xml
+++ b/draft-ietf-dnssd-update-lease.xml
@@ -230,7 +230,9 @@ KEY-LEASE        u_int32_t    optional desired (or
granted)
        <t>When sending Refresh messages, the requestor MUST include an
Update Lease option, as it
        did for the initial Update. The Update Lease option MAY either
specify the same
        intervals as in the initial Update, or MAY use the values returned
by the server in the
-       previous Update, whether it was an initial Update or a Refresh.</t>
+       previous Update, whether it was an initial Update or a Refresh. As
with Update responses,
+        the requestor MUST use the intervals returned by the server in the
response when determining when to
+        send the next refresh message.</t>

        <section>
          <name>Coalescing Refresh Messages</name>

On Sun, Aug 21, 2022 at 11:58 PM Kangping Dong <wgtdkp@google.com> wrote:

> I have reviewed this document and I think it's ready to publish.
>
> Just a small suggestion:
> We mentioned how servers should handle lease requests in section-4
> <https://datatracker.ietf.org/doc/html/draft-sekar-dns-ul-03#section-4>
> and section-5.3
> <https://datatracker.ietf.org/doc/html/draft-sekar-dns-ul-03#section-5.3> with
> a response including the granted lease(s),
> but it doesn't say how the client should handle the lease response. IIUC,
> the client should reset its refresh timer to be fired LEASE_RESPONSED
> seconds later, but implementers may hesitate in below cases for what lease
> time they should use for new update messages: If the server returns a
> shorter lease, should the client use the shorter lease even if it's a
> battery-backed device and wants to save power?
>
> Requiring the client to always respect the server responses works for me,
> but we probably want to make client behavior clear to make section-5.3
> complete :)
>
>
>
> BRs,
> Kangping
>
> On Mon, Aug 22, 2022 at 11:16 AM <g_e_montenegro=
> 40yahoo.com@dmarc.ietf.org> wrote:
>
>> Hi folks,
>>
>>
>>
>> I have read the Update document and I believe it is ready to advance to
>> the IESG.
>>
>>
>>
>> Thanks to Stuart and Ted for all the work so far!
>>
>>
>>
>> Gabriel
>>
>>
>>
>> *From:* dnssd <dnssd-bounces@ietf.org> *On Behalf Of *
>> Steve.Hanna@infineon.com
>> *Sent:* Saturday, August 20, 2022 11:32
>> *To:* nathan@nanoleaf.me; esko.dijk@iotconsultancy.nl;
>> dschinazi.ietf@gmail.com; dnssd@ietf.org
>> *Cc:* mellon@fugue.com
>> *Subject:* Re: [dnssd] WGLC for draft-ietf-dnssd-update-lease
>>
>>
>>
>> I have also reviewed this document in detail and consider it valuable and
>> ready to publish.
>>
>>
>>
>> I did notice one typo and one minor grammar issue.
>>
>>
>>
>> The last line of section 5.2 (just before 5.2.1) includes the word
>> “initil”. That should be “initial”.
>>
>>
>>
>> Section 9 (Acknowledgments) includes this sentence:
>>
>>    Thanks to Marc Krochmal and Kiren Sekar to their work in 2006 on the
>> precursor to this document.
>>
>> I believe this should be “for their work” not “to their work”.
>>
>>
>>
>> Thanks,
>>
>>
>>
>> Steve
>>
>>
>>
>> *From:* dnssd <dnssd-bounces@ietf.org> *On Behalf Of *Nathan Dyck
>> *Sent:* Saturday, August 20, 2022 10:50 AM
>> *To:* Esko Dijk <esko.dijk@iotconsultancy.nl>; David Schinazi <
>> dschinazi.ietf@gmail.com>; DNSSD <dnssd@ietf.org>
>> *Cc:* Ted Lemon <mellon@fugue.com>
>> *Subject:* Re: [dnssd] WGLC for draft-ietf-dnssd-update-lease
>>
>>
>>
>> *Caution*: This e-mail originated outside Infineon Technologies. Do not
>> click on links or open attachments unless you validate it is safe
>> <https://intranet-content.infineon.com/explore/aboutinfineon/rules/informationsecurity/ug/SocialEngineering/Pages/SocialEngineeringElements_en.aspx>
>> .
>>
>>
>>
>> I’ve reviewed. Looks good to publish
>>
>>
>>
>> Nathan
>>
>>
>>
>> -
>>
>> Nathan Dyck
>>
>> Chief Product Officer
>>
>> The Nanoleaf Team
>>
>> e: nathan@nanoleaf.me | c: 289-242-0016
>>
>>
>>
>> Sent from Mobile
>> ------------------------------
>>
>> *From:* dnssd <dnssd-bounces@ietf.org> on behalf of Esko Dijk <
>> esko.dijk@iotconsultancy.nl>
>> *Sent:* Friday, August 19, 2022 8:17:22 AM
>> *To:* David Schinazi <dschinazi.ietf@gmail.com>; DNSSD <dnssd@ietf.org>
>> *Cc:* Ted Lemon <mellon@fugue.com>
>> *Subject:* Re: [dnssd] WGLC for draft-ietf-dnssd-update-lease
>>
>>
>>
>> Hi all,
>>
>>
>>
>> I reviewed this document in detail and have only 1 open (technical) issue
>> on it, see below.   This is followed by a few minor review comments.
>>
>> Based on this, I believe the option is quite useful, and the document is
>> ready for publication after the open technical issue is resolved by the WG.
>>
>>
>>
>> Best regards
>>
>> Esko
>>
>>
>>
>> --- Open issue
>>
>> 4.2
>>
>> Based on the stated requirements in 4, a server developer could assume
>> the following scenarios are okay:
>>
>>    - requester sends the basic Option (lease time only), and the server
>>    responds with the extended Option (lease / key-lease separately)
>>    - requester sends extended Option and the server responds basic
>>    Option.
>>
>> A client developer could assume based on the same text that one or both
>> of these scenarios are not okay / prohibited.
>>
>>
>>
>> To guarantee interoperability for such cases, we need to say in 4.2
>> either that a server MAY do this, or alternatively that a server MUST NOT
>> do this responding with a different option format.  It could be even a rule
>> that the server can “lengthen” the Option but not “shorten” it.
>>
>>
>>
>> I don’t have a preference on the solution chosen as long as we pick
>> something.  Noting that for the client’s point of view, if the server
>> always responds with the same Option Format it is simpler to implement.
>>
>> On the other hand this reduces the flexibility of the server – e.g.
>> suppose the client asks for 1 week lease (short Option format) and the
>> server can only grant 27 hours LEASE but can grant 2 weeks KEY-LEASE – then
>> the server would like to respond with the extended Option format.
>>
>>
>>
>>
>>
>> ---- Minor review comments
>>
>>
>>
>> General
>>
>> EDNS0 vs EDNS(0) – is there a reason for the different spellings?
>>
>>
>>
>> 5.1
>>
>> “The LEASE interval indicated in the Update Lease option applies to all
>> resource
>>
>>    records in the Update section, except that … ”
>>
>> -> “in the Update section” may be unclear here. There’s an Update section
>> in the request, but is there also one in the Response (I assume not
>> necessarily )?
>>
>> -> Easiest here would be to say maybe:
>>
>> “The LEASE interval indicated in the Update Lease option applies to all
>> resource
>>
>>    records in the Update section of the Refresh request, except that … ”
>>
>>
>>
>> 5.2
>>
>> “A requestor that intends that its records from a previous update,
>>
>>    whether an initial update or a Refresh, MUST send a Refresh message”
>>
>> -> grammar error in sentence -that intends what? E.g. is it
>>
>> -> “A requestor that intends that its records from a previous update,
>>
>>    whether an initial update or a Refresh, *remain*  *active* MUST send
>> a Refresh message”
>>
>>
>>
>>
>>
>>
>>
>> *From:* dnssd <dnssd-bounces@ietf.org> *On Behalf Of *David Schinazi
>> *Sent:* Tuesday, August 9, 2022 00:45
>> *To:* DNSSD <dnssd@ietf.org>
>> *Subject:* [dnssd] WGLC for draft-ietf-dnssd-update-lease
>>
>>
>>
>> Hi DNSSD enthusiasts,
>>
>>
>>
>> As promised during our meeting at IETF 114 two weeks ago, we are starting
>> a Working Group Last Call (WGLC) for draft-ietf-dnssd-update-lease. As a
>> reminder of our timeline, this document was adopted by the DNSSD WG in
>> September 2021, folks made comments during that adoption call, and those
>> comments were addressed by the authors in July 2022. Additionally,
>> progressing this document is required for us to publish
>> draft-ietf-dnssd-srp. This WGLC will last for two weeks until 2022-08-22 at
>> 23:59 UTC. We're interested in hearing whether folks have read this
>> document and think it is ready for publication. We're also interested in
>> hearing from folks who think the document isn't ready, or who see issues
>> that need to be resolved before publication.
>>
>>
>>
>> The latest draft is available here:
>>
>> https://datatracker.ietf.org/doc/draft-ietf-dnssd-update-lease/
>>
>>
>>
>> Please send responses to the DNSSD list as replies to this email.
>>
>>
>>
>> Thanks,
>>
>> David and Chris
>> _______________________________________________
>> dnssd mailing list
>> dnssd@ietf.org
>> https://www.ietf.org/mailman/listinfo/dnssd
>>
>