Re: [dnssd] WGLC for draft-ietf-dnssd-update-lease

Jonathan Hui <jonhui@google.com> Thu, 13 October 2022 21:47 UTC

Return-Path: <jonhui@google.com>
X-Original-To: dnssd@ietfa.amsl.com
Delivered-To: dnssd@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D5C93C14CE34 for <dnssd@ietfa.amsl.com>; Thu, 13 Oct 2022 14:47:22 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -22.608
X-Spam-Level:
X-Spam-Status: No, score=-22.608 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=google.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Iw6daZOVccWz for <dnssd@ietfa.amsl.com>; Thu, 13 Oct 2022 14:47:20 -0700 (PDT)
Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8E56EC14F74C for <dnssd@ietf.org>; Thu, 13 Oct 2022 14:47:20 -0700 (PDT)
Received: by mail-wr1-x42c.google.com with SMTP id u10so4867904wrq.2 for <dnssd@ietf.org>; Thu, 13 Oct 2022 14:47:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=oDLC9PCRxZMZwd7pycLX0keA65yQnM3bvqzPrJtTNfI=; b=HgvQIcmdtuO5GNiuHWrugZQAuFF3Hy8/SejVsILPfhSTqrA+n+AsFwI/st8BoDCLM4 vogC/WIo5WVUrTSJUWahhEmZwdHsboqwSZXddRG1FQcISW/XGsSxeFVpmp59xgy+yC99 FwuW4tZBxM8e5mliqGNMkTidIGFrYfynVw+S+YLL5jn2TbaDmBRowjh/GchI35qXHOqq cqUGAENsktq8p6qL+lJBQjuNh8bCFkLnUwITmrAjnZJBKP+y9Zh1IKgheO1GzPTYTudd s9RO/09cDFijvrhj7KZ4gfZq3DJEdHMn9HGHq77kUtCAjPSF9qjNYx2AMBJizym5ab+7 fNAA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oDLC9PCRxZMZwd7pycLX0keA65yQnM3bvqzPrJtTNfI=; b=Yt7P5j/snxI6N/kfj6JWcLwGl7R7WGOCxOedHpl5KYi9/czcGvtwJ7kiMspFesYO/M JvgnO2evZKiXE/of76sr2Ljc8A3UFBIlyC64+k+gdji3CflnPOnJwYmuR/BDTrowMHqq 6LpvLIjpxMHzZJBSOx/VsUYhzBbTIPBUjTzftD/vlcUJ5TvC9+lNmPdiGu5wT5X8KMO1 8BH+gw++tPCMAzWm7Hg2pNfC1smAcyIxfyjaRQyASBzKF0MXxMP5MVW5hmzh5kYJJjXl 0jKaazd26sw4zhkYHBbFLueReBClkGkxSsLwZtnzdq7enG+3+vOAVFmFxP/XUMSMB4t7 +DTw==
X-Gm-Message-State: ACrzQf3tne4ZTyAH8F9eOolWLBrMjQrctBoBSKA+GP0BdP/8b+aWOQu0 Ac1JrUiZT62zyzwOrQReVHkCIddIx4fVguzg990QyBkvr4g=
X-Google-Smtp-Source: AMsMyM6b81BtxH1BUfPAOr4k0YhoN+nRAaEqG4co7cGGnXYAuTLVrPLPgvTk9A2fjfORQvqJZ3GUE79ztrjsfeNWfj0=
X-Received: by 2002:adf:db10:0:b0:231:bcaa:313b with SMTP id s16-20020adfdb10000000b00231bcaa313bmr1222496wri.142.1665697638432; Thu, 13 Oct 2022 14:47:18 -0700 (PDT)
MIME-Version: 1.0
References: <CAPDSy+60hp4P2PKzkkwoP+fqG5ECrNAN_Wqzjkx8Gz6N2Ljdkg@mail.gmail.com> <CAGwZUDsf6hLBku=yx6uhBHPftw0f3DpxBTvmqaSRWmy4qsfQWw@mail.gmail.com> <CAPt1N1nKhwYfCC2UCuVJ6ez_RBE=g+WmfZiS_k=2g=-gw937hQ@mail.gmail.com>
In-Reply-To: <CAPt1N1nKhwYfCC2UCuVJ6ez_RBE=g+WmfZiS_k=2g=-gw937hQ@mail.gmail.com>
From: Jonathan Hui <jonhui@google.com>
Date: Thu, 13 Oct 2022 14:47:06 -0700
Message-ID: <CAGwZUDujEYkFJ5N4XCQNFhzzX05weL3KbE9gXttb1XSUCQW4aQ@mail.gmail.com>
To: Ted Lemon <mellon@fugue.com>
Cc: Jonathan Hui <jonhui=40google.com@dmarc.ietf.org>, David Schinazi <dschinazi.ietf@gmail.com>, DNSSD <dnssd@ietf.org>
Content-Type: multipart/alternative; boundary="0000000000000b5c1805eaf17411"
Archived-At: <https://mailarchive.ietf.org/arch/msg/dnssd/nTKm8gXR_37wplcDQdN7OSpqrSA>
Subject: Re: [dnssd] WGLC for draft-ietf-dnssd-update-lease
X-BeenThere: dnssd@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "Discussion of extensions to DNS-based service discovery for routed networks." <dnssd.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dnssd>, <mailto:dnssd-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dnssd/>
List-Post: <mailto:dnssd@ietf.org>
List-Help: <mailto:dnssd-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dnssd>, <mailto:dnssd-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Oct 2022 21:47:22 -0000

Looks good to me. Thanks for addressing my comments!

--
Jonathan Hui



On Thu, Oct 6, 2022 at 7:53 AM Ted Lemon <mellon@fugue.com> wrote:

> I've updated the text as follows:
>
> diff --git a/draft-ietf-dnssd-update-lease.xml
> b/draft-ietf-dnssd-update-lease.xml
> index 05f2b81..2348c4f 100644
> --- a/draft-ietf-dnssd-update-lease.xml
> +++ b/draft-ietf-dnssd-update-lease.xml
> @@ -106,7 +106,7 @@
>        Update messages <xref target="RFC2136"/>. This update MUST include
> the EDNS0 OPT RR, as
>        described in <xref target="RFC6891"/>.  This OPT RR MUST include an
> EDNS0 Option as shown
>        below.  Note that if a TSIG resource record (<xref
> target="RFC2845"/>) is included to
> -      authenticate the update, the TSIG RR should appear <em>after</em>
> the OPT RR, allowing the
> +      authenticate the update, the TSIG RR MUST appear <em>after</em> the
> OPT RR, allowing the
>        message digest in the TSIG to cover the OPT RR.</t>
>
>        <t>The Update Lease EDNS0 option is formatted as follows:</t>
> @@ -184,14 +184,14 @@ KEY-LEASE        u_int32_t    optional desired (or
> granted)
>         <name>Refresh Message Format</name>
>
>          <t>Refresh messages are formatted like Dynamic Update Leases
> Requests and Responses (see
> -        <xref target="update"/> "Update Message Format"). The Refresh
> message should be
> +        <xref target="update"/> "Update Message Format"). The Refresh
> message is
>          constructed with the assumption that the result of the previous
> update or Refresh is
> -        still in effect. The Refresh message should, in the case that the
> records added in a
> +        still in effect. The Refresh message will, in the case that the
> records added in a
>          previous update were for some reason garbage collected, result in
> those records being
>          added again.</t>
>
> -       <t>The Refresh message should not include any update prerequisites
> that would, if the state
> -       produced by the previous update or Refresh is still in effect,
> fail. The update should not
> +       <t>The Refresh message SHOULD NOT include any update prerequisites
> that would, if the state
> +       produced by the previous update or Refresh is still in effect,
> fail. The update SHOULD NOT
>         be constructed to fail in the case that the state produced by the
> previous update or Refresh
>         has for some reason been garbage collected.</t>
>
> @@ -238,7 +238,7 @@ KEY-LEASE        u_int32_t    optional desired (or
> granted)
>           the server, including those not yet close to expiration, so long
> as at least one
>           resource record in the message has elapsed at least 75% of its
> original lease. If the
>           requestor uses UDP, the requestor MUST NOT coalesce Refresh
> messages if doing so would
> -         cause truncation of the message; in this case, multiple messages
> or TCP should be
> +         cause truncation of the message; in this case, either multiple
> messages or TCP SHOULD be
>           used.</t>
>
>           <t>Requestors SHOULD NOT send a Refresh messages when all of the
> records in the
> On Wed, Aug 17, 2022 at 1:48 PM Jonathan Hui <jonhui=
> 40google.com@dmarc.ietf.org> wrote:
>
>> I have reviewed the latest version of this document
>> (draft-ietf-dnssd-update-lease-02) and believe it is ready to publish (with
>> some minor nits noted below).
>>
>> The OpenThread implementation of SRP includes the Update Lease option and
>> is up-to-date with the latest draft. It is being used by a number of
>> community members, especially those implementing Matter. I am not aware of
>> any open issues regarding usage of the Update Lease option.
>>
>> Minor comments:
>>
>> Section 4: "the TSIG RR should appear _after_", should this be normative
>> "SHOULD"?
>>
>> Section 5.1: many statements with non-normative "should", should these be
>> normative "SHOULD"?
>>
>> --
>> Jonathan Hui
>>
>>
>>
>> On Mon, Aug 8, 2022 at 3:45 PM David Schinazi <dschinazi.ietf@gmail.com>
>> wrote:
>>
>>> Hi DNSSD enthusiasts,
>>>
>>> As promised during our meeting at IETF 114 two weeks ago, we are
>>> starting a Working Group Last Call (WGLC)
>>> for draft-ietf-dnssd-update-lease. As a reminder of our timeline, this
>>> document was adopted by the DNSSD WG in September 2021, folks made comments
>>> during that adoption call, and those comments were addressed by the authors
>>> in July 2022. Additionally, progressing this document is required for us to
>>> publish draft-ietf-dnssd-srp. This WGLC will last for two weeks until
>>> 2022-08-22 at 23:59 UTC. We're interested in hearing whether folks have
>>> read this document and think it is ready for publication. We're also
>>> interested in hearing from folks who think the document isn't ready, or who
>>> see issues that need to be resolved before publication.
>>>
>>> The latest draft is available here:
>>> https://datatracker.ietf.org/doc/draft-ietf-dnssd-update-lease/
>>>
>>> Please send responses to the DNSSD list as replies to this email.
>>>
>>> Thanks,
>>> David and Chris
>>> _______________________________________________
>>> dnssd mailing list
>>> dnssd@ietf.org
>>> https://www.ietf.org/mailman/listinfo/dnssd
>>>
>> _______________________________________________
>> dnssd mailing list
>> dnssd@ietf.org
>> https://www.ietf.org/mailman/listinfo/dnssd
>>
> _______________________________________________
> dnssd mailing list
> dnssd@ietf.org
> https://www.ietf.org/mailman/listinfo/dnssd
>