IETF Logo Mail Archive

[Gen-art] Gen-ART review of draft-ietf-dime-e2e-sec-req-04.txt

Christer Holmberg <christer.holmberg@ericsson.com> Sat, 07 May 2016 14:49 UTC

Return-Path: <christer.holmberg@ericsson.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B04F712B052 for <gen-art@ietfa.amsl.com>; Sat, 7 May 2016 07:49:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.22
X-Spam-Level:
X-Spam-Status: No, score=-4.22 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id w6-xSR0pTMwF for <gen-art@ietfa.amsl.com>; Sat, 7 May 2016 07:49:48 -0700 (PDT)
Received: from sesbmg23.ericsson.net (sesbmg23.ericsson.net [193.180.251.37]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 46E5C12B03F for <gen-art@ietf.org>; Sat, 7 May 2016 07:49:48 -0700 (PDT)
X-AuditID: c1b4fb25-f79f26d00000327e-ca-572e0089e89d
Received: from ESESSHC005.ericsson.se (Unknown_Domain [153.88.183.33]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id 55.1C.12926.9800E275; Sat, 7 May 2016 16:49:45 +0200 (CEST)
Received: from ESESSMB209.ericsson.se ([169.254.9.117]) by ESESSHC005.ericsson.se ([153.88.183.33]) with mapi id 14.03.0248.002; Sat, 7 May 2016 16:48:54 +0200
From: Christer Holmberg <christer.holmberg@ericsson.com>
To: "gen-art@ietf.org" <gen-art@ietf.org>
Thread-Topic: Gen-ART review of draft-ietf-dime-e2e-sec-req-04.txt
Thread-Index: AdGobKORkU26nQ5DTHKN5mwC1RYdFQ==
Date: Sat, 07 May 2016 14:48:54 +0000
Message-ID: <7594FB04B1934943A5C02806D1A2204B37F96BF6@ESESSMB209.ericsson.se>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [153.88.183.150]
Content-Type: multipart/alternative; boundary="_000_7594FB04B1934943A5C02806D1A2204B37F96BF6ESESSMB209erics_"
MIME-Version: 1.0
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpjkeLIzCtJLcpLzFFi42KZGbFdUbeTQS/c4MADc4vZBz8zWVx99ZnF gcljyZKfTB5fLn9mC2CK4rJJSc3JLEst0rdL4Mp4ePwUW8GvxIqXTatZGhgvhnYxcnJICJhI 3Dz9kA3CFpO4cG89kM3FISRwhFFizZojTBDOYkaJvcd7WLoYOTjYBCwkuv9pgzSICGhKzF3x lgnEZhZIl/j/r5sVxBYWsJV4sqadHaLGSeL6v5OMELaeROupT2A1LAIqEmsvfgSL8wr4Shyf Pw0szgh0xPdTa6BmikvcejKfCeI4AYkle84zQ9iiEi8f/2OFsJUkVmy/xAhyGrNAvsTKXaYQ IwUlTs58wjKBUXgWkkmzEKpmIamCKNGRWLD7ExuErS2xbOFrZhj7zIHHTMjiCxjZVzGKFqcW J+WmGxnrpRZlJhcX5+fp5aWWbGIExs7BLb9VdzBefuN4iFGAg1GJh1fBRzdciDWxrLgy9xCj BAezkggv/x+gEG9KYmVValF+fFFpTmrxIUZpDhYlcV7/l4rhQgLpiSWp2ampBalFMFkmDk6p BsasBx/33l/QGnPuqfPxSJ3T1uX/lxmLv1/ve674Unn1yUVCG/UuOkx74LTrR6SHvmlZSK6w /wLh17WlLYoqZw6dqZA7Oz/rlc9pad0T64RVbC/omx36zP1ljohZqnHC164bXrH3Vx5askLm 0vFTjvdeMzow3xIRKl9x+1/bxavuHOuOm9j3Hi9RYinOSDTUYi4qTgQA8ueqH5kCAAA=
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/1wHD0Ir0djR_1AF1IK6sRBu47F8>
Cc: "draft-ietf-dime-e2e-sec-req.all@tools.ietf.org" <draft-ietf-dime-e2e-sec-req.all@tools.ietf.org>
Subject: [Gen-art] Gen-ART review of draft-ietf-dime-e2e-sec-req-04.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 07 May 2016 14:49:50 -0000

I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>

Document:                                     draft-ietf-dime-e2e-sec-req-04
Reviewer:                                        Christer Holmberg
Review Date:                                7 May 2016
IETF LC End Date:                        12 April 2016
IETF Telechat Date:                    N/A
Summary:                                      The document is well written, and almost ready for publication is informational RFC. However, I have a few editorial issues, related to the Introduction, that I ask the authors to address.
Major Issues:                                None
Minor Issues:                                None
Editorial Issues:

Q_ABSTRACT_1:

The text says that the draft "discusses" requirements. In my opinion it should say "defines" or "specifies".


Q_INTRODUCTION_1:

Please add references for TLS (for TCP) and DTLS (for SCTP).


Q_INTRODUCTION_2:

The text says: "...or alternative security mechanisms independent of Diameter (e.g., IPsec) is used."

2A: I guess it should be "are used"?

2B: I am not sure I understand what "independent of Diameter" means.


Q_INTRODUCTION_3:

The text talks about security between non-neighbour nodes, while the draft name includes "e2e". However, when reading Section 4, non-neighbour does not necessarily mean end-to-end. I think it would be good to explicitly clarify that in the Introduction.


Q_INTRODUCTION_4:

The text says: "This document collects requirements for developing a solution to protect Diameter AVPs."

2A: It needs to be clear that it's about protecting AVPs between non-neighbour nodes.

2B: Instead of "collect", please use the same terminology as in the Abstract.


Q_INTRODUCTION_5:

              Please enhance AVP on first occurrence. Currently it's not done until Section 3.

v2.23.0 | Report a Bug | By Email