Re: [Gen-art] Genart last call review of draft-ietf-idr-bgp-ls-flex-algo-09

Vijay Gurbani <vijay.gurbani@gmail.com> Sun, 14 August 2022 01:30 UTC

MIME-Version: 1.0
References: <166033385333.7724.14555622442470360665@ietfa.amsl.com> <CAH6gdPxVPGpzLwGWxpHEmUNJKVWZQ1pB7CXPeWxMt4tdQnUX9Q@mail.gmail.com>
In-Reply-To: <CAH6gdPxVPGpzLwGWxpHEmUNJKVWZQ1pB7CXPeWxMt4tdQnUX9Q@mail.gmail.com>
From: Vijay Gurbani <vijay.gurbani@gmail.com>
Date: Sat, 13 Aug 2022 20:30:32 -0500
Message-ID: <CAMMTW_KKuY2DphishuXNpnW=yKr0_N4tTRVE3X=Hf5WfvFNANA@mail.gmail.com>
To: Ketan Talaulikar <ketant.ietf@gmail.com>
Cc: gen-art@ietf.org, draft-ietf-idr-bgp-ls-flex-algo.all@ietf.org, idr@ietf.org, last-call@ietf.org
Content-Type: multipart/alternative; boundary="0000000000001bd1f105e629773a"
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/4VDS-X_PxSCWxLxefQnK0-tHmW0>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-idr-bgp-ls-flex-algo-09
Precedence: list

Dear Ketan: Sounds good.  Thank you for your time attending to my comments.

- vijay

On Sat, Aug 13, 2022 at 12:26 AM Ketan Talaulikar <ketant.ietf@gmail.com>
wrote:

> Hi Vijay,
>
> Thanks for your review and please check inline below for responses.
>
> The changes discussed below would reflect in the next update of the
> document.
>
> On Sat, Aug 13, 2022 at 1:20 AM Vijay Gurbani via Datatracker <
> noreply@ietf.org> wrote:
>
>> Reviewer: Vijay Gurbani
>> Review result: Ready with Nits
>>
>> I am the assigned Gen-ART reviewer for this draft. The General Area
>> Review Team (Gen-ART) reviews all IETF documents being processed
>> by the IESG for the IETF Chair.  Please treat these comments just
>> like any other last call comments.
>>
>> For more information, please see the FAQ at
>>
>> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
>>
>> Document: draft-ietf-idr-bgp-ls-flex-algo-??
>> Reviewer: Vijay K. Gurbani
>> Review Date: 2022-08-12
>> IETF LC End Date: 2022-08-17
>> IESG Telechat date: Not scheduled for a telechat
>>
>> Summary: Draft is ready with nits for a Proposed Standard.
>>
>> Major issues: 0
>>
>> Minor issues: 1 (please see below)
>>
>> Nits/editorial comments: 4 (please see below)
>>
>> Minor:
>> - Sec. 3.6: Note that Type is "TBD" here.  Should this be 1046, as shown
>> in
>>  Table 1?  (Or is the use of 1046 still under discussion?)
>>
>
> KT> This allocation is currently under "Expert Review" - at this point, it
> is a suggested code point. This will hopefully be completed soon and we
> will update the document once done.
>
>
>>
>> Nits:
>> - I note that certain acronyms --- IGP, NLRI, ASLA --- are not defined.  I
>> suspect that these are well-known in the community, hence need no
>> definition.
>> Just in case they are not, you may consider expanding the rare ones on
>> first
>> use.
>
>
> KT> Ack. Fixed some of these acronyms that are not well-known on their
> first use.
>
>
>> - Sec. 1: s/Flexible algorithm is called so as/Flexible algorithm is so
>> called because/
>
>
> KT> Fixed
>
>
>> - Sec. 2: s/Definition(s) (FAD) advertised by a node
>> is/Definition(s) (FAD) advertised by a node is (are)/
>>   Reason: symmetry in the sentence construction
>>
>
> KT> Fixed
>
>
>> - Sec. 3.6: Is Figure 7 missing the trailing "//" for sub-TLV tpes?
>>
>
> KT> Fixed.
>
> Thanks,
> Ketan
>
>
>>
>> Thanks.
>>
>>
>>
>>

[Gen-art] Genart last call review of draft-ietf-i… Vijay Gurbani via Datatracker
Re: [Gen-art] Genart last call review of draft-ie… Ketan Talaulikar
Re: [Gen-art] Genart last call review of draft-ie… Vijay Gurbani
Re: [Gen-art] Genart last call review of draft-ie… Ketan Talaulikar
Re: [Gen-art] Genart last call review of draft-ie… Vijay Gurbani
Re: [Gen-art] [Last-Call] Genart last call review… Lars Eggert