IETF Logo Mail Archive

Re: [Gen-art] [Last-Call] Genart last call review of draft-ietf-idr-bgp-ls-flex-algo-09

Lars Eggert <lars@eggert.org> Tue, 23 August 2022 13:56 UTC

Return-Path: <lars@eggert.org>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 663F5C152702; Tue, 23 Aug 2022 06:56:47 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.106
X-Spam-Level:
X-Spam-Status: No, score=-2.106 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=eggert.org
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id v-hD6y6e4WxK; Tue, 23 Aug 2022 06:56:42 -0700 (PDT)
Received: from mail.eggert.org (mail.eggert.org [91.190.195.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 31DDEC14F724; Tue, 23 Aug 2022 06:56:42 -0700 (PDT)
Received: from smtpclient.apple (unknown [217.149.135.167]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.eggert.org (Postfix) with ESMTPSA id EAE4F273FC8; Tue, 23 Aug 2022 16:56:32 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eggert.org; s=dkim; t=1661262993; bh=kqS/HJCvu3wgI0T/vyr3wTsIRhIvo2PcHvuPvSST3jM=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=JV+ik6egtWMK0x955WVt7w5VaCPSJxLBFxBZTgPLoq1el5GZXzxgYVww7SeiixQWW NsNrawNkdWFJpza/F/dSNcZ3i8QhxLwOQvIGgESefJPhxOXH6DCkWhj0XSZD9zOgNP CUCLswK256YA3+F8JD0UJqAiIDdAQy8i40yi33H8=
Content-Type: multipart/signed; boundary="Apple-Mail=_C28C1FBB-1EB5-48E7-92B3-657FA3B26826"; protocol="application/pgp-signature"; micalg="pgp-sha512"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\))
From: Lars Eggert <lars@eggert.org>
In-Reply-To: <166033385333.7724.14555622442470360665@ietfa.amsl.com>
Date: Tue, 23 Aug 2022 15:56:26 +0200
Cc: General Area Review Team <gen-art@ietf.org>, draft-ietf-idr-bgp-ls-flex-algo.all@ietf.org, idr@ietf.org, last-call@ietf.org
Message-Id: <BF4FC266-6B65-4690-88CC-08B82EEC4C30@eggert.org>
References: <166033385333.7724.14555622442470360665@ietfa.amsl.com>
To: Vijay Gurbani <vijay.gurbani@gmail.com>
X-MailScanner-ID: EAE4F273FC8.A6B0B
X-MailScanner: Not scanned: please contact your Internet E-Mail Service Provider for details
X-MailScanner-From: lars@eggert.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/Pob_v_0i_Iu-n1mEaeXh3SktYZw>
Subject: Re: [Gen-art] [Last-Call] Genart last call review of draft-ietf-idr-bgp-ls-flex-algo-09
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Aug 2022 13:56:47 -0000

Vijay, thank you for your review. I have entered a No Objection ballot for this document.

Lars


> On 2022-8-12, at 21:50, Vijay Gurbani via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Vijay Gurbani
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-idr-bgp-ls-flex-algo-??
> Reviewer: Vijay K. Gurbani
> Review Date: 2022-08-12
> IETF LC End Date: 2022-08-17
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary: Draft is ready with nits for a Proposed Standard.
> 
> Major issues: 0
> 
> Minor issues: 1 (please see below)
> 
> Nits/editorial comments: 4 (please see below)
> 
> Minor:
> - Sec. 3.6: Note that Type is "TBD" here.  Should this be 1046, as shown in
> Table 1?  (Or is the use of 1046 still under discussion?)
> 
> Nits:
> - I note that certain acronyms --- IGP, NLRI, ASLA --- are not defined.  I
> suspect that these are well-known in the community, hence need no definition.
> Just in case they are not, you may consider expanding the rare ones on first
> use. - Sec. 1: s/Flexible algorithm is called so as/Flexible algorithm is so
> called because/ - Sec. 2: s/Definition(s) (FAD) advertised by a node
> is/Definition(s) (FAD) advertised by a node is (are)/
>  Reason: symmetry in the sentence construction
> - Sec. 3.6: Is Figure 7 missing the trailing "//" for sub-TLV tpes?
> 
> Thanks.
> 
> 
> 
> --
> last-call mailing list
> last-call@ietf.org
> https://www.ietf.org/mailman/listinfo/last-call

v2.23.0 | Report a Bug | By Email