IETF Logo Mail Archive

[Gen-art] Gen-ART Last Call review of draft-ietf-lamps-rfc5019bis-05

Paul Kyzivat <pkyzivat@alum.mit.edu> Sat, 23 March 2024 20:27 UTC

Return-Path: <pkyzivat@alum.mit.edu>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EC34AC14F610; Sat, 23 Mar 2024 13:27:20 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.008
X-Spam-Level:
X-Spam-Status: No, score=-7.008 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=alum.mit.edu
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XBTuYOOQ-c9K; Sat, 23 Mar 2024 13:27:16 -0700 (PDT)
Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2132.outbound.protection.outlook.com [40.107.93.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4DF60C14F616; Sat, 23 Mar 2024 13:27:12 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OF322m4mjmfdA2KI9lR1Vc9SP39Km4Avor/IY5uwkAnMU4t474nROIzDfxOEoUkbbewCK27N7GUo0l+a3UQ6WLp/YCg4BEz9QnKxTraTX8lMNIB112tsK6a2vROKDcPKAPy2EXmH9S0+PXPZAif83t/4G2srdYulFB94hZtP9QZgBn7lkfCydZKZ9Xs3wE5zyqQgPlL5sceWe8hYN10VtrN2mGHJwqQI7dy3pgtdLrJNt30J7UfB8g0aAcrwJiUjIRPZQh2i5JiPmhlChmGPEbzAk4is3xrxrzTKf96xyxrJVglxjXAeBxCmAT1aIBtwYqn27SglDBFgQmxt6xsruw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TZ82Da8glhnOjBTLaxUBOcM5TzMZvtl+mbRlFGZdpP4=; b=QjBWZ6YS+TWD68bMQX3wimf2GoPA84+KNsHJNBBDJHqbcKipFzQ+3VPhmZ9OMXeLJo8y222LP6bqX6+5gVe+x0c5fDpz6YrKUd1JaXK2OPzLZam+fgbqJoMmsxZ7dU7eyzv6UqDWE1XrZPFUPPQt09hQahLsrFA1js06wD/+paf0r+xE0vfO66loB1zup/4CtZ1pV3kV80/YKjCR4neoq1HMKNxwALWl5iyViQ46VEastVR/omRGDf2RVT0tTodJVAVWiQu042lrkcfXsPKIyzMrOMhDGdtStROALQZajw8MIRcrGLbp8Z1EQJoxBrOjd6Jo8Kn3rJs4hjl9BpkLrA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 18.7.68.33) smtp.rcpttodomain=ietf.org smtp.mailfrom=alum.mit.edu; dmarc=pass (p=none sp=none pct=100) action=none header.from=alum.mit.edu; dkim=none (message not signed); arc=none (0)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alum.mit.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TZ82Da8glhnOjBTLaxUBOcM5TzMZvtl+mbRlFGZdpP4=; b=ZzIF7MughD0xYFmVSvSxLKeJq1/mgsJiPbMWdFWlmk9NdSmWvrLvLHDUTHvuhotfXU2CfUatDYEQdo2yKEQSrRVFP/k/6Qzg46NidcgcPN0MsYEThxJxTJJxQhD3eczzKtwCE7sRQxbTbajAcHVlRuAmmlut/gjVqJtB6+K3MPA=
Received: from MN2PR06CA0010.namprd06.prod.outlook.com (2603:10b6:208:23d::15) by DS7PR12MB6144.namprd12.prod.outlook.com (2603:10b6:8:98::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.24; Sat, 23 Mar 2024 20:27:10 +0000
Received: from BL02EPF0001A106.namprd05.prod.outlook.com (2603:10b6:208:23d:cafe::b0) by MN2PR06CA0010.outlook.office365.com (2603:10b6:208:23d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.28 via Frontend Transport; Sat, 23 Mar 2024 20:27:10 +0000
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 18.7.68.33) smtp.mailfrom=alum.mit.edu; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=alum.mit.edu;
Received-SPF: Pass (protection.outlook.com: domain of alum.mit.edu designates 18.7.68.33 as permitted sender) receiver=protection.outlook.com; client-ip=18.7.68.33; helo=outgoing-alum.mit.edu; pr=C
Received: from outgoing-alum.mit.edu (18.7.68.33) by BL02EPF0001A106.mail.protection.outlook.com (10.167.241.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.10 via Frontend Transport; Sat, 23 Mar 2024 20:27:10 +0000
Received: from [192.168.1.52] (c-73-143-251-114.hsd1.ma.comcast.net [73.143.251.114]) (authenticated bits=0) (User authenticated as pkyzivat@ALUM.MIT.EDU) by outgoing-alum.mit.edu (8.14.7/8.12.4) with ESMTP id 42NKR8HR011720 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NOT); Sat, 23 Mar 2024 16:27:09 -0400
Message-ID: <3a839b14-2080-4599-95d2-4ad727b1f399@alum.mit.edu>
Date: Sat, 23 Mar 2024 16:27:08 -0400
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: Paul Kyzivat <pkyzivat@alum.mit.edu>
To: draft-ietf-lamps-rfc5019bis.all@ietf.org
Cc: General Area Review Team <gen-art@ietf.org>, last-call@ietf.org, LAMPS <spasm@ietf.org>
Content-Language: en-US
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BL02EPF0001A106:EE_|DS7PR12MB6144:EE_
X-MS-Office365-Filtering-Correlation-Id: 4e11d575-47d4-4cd6-3162-08dc4b779e18
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: foPmJ6NddwiJQQ86sDT9HuC4m2ZdJ8Cd0kEuqtRZmEJqZmA/mmhtT9BBjZku9THuiPGAn6uJKba1gxh64qcYDPhbOew9zJR5NJx8QsVyehUv/gw5nj0ClJ/jR7CdWTuH5LTcRFXYdoAZSQxvvhF1nBWSh5EJemVez9QbsD0j2GWQH8xxTV2R9hWoj43jWOMmGbUvY9Cjc8VV+yOGZZXV72Ik/n/Cmghf4rY/t0VK0jryvPYcGi3AVa2D+JrlCyme8uNkBsCPpGDLs3ElC9T+9gNQmxnb/o14zSgyEeNhzfGT3pu33aI1+zlLoe4qGSCHgyVjFXjvLtqA552SQ1Kau+cmAuMiRvdS4qsFIy46AvYCy9eJS6PQulgeR3f0Q1jwxDEFHzqnuQYnsDhLXmizTjYUDpFz0GoxFLDsFrj8aJ9vuJOwRRWPOk8QCq5ckGKsWkaViNRNruIvxzmzcwQQteWdzV2lu3BK1B//8XzgqI5rPOnghAg/o2ASO5xLsXAS7R/UCbAVO7XXi0kvvo9tIycCa/B93ZtluISDYaNLMXuicRScu4RIL80C8bj299+tYi71rrMcRAojZGGPN51RvoKha2MK5/9WAxBxeWPVBxH7TedvZhRkge2UNKc5RgOPYTV3njEtyewBPjDSOI981tCMIN1J5KWORGCR3zOj2bOig7ARdjE2YOOR11w4QsImdDvAXYpgPsNng1uJ7Sxegw==
X-Forefront-Antispam-Report: CIP:18.7.68.33; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:outgoing-alum.mit.edu; PTR:outgoing-alum.mit.edu; CAT:NONE; SFS:(13230031)(1800799015)(376005)(41320700004)(36860700004)(82310400014); DIR:OUT; SFP:1102;
X-OriginatorOrg: alum.mit.edu
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2024 20:27:10.3938 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e11d575-47d4-4cd6-3162-08dc4b779e18
X-MS-Exchange-CrossTenant-Id: 3326b102-c043-408b-a990-b89e477d582f
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3326b102-c043-408b-a990-b89e477d582f; Ip=[18.7.68.33]; Helo=[outgoing-alum.mit.edu]
X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A106.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6144
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/HMFUhpdoxNYUD2rntlmS6lU3S4U>
Subject: [Gen-art] Gen-ART Last Call review of draft-ietf-lamps-rfc5019bis-05
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 23 Mar 2024 20:27:21 -0000

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-lamps-rfc5019bis-05
Reviewer: Paul Kyzivat
Review Date: 2024-03-23
IETF LC End Date: 2024-03-29
IESG Telechat date: ?

Summary:

This draft is on the right track but has open issues, described in the 
review.

ISSUES:

MINOR: 4

1) MINOR: Abstract:

The abstract from RFC 5019 has not been carried over to this bis. It has 
been replaced by an explanation for why RFC 5019 is being updated.  Once 
this is published this explanation text will cease to be relevant to a 
new reader. I suggest bringing back the abstract from RFC 5019. 
(Possibly with updates.) The explanation for why the bis was made can be 
moved to an appendix.

That appendix should also include the list of substantive changes now at 
the end of section 1.

2) MINOR: Duplications from RFC 6960

Sections 3.1.1 and 3.2.1 now includes ASN.1 definitions copied from RFC 
6960. I suggest that you at least make clear that these are copies and 
are not changed from RFC 6960. Or reconsider whether including them 
substantially improves the document.

3) MINOR: Security considerations

You should consider adding security considerations discussing the 
implications of the backward compatibility with RFC 5019. (E.g., 
continuing to support SHA-1.)

4) MINOR: Examples

Is there a reason why Appendix A containing examples has been removed?

v2.23.0 | Report a Bug | By Email