IETF Logo Mail Archive

Re: [Gen-art] Gen-ART Last Call review of draft-ietf-lamps-rfc5019bis-05

Corey Bonnell <Corey.Bonnell@digicert.com> Wed, 03 April 2024 12:46 UTC

Return-Path: <Corey.Bonnell@digicert.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 05175C17C8B6; Wed, 3 Apr 2024 05:46:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.176
X-Spam-Level:
X-Spam-Status: No, score=-2.176 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.08, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=digicert.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Lo27Ft8L6Irz; Wed, 3 Apr 2024 05:46:40 -0700 (PDT)
Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2128.outbound.protection.outlook.com [40.107.93.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 51DC4C17C884; Wed, 3 Apr 2024 05:46:40 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CxsPZnUuo0EAcpk6YWLOGBZVFDjkQoIBIVGSfI8imlwapVEOK7IViUDuvhczO6xqNgo9uAsoq0U/Es4GQWJmIvdayhmpWx6O0LepTiQU60cdtS6NkR4R+SrXsKprz9TixK0joKq4ZmCxQa7blst9N0QEizhdJKxcCiEN4UrWQ1BVgokrb4jCMedgsw3PIZ+z0g8psVRRj0RX8B86RvB5NcnyrE7t0KbsdxmVZV1C5CulyvmipDFou3g68bzXuAQGTJyiBuF8gmxZSD0DkDGKB6DTg02vBH5kKeASkLJ44KmXm1G6EZTZIXbmZjUUPlrUNpit45Ctl3z89fN7p1g/gg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=puoDHORADR2GD/mvafu6fqKZ0let/a2He8KQ3tlfKp0=; b=Xpm1ct0+SAB2nq68fyk9po/EU1zW4IyanpUmeheQAkg4blt3SVXVn0O8dHphiCjF0cfuERcS079AkGq3v6Sv9POdutzfZCh7GG8ZvVVHn3/yeZIpFXfobgG5InS6cn1UhooKK9/ujxRZlQjPW226//ImAJ4KEcEXycirxMh5JB8b4sQBC78aHItx05nt64s+D2t73mWTyDJcXANuPhqNSSBWr/oH/YDiZneEQbW3KDlLMSnZjcFNl3ehWHoEp8kFNJZmTuIo6zDD0K+aZITEwvV0erzUAx7w+4DwIl7CNz4r4JrU78FKh7RBfRT+56SM9Vy/v7373ckCZq2BXUVUow==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=digicert.com; dmarc=pass action=none header.from=digicert.com; dkim=pass header.d=digicert.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=digicert.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=puoDHORADR2GD/mvafu6fqKZ0let/a2He8KQ3tlfKp0=; b=OsOmwvyfkliH41+97F4zxhRG1U+VqAfRFKkrD8uGxenGk3R0E/kygQqZT8nw3YT8mq82o41k4XxW+xWtKDs9BFRAGCE4CamA2SM8RwDg4Uzr3URGxkJt0Gx0V9FBpSnY+X1r1pSg2LDgKmVrejDwRG24kidh2UWLXz+gsxzUJz+B8PVbgfoWwupVq+hLlgPUJMMRCettrVq6JshsKaRM/ZqEJbJ9Q14EtJMFIS9g+6K850GACTa4ObNA1EA8Ksk/GMZu7Ty0PH33RBp7MPL5mZ796N1DGGYm9e9PZGkB9puz1i/rUnGhdI/a9hmAvMuDNKXPPn76ruNnaERB+wzvTw==
Received: from DM6PR14MB2186.namprd14.prod.outlook.com (2603:10b6:5:b6::16) by MN2PR14MB4141.namprd14.prod.outlook.com (2603:10b6:208:1d7::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Wed, 3 Apr 2024 12:45:48 +0000
Received: from DM6PR14MB2186.namprd14.prod.outlook.com ([fe80::1303:c37c:a6ed:4b2e]) by DM6PR14MB2186.namprd14.prod.outlook.com ([fe80::1303:c37c:a6ed:4b2e%5]) with mapi id 15.20.7409.042; Wed, 3 Apr 2024 12:45:48 +0000
From: Corey Bonnell <Corey.Bonnell@digicert.com>
To: Paul Kyzivat <pkyzivat@alum.mit.edu>, "draft-ietf-lamps-rfc5019bis.all@ietf.org" <draft-ietf-lamps-rfc5019bis.all@ietf.org>
CC: General Area Review Team <gen-art@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, LAMPS <spasm@ietf.org>
Thread-Topic: Gen-ART Last Call review of draft-ietf-lamps-rfc5019bis-05
Thread-Index: AQHafWCLXuGywuTz80WylnLJQAecibFWjhGg
Date: Wed, 03 Apr 2024 12:45:48 +0000
Message-ID: <DM6PR14MB2186C44C9A43E90F0FA7AF4B923D2@DM6PR14MB2186.namprd14.prod.outlook.com>
References: <3a839b14-2080-4599-95d2-4ad727b1f399@alum.mit.edu>
In-Reply-To: <3a839b14-2080-4599-95d2-4ad727b1f399@alum.mit.edu>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DM6PR14MB2186:EE_|MN2PR14MB4141:EE_
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: mQ1lmMwAqOuJJ2jgXKhxyycYRBjbb9joWP2syR6bcGjjnPUqPBIvMIYr6Mq1OKNmIO6vCqcZEHEXAuTVXrVwe+LW4JYuGkLOFTRoEbzkVFHFn2xPVtaca102QEdO+YfOL+7sscWMPy9RtmPOi9M8o3uIHR2VuC2ntR9zzrzA7j2a5JpObyXGoAxCTjcuqkHJdn/DovmE4U0N+Ml654vbYN2Nvhh2+9NL+djR+5YnSKPly2SuKtq20Epp9Zv81dZlPp76cale2VWH57nyZOm4yGyjEduFDsZsMn6x56s2ke2g7gL3BP2wlK0CIzHlU+P0QSLsDw7/KXO3DVdnus3x5kuPXvva2XAs/RkuhMkNFxQbW1HE9X2T6IuR63CIdFPjmWVGu8clQwTe+lHKXkR/fnG0b0Ndr7VsOemfuvlex3v5nUQD2tJ5L+HbMOureA6j3PMD39002je0pBloqMt9Kb8fSRJEVHsUU0jpnsUqu/uuv9bBoxFLUYZ7cCX0G1wt6C89b1FCMj7/5ZbrE9Iw0a9jfDgWo42utOkNXzq2/3FMjOARSsbpiz7aGjZSwO1NDsEnqo7M/Xc+4nHn1halSiBiBvjr35gWOaJbkXMaA2w=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR14MB2186.namprd14.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(366007); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: T08LKWA0XTlMTNBWREqNNxVHknVmg5D4UdTg9sZZK7EoIN6L5QhilgTbFuJ6SVZnBT2Af1lL77Ca1kYjk1yN65Mg5nrXb00R+kbImnt98D7xYELDSmIRqgAaIFI13ordq1ZIF8QuQNnPC4YJza8bUjU+cY/CyrNs2XEw79LddZjYUd9vCRMUKmnRCl2ic3WFbePM88XMm8//Ky8eTM0js3rF+0KWkImo+dZZSbbnRRmJCNWRsh9Bmgvyutce5kDhdIwfHUI7WFhQ3Ofv3cIzEHoe/MXrHh8BfFqOkVI2YtNNG1y2uXq6LAr8JoK6GNg62t50ygtN7ZDOzn2TYsjy5/vKk04wEPjuM5EhIgBOx7dy3qVpepwDSLKTvIpDOUxXuYNYbfYXQlL1yjm9XZPo0PNuapsk/upGNx1/gj/IsC7fWPrCocJFoDlx4x+re0jJMb1aUWv+4iddXJE71ySsjEV99SAJgzjrCCSk8KID+0+2t/6ScZi7sMxV5pCKZ4wRx5w08n4yEti1pi7yv1UWQd4tKzsnxLUS5vzjQEyOqxstp1FpPHy9uGdcI1t3jUB+388JEgvRrclRqepGmMJfaLj7wjS+kp3tE4Ph8zdwAfJS6Q+Ie3oJ/q/PGXr8WXZQrGc1Jk1PLZMUu3xXLoCotqJvHM8JjOXWzA3oWomnvQdRMohcoATNEgwPN/fQxE7hjkdLFV1OYNfMU7wXEdsHQDlUc3Vskp6+W+UBdqRe7RRuTUxDSHRIC2e5lcToEa0Sh9ettbTpqzwWBYHxMwznnhIwrl6ZPfCIs35MhfCKusQbX4/JagGpPXu3Bi3IvhGz4f630jkYoPtBPypC/oEsxSDMPgaXw2qrEy9dHLblCSPZM2M9Vgk0BmsOCbl5S8HhCaX035e8A9mVm99MUSjc5omv8LK7QZ9VlihxViqougkGXtKmFrLL+LqrS89hJfD50z56WvezBEBQmY8a+tdAhzFTgS+q6vtumZ37/rdhN2hi9pHdh5gB4xKUbzJ234v1zha8x2F0QBrLgnCgA8h/0AObnpuwCEvWiSjPhZRuDLJ+FeELsSOuvJYaBJAQBP6uiWJ23+0iQYq7BgTZVfSxqjrkKjcZgfy9fDzJB3CXyCbUV3oH5e9WH7k0u8Wrhh87PmLZGs66Yq01YZPY1V8On6XG2wN3u7I8WO9VaMAyngCOke23AJ/YI24dtw6ruTH+RlwZXcOw4dttDQHnmwZiGj0OBYJj3jirnXIHDJpUCjXhNSgxQOM/ngjml0NctO6b9bWk67V/dZfJum9m+hf3dGLdP0bvwkQTmlfazhRpvPyw4CQgAQsP3YCmI4S/JJYzvf0b4YmhbD+QSNnHEM1/ZfCZ7CDnccM+92GdzlrLFUTgDMQ4lQXoZF1XKVZ/7Embq52u/dSMYUkhgvhJRNT+Ld4ezjXv5uTkVj/Rpwf/O+Zs7wOIV1cluh0Xr/k1+seROvSHQMkjLN1oGZwXIpTwegXCiQndEL90bN025exjPdkyLKqobZf7wKeSdmsG1UxInWo2UJUzjC5SQS/56M2hwIl6lvSVM5ZrVtHL5nECHsp2ih4OS2JKjjMsBefs6zY1QGzEZFMjZeR5AkuvKmVNeA==
Content-Type: multipart/signed; protocol="application/x-pkcs7-signature"; micalg="SHA1"; boundary="----=_NextPart_000_0267_01DA85A3.2F29E850"
MIME-Version: 1.0
X-OriginatorOrg: digicert.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR14MB2186.namprd14.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a990844d-317b-4af2-007a-08dc53dbfca8
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Apr 2024 12:45:48.1297 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: cf813fa1-bde5-4e75-9479-f6aaa8b1f284
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /19WpbuEgaSFNiHRy0bH2pthBCULcDCpJNgQamZKLoq3KdzjQQU53RuW5yfLYLPCHjKDfokWHBfJ+YpndCASXhjb3tERlWmP1AlSYJAz+d4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR14MB4141
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/Yv7XFw9wLcBJDEvJumla2ZvPBD0>
Subject: Re: [Gen-art] Gen-ART Last Call review of draft-ietf-lamps-rfc5019bis-05
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Apr 2024 12:46:44 -0000

Hello Paul,
Thank you for your detailed review and insightful feedback. We have just 
uploaded -06 to the Datatracker: 
https://datatracker.ietf.org/doc/draft-ietf-lamps-rfc5019bis/.

We believe -06 addresses all the concerns that you raised. Please let us know 
if there are still unresolved items.

Thanks,
Corey

-----Original Message-----
From: Paul Kyzivat <pkyzivat@alum.mit.edu>
Sent: Saturday, March 23, 2024 4:27 PM
To: draft-ietf-lamps-rfc5019bis.all@ietf.org
Cc: General Area Review Team <gen-art@ietf.org>; last-call@ietf.org; LAMPS 
<spasm@ietf.org>
Subject: Gen-ART Last Call review of draft-ietf-lamps-rfc5019bis-05

I am the assigned Gen-ART reviewer for this draft. The General Area Review 
Team (Gen-ART) reviews all IETF documents being processed by the IESG for the 
IETF Chair.  Please treat these comments just like any other last call 
comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-lamps-rfc5019bis-05
Reviewer: Paul Kyzivat
Review Date: 2024-03-23
IETF LC End Date: 2024-03-29
IESG Telechat date: ?

Summary:

This draft is on the right track but has open issues, described in the review.

ISSUES:

MINOR: 4

1) MINOR: Abstract:

The abstract from RFC 5019 has not been carried over to this bis. It has been 
replaced by an explanation for why RFC 5019 is being updated.  Once this is 
published this explanation text will cease to be relevant to a new reader. I 
suggest bringing back the abstract from RFC 5019.
(Possibly with updates.) The explanation for why the bis was made can be moved 
to an appendix.

That appendix should also include the list of substantive changes now at the 
end of section 1.

2) MINOR: Duplications from RFC 6960

Sections 3.1.1 and 3.2.1 now includes ASN.1 definitions copied from RFC 6960. 
I suggest that you at least make clear that these are copies and are not 
changed from RFC 6960. Or reconsider whether including them substantially 
improves the document.

3) MINOR: Security considerations

You should consider adding security considerations discussing the implications 
of the backward compatibility with RFC 5019. (E.g., continuing to support 
SHA-1.)

4) MINOR: Examples

Is there a reason why Appendix A containing examples has been removed?

v2.23.0 | Report a Bug | By Email