IETF Logo Mail Archive

[Gen-art] Gen-ART review of draft-ietf-opsawg-hmac-sha-2-usm-snmp-05

Christer Holmberg <christer.holmberg@ericsson.com> Sat, 11 April 2015 13:07 UTC

Return-Path: <christer.holmberg@ericsson.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7E45D1B2AE6 for <gen-art@ietfa.amsl.com>; Sat, 11 Apr 2015 06:07:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.2
X-Spam-Level:
X-Spam-Status: No, score=-4.2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ACFOHxb1bkN3 for <gen-art@ietfa.amsl.com>; Sat, 11 Apr 2015 06:07:48 -0700 (PDT)
Received: from sessmg23.ericsson.net (sessmg23.ericsson.net [193.180.251.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 02F631B2ACF for <gen-art@ietf.org>; Sat, 11 Apr 2015 06:07:47 -0700 (PDT)
X-AuditID: c1b4fb2d-f79a46d0000006b4-de-55291ca1ce9a
Received: from ESESSHC009.ericsson.se (Unknown_Domain [153.88.253.124]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id 62.E9.01716.1AC19255; Sat, 11 Apr 2015 15:07:46 +0200 (CEST)
Received: from ESESSMB209.ericsson.se ([169.254.9.236]) by ESESSHC009.ericsson.se ([153.88.183.45]) with mapi id 14.03.0210.002; Sat, 11 Apr 2015 15:07:45 +0200
From: Christer Holmberg <christer.holmberg@ericsson.com>
To: "gen-art@ietf.org" <gen-art@ietf.org>
Thread-Topic: Gen-ART review of draft-ietf-opsawg-hmac-sha-2-usm-snmp-05
Thread-Index: AdB0YG7imXzOINi3SuGZx0oB0oX6KA==
Date: Sat, 11 Apr 2015 13:07:44 +0000
Message-ID: <7594FB04B1934943A5C02806D1A2204B1D793917@ESESSMB209.ericsson.se>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [153.88.183.150]
Content-Type: multipart/alternative; boundary="_000_7594FB04B1934943A5C02806D1A2204B1D793917ESESSMB209erics_"
MIME-Version: 1.0
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDLMWRmVeSWpSXmKPExsUyM+Jvje4iGc1QgzVr+S2+r+tntbj66jOL A5PHkiU/mTy+XP7MFsAUxWWTkpqTWZZapG+XwJVxZUcfa8Ef64qujU/YGhibTLsYOTkkBEwk Vr+/wAZhi0lcuLceyObiEBI4yijR+PQaC4SzhFFi8aF37F2MHBxsAhYS3f+0QRpEBDQl5q54 ywRiMwtUS8zesokdxBYWcJaY/nEfK0SNh8S3gxNZIGw9ia/3joHFWQRUJRbOvcoEMpJXwFei d5EUSJgR6Ibvp9ZAjRSXuPVkPhPEbQISS/acZ4awRSVePv7HCmErSazYfokRoj5fYueqHrAa XgFBiZMzn7BMYBSehWTULCRls5CUQcR1JBbs/sQGYWtLLFv4mhnGPnPgMROy+AJG9lWMosWp xcW56UbGeqlFmcnFxfl5enmpJZsYgdFzcMtv3R2Mq187HmIU4GBU4uFVaNAIFWJNLCuuzD3E KM3BoiTOa2d8KERIID2xJDU7NbUgtSi+qDQntfgQIxMHp1QDY+6z2awv5STLt6w8n1q+TO/1 i1uuN1tWptw8HM0w+5GXZqdK1KUjtwQMJi/7ef7bE3sRR/4M551h5rOsjvP//iX5zexuoOM9 V+OTdRcl1b3fTHrA9ybfLpj/rlWgnt07/2l5f7lTu1ofXC6RffU81+Mqp8WOaH4LrRtbGqp1 fK6uM4+Um8VVrMRSnJFoqMVcVJwIAD33Z+h/AgAA
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/hYjpsGi_RRCISm1Y7dUYTFuSeXQ>
Cc: "draft-ietf-opsawg-hmac-sha-2-usm-snmp.all@tools.ietf.org" <draft-ietf-opsawg-hmac-sha-2-usm-snmp.all@tools.ietf.org>
Subject: [Gen-art] Gen-ART review of draft-ietf-opsawg-hmac-sha-2-usm-snmp-05
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 11 Apr 2015 13:07:50 -0000

I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>

Document:                         draft-ietf-opsawg-hmac-sha-2-usm-snmp-05

Reviewer:                           Christer Holmberg

Review Date:                     11 April 2015

IETF LC End Date:             20 April 2015

IETF Telechat Date:         N/A

Summary:        The document is well written, and almost ready for publication. I do, however, have a couple of comments (see below).

Major Issues: None

Minor Issues:

Q1_10-1: In the IANA Considerations section, IANA is requested to register new values. However, it is not mentioned in which registry the new values will be registered.



Editorial nits:

Q1_GENERAL-1:              Regarding reference, sometimes you say "RFC XXXX [RFCXXXX]", sometimes "RFC XXXX" and sometimes "[RFCXXXX]".

I think you should be consistent, and e.g. use "RFC XXXX [RFCXXXX]" on first occurrence, and then "RFC XXXX".

In some cases "[RFCXXXX]" is ok, though, e.g. in section 9.4 where you say "SNMP-USER-BASED-SM-MIB [RFC3414].".

v2.23.0 | Report a Bug | By Email