Re: [hybi] With deflate-stream, Close frame doesn't work as an end of data marker

Andy Green <andy@warmcat.com> Wed, 09 March 2011 10:57 UTC

Return-Path: <andy.warmcat.com@googlemail.com>
X-Original-To: hybi@core3.amsl.com
Delivered-To: hybi@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 816873A6919 for <hybi@core3.amsl.com>; Wed, 9 Mar 2011 02:57:38 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.581
X-Spam-Level:
X-Spam-Status: No, score=-3.581 tagged_above=-999 required=5 tests=[AWL=0.018, BAYES_00=-2.599, RCVD_IN_DNSWL_LOW=-1]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z4nGQ0tDYhfa for <hybi@core3.amsl.com>; Wed, 9 Mar 2011 02:57:37 -0800 (PST)
Received: from mail-wy0-f172.google.com (mail-wy0-f172.google.com [74.125.82.172]) by core3.amsl.com (Postfix) with ESMTP id 2B5D13A68FE for <hybi@ietf.org>; Wed, 9 Mar 2011 02:57:37 -0800 (PST)
Received: by wyb42 with SMTP id 42so365600wyb.31 for <hybi@ietf.org>; Wed, 09 Mar 2011 02:58:52 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:sender:message-id:date:from:user-agent :mime-version:to:cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=SEhgc5p8iKmaP687hke5mAuNJPDSoIlpaedRfewQHMw=; b=TQ4otg+RR+qKoHK4R5bzNB+YcRWyOawnFMwi3RmVLpgF9QssMc8iTPM9H6IYkSizVc 2FI5EbGt1wsoPZuHuUV8fBJfgNHL3ibw83hY5IEDIFb0LDBh4K9dLomeuCi7ux8ahF4D yuIH6J/p10ETDuHb1D4MpXHxIvx6otDGrDCkM=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=IMBxZVctzlZJuI2xsbwvlZ9uWAGOs6hMdYrauybusQoEWmIl0+tkStDS9fTFJnD536 T3Z71S/9+eg+H/iGKK7e3r7neJuVO4J/10YOP+jDXXHnRYE65L9Eiwi8LWWC8ESVk6BJ yKX+IY9bS0Fy/0vfPUPLiprgOgnzH2C0QeRqI=
Received: by 10.227.7.18 with SMTP id b18mr2059180wbb.103.1299668332620; Wed, 09 Mar 2011 02:58:52 -0800 (PST)
Received: from otae.warmcat.com (s15404224.onlinehome-server.info [87.106.134.80]) by mx.google.com with ESMTPS id bd8sm1365967wbb.19.2011.03.09.02.58.50 (version=SSLv3 cipher=OTHER); Wed, 09 Mar 2011 02:58:51 -0800 (PST)
Sender: Andy Green <andy.warmcat.com@googlemail.com>
Message-ID: <4D775D69.8010808@warmcat.com>
Date: Wed, 09 Mar 2011 10:58:49 +0000
From: Andy Green <andy@warmcat.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.14) Gecko/20110302 Fedora/3.1.8-3.fc16 Thunderbird/3.1.8
MIME-Version: 1.0
To: Yutaka_Takeda@PlayStation.Sony.Com
References: <OF27A0495D.2C32912B-ON8825784E.00342DCE-8825784E.00367A85@playstation.sony.com>
In-Reply-To: <OF27A0495D.2C32912B-ON8825784E.00342DCE-8825784E.00367A85@playstation.sony.com>
Content-Type: text/plain; charset="ISO-8859-1"; format="flowed"
Content-Transfer-Encoding: 7bit
Cc: hybi@ietf.org
Subject: Re: [hybi] With deflate-stream, Close frame doesn't work as an end of data marker
X-BeenThere: hybi@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: Server-Initiated HTTP <hybi.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/hybi>, <mailto:hybi-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/hybi>
List-Post: <mailto:hybi@ietf.org>
List-Help: <mailto:hybi-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/hybi>, <mailto:hybi-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Mar 2011 10:57:38 -0000

On 03/09/2011 09:55 AM, Somebody in the thread at some point said:
>
> This thread, too, I am wondering if this has reached a consensus at this
> point. At least,
> Greg, Brian and myself agreed to have only payload deflated. This aligns
> with the

I'd be a bit happier with payload-only compression but I don't really 
mind.  It's a little bit less deadly than masking-outside-framing 
because you can at least turn off negotiation of compression inside the 
standard OK if you want to debug it.

> reasons for choosing masking in frames, too. Also, it resolves the
> original issue Takeshi
> pointed out with regards to presence of trailing bytes after Close frame
> as in the subject
> which would cause RST in normal termination.

Having implemented this now, I don't see the problem using 
Z_PARTIAL_FLUSH as the standard seems to recommend normally, and then 
Z_FULL_FLUSH when sending the close packet, and disabling any further 
packet issue on that connection.  So I don't think Takeshi's issue is 
more than an implementation problem, I'd welcome being educated if I 
missed any point.

-Andy