AD review of draft-ietf-l2vpn-evpn
"Adrian Farrel" <adrian@olddog.co.uk> Fri, 18 July 2014 22:56 UTC
Return-Path: <adrian@olddog.co.uk>
X-Original-To: l2vpn@ietfa.amsl.com
Delivered-To: l2vpn@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CAFA91A02BA for <l2vpn@ietfa.amsl.com>; Fri, 18 Jul 2014 15:56:10 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -101.9
X-Spam-Level:
X-Spam-Status: No, score=-101.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, USER_IN_WHITELIST=-100] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4-DWdDPsOGwS for <l2vpn@ietfa.amsl.com>; Fri, 18 Jul 2014 15:56:09 -0700 (PDT)
Received: from asmtp2.iomartmail.com (asmtp2.iomartmail.com [62.128.201.249]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D0C3A1A02A3 for <l2vpn@ietf.org>; Fri, 18 Jul 2014 15:56:08 -0700 (PDT)
Received: from asmtp2.iomartmail.com (localhost.localdomain [127.0.0.1]) by asmtp2.iomartmail.com (8.13.8/8.13.8) with ESMTP id s6IMu6um004136; Fri, 18 Jul 2014 23:56:06 +0100
Received: from 950129200 ([207.164.135.98]) (authenticated bits=0) by asmtp2.iomartmail.com (8.13.8/8.13.8) with ESMTP id s6IMtxpD003924 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Fri, 18 Jul 2014 23:56:06 +0100
From: Adrian Farrel <adrian@olddog.co.uk>
To: draft-ietf-l2vpn-evpn.all@tools.ietf.org
Subject: AD review of draft-ietf-l2vpn-evpn
Date: Fri, 18 Jul 2014 23:56:03 +0100
Message-ID: <009e01cfa2db$7780eff0$6682cfd0$@olddog.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 14.0
Thread-Index: Ac+ir2WMxkqx3iLaSfGOKuQ7m4RsKQ==
Content-Language: en-gb
X-TM-AS-MML: disable
X-TM-AS-Product-Ver: IMSS-7.1.0.1576-7.5.0.1017-20826.003
X-TM-AS-Result: No--16.307-10.0-31-10
X-imss-scan-details: No--16.307-10.0-31-10
X-TMASE-MatchedRID: l1YHZ9wuMadpZtsObgt0hpYsKSXWWrsHh8Ytn75ClDNX14Hy+eYp7zA+ aK41wNmIeSj+2iiKL69in1AHkLLLaSrZfioCQkPDvHKClHGjjr1+K68qL2G5pqj5v7I4/SgYZIk dnj/FOdkI0u4+15EMd/fCCUHLoHisEOYcSTjO4UPCz1ymGcrCUZZ6zKu0q4rtNThbTtxnQeU/sJ JrvRfE1Ge7Lr9eorDKM0aI78CIKxHdMP7ZKPp/LLMjW/sniEQKBGvINcfHqhfWgknYNbwPiTkkb OLawrXwG6VYvgDfqU+MH+sT1Wp69FY4PvDw2KhjjWe5HOFKvuMax3hQAS8V1aFSh25xC7TpNSLa tMg7EYY855MYQ/c4FgqZQ38oK2SsbTSwI/A2DvBzaTZqCdc3fMC5Zx1NKJANhc+Jw4LMtcAGk2p TPAu+94qr+KqgrK5GUieol3FZWQyxuuum/MWy7+v8QGaI25e3rrEvQogcy/G/7bplhbPCQmja/2 LEydj591/dJ1kwzMsuAovee89QpIthqq74C5FqigXGsEoS1r4uLZ3AqIxH3Jsoi2XrUn/JyeMtM D9QOgDGlDvsLUDW2o6HM5rqDwqtlExlQIQeRG0=
Archived-At: http://mailarchive.ietf.org/arch/msg/l2vpn/feVNPWDnSCO_DbgGxhfdmbi4M8E
Cc: l2vpn@ietf.org
X-BeenThere: l2vpn@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
Reply-To: adrian@olddog.co.uk
List-Id: Layer 2 Virtual Private Networks <l2vpn.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/l2vpn>, <mailto:l2vpn-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/l2vpn/>
List-Post: <mailto:l2vpn@ietf.org>
List-Help: <mailto:l2vpn-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/l2vpn>, <mailto:l2vpn-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Jul 2014 22:56:11 -0000
Goodness, but there's a long and complicated document. But I think you have made it as clear and concise as it could possibly have been. Good job! I have done my AD review and found no substantive issues. I do, however, have a little pile of nits. Actually, quite a large heap. Nothing to worry about, but if you could clean them up i think it would improve the document still further. The only topics that need real attention are those related to IANA. Let me know how you get on, and please object if my comments are wrong. Thanks, Adrian === It would be best to move the Introduction to be the first section in the document. --- Section 5 Ethernet segments have an identifier, called the "Ethernet Segment Identifier" (ESI) which is encoded as a ten octets integer. It would help if you said "...in line format with the most significant octet sent first." --- Section 5 In general, an Ethernet segment MUST have a non-reserved ESI that is unique network wide "In general" is not really consistent with "MUST" --- Do you want an IANA registry to track the values of the Type field of the ESI? --- There is some mixing of "octet" and "byte" in the document. This creates the impression that you mean something different by the two words. --- Could you expand DF on first use. You have it in 8.3. --- Section 6 You use "Ethernet Tag ID", "Ethernet Tag", and "Ethernet Tag Identifier" interchangeably. It would be helpful to use just one term and to check usage in the rest of the document. --- Section 6.1 In such scenarios, the Ethernet frames transported over MPLS/IP network SHOULD remain tagged with the originating VID and a VID translation MUST be supported in the data path and MUST be performed on the disposition PE. I think you should add under what circumstances the frames MAY be re- tagged with a different VID (or s/SHOULD/MUST). You don't need a detailed explanation, but a guide to the implementer/operator. --- Do you want IANA to create a registry and track the Route Types defined for the EVPN NLRI in Section 7? --- Section 7.1 and onwards... I know "RD" is a term of art in the context of BGP, but could you please expand RD it on first use rather than leaving that to 8.2.1. (All the forward references to later sections are good, thanks.) --- A small inconsistency between sections 7 and 8. In the figures in Section 7 you have "MPLS Label" and "MPLS Label1" etc. In the text in Section 8 you have "MPLS label" etc. When you refer to the fields you need to match the case. When you refer to the concept of an MPLS label, you can (of course) use normal case. --- Are you sure that the ESI Label extended community and subtypes don't need IANA intervention here? --- It would be nice if 7.5 included a hint as to what an "ESI label" is. --- In 7.10 If a PE uses RT-Constrain, the PE SHOULD advertise all such RTs using RT Constraints. Is this a general restatement of RFC 4684 (if so add "As described in [RFC4684]...") or new guidance for implementers of this spec (if so, what is the reason for SHOULD? is there a MAY to counter it?) --- 8.1.1 The Ethernet Segment Identifier MUST be set to the ten octet ESI identifier described in section 5. Would that be the ESII? :-) --- 8.2.1 has "MANDATORY" I guess you are inventing a 2119 term to counter- point "OPTIONAL". Please use "REQUIRED." --- In Section 13.1 In certain environments the source MAC address MAY be used to authenticate the CE and determine that traffic from the host can be allowed into the network. Want to hint which environments they would be. Possibly more important, want to say in which environments this would be a damn fool idea? --- 14.1.2 The MPLS label stack to send the packets to PE1 is the MPLS LSP stack to get to PE1 and the EVPN label advertised by PE1 for CE1's MAC. and The MPLS label stack to send packets to PE2 is the MPLS LSP stack to get to PE2 and the MPLS label in the Ethernet A-D route advertised by PE2 for <ES1, VLAN1>, if PE2 has not advertised MAC1 in BGP. It *should* be perfectly obvious to the implementer, but perhaps you should say what order the labels appear on the stack since "and" is non- specific. --- Section 18 I wish you would add a reference to 4385 and use that control word with the various fields set to zero. This would keep us from increasing the number of different control word definitions in the wild. I think that the impact on your spec would be zero. --- Section 21 should be renamed "Contributors" --- I think RFC 2119 is a normative reference.
- AD review of draft-ietf-l2vpn-evpn Adrian Farrel
- Re: AD review of draft-ietf-l2vpn-evpn Ali Sajassi (sajassi)
- Re: AD review of draft-ietf-l2vpn-evpn Rabadan, Jorge (Jorge)
- Re: AD review of draft-ietf-l2vpn-evpn Ali Sajassi (sajassi)
- Re: AD review of draft-ietf-l2vpn-evpn Rabadan, Jorge (Jorge)
- Re: AD review of draft-ietf-l2vpn-evpn Ali Sajassi (sajassi)