Re: AD review of draft-ietf-l2vpn-evpn
"Ali Sajassi (sajassi)" <sajassi@cisco.com> Mon, 08 September 2014 17:53 UTC
Return-Path: <sajassi@cisco.com>
X-Original-To: l2vpn@ietfa.amsl.com
Delivered-To: l2vpn@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BFF241A010C for <l2vpn@ietfa.amsl.com>; Mon, 8 Sep 2014 10:53:29 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -16.153
X-Spam-Level:
X-Spam-Status: No, score=-16.153 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, RP_MATCHES_RCVD=-1.652, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VoLu9xdz9BWR for <l2vpn@ietfa.amsl.com>; Mon, 8 Sep 2014 10:53:27 -0700 (PDT)
Received: from rcdn-iport-8.cisco.com (rcdn-iport-8.cisco.com [173.37.86.79]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 23AC41A0105 for <l2vpn@ietf.org>; Mon, 8 Sep 2014 10:53:27 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=8052; q=dns/txt; s=iport; t=1410198807; x=1411408407; h=from:to:cc:subject:date:message-id:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=pfoYBboBrSCfx7tfePUgg02msgGOpDQA8J00OeCLvnA=; b=AmtdrgyNvMwBWMuFCZihzC5hymh9NmIeyc3DSTNQp+I4hhgCTV+SP+J1 P47k+65GPFrZXn6lDUNGgkPd+1s3qqc7xbuS7Ibn0vcLtQ8wwQ8ZCaf4N nbrN71pYP1vllaeVyPWJTbc/Xs0fPEIUZtD1fj7zjGu38x1GZ95kat0UQ 4=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AiMFAPDrDVStJV2R/2dsb2JhbABZgmojgSoE0T0BgRYWeIQDAQEBBHkMBgEIEQMBAgFgHQgBAQQBDQUUiC4BvA4BF4oAhRoIKwcGhEYBBIRYhiGGR4ZsgXWCUZUsg2FsAYFHgQcBAQE
X-IronPort-AV: E=Sophos;i="5.04,487,1406592000"; d="scan'208";a="353529721"
Received: from rcdn-core-9.cisco.com ([173.37.93.145]) by rcdn-iport-8.cisco.com with ESMTP; 08 Sep 2014 17:53:26 +0000
Received: from xhc-rcd-x02.cisco.com (xhc-rcd-x02.cisco.com [173.37.183.76]) by rcdn-core-9.cisco.com (8.14.5/8.14.5) with ESMTP id s88HrPZw027860 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Mon, 8 Sep 2014 17:53:26 GMT
Received: from xmb-aln-x13.cisco.com ([fe80::5404:b599:9f57:834b]) by xhc-rcd-x02.cisco.com ([173.37.183.76]) with mapi id 14.03.0195.001; Mon, 8 Sep 2014 12:53:25 -0500
From: "Ali Sajassi (sajassi)" <sajassi@cisco.com>
To: "Rabadan, Jorge (Jorge)" <jorge.rabadan@alcatel-lucent.com>, "adrian@olddog.co.uk" <adrian@olddog.co.uk>, "draft-ietf-l2vpn-evpn.all@tools.ietf.org" <draft-ietf-l2vpn-evpn.all@tools.ietf.org>
Subject: Re: AD review of draft-ietf-l2vpn-evpn
Thread-Topic: AD review of draft-ietf-l2vpn-evpn
Thread-Index: Ac+ir2WMxkqx3iLaSfGOKuQ7m4RsKQBst7wAAmeU34AHXxsTAA==
Date: Mon, 08 Sep 2014 17:53:24 +0000
Message-ID: <D03339CE.E84A1%sajassi@cisco.com>
In-Reply-To: <D0015E81.4AAAF%jorge.rabadan@alcatel-lucent.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/14.3.8.130913
x-originating-ip: [10.128.2.157]
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <28411A041B0EC04E98FBA9A0FEC9C6B8@emea.cisco.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: http://mailarchive.ietf.org/arch/msg/l2vpn/ilM32FTstTqgmGDdt7dL2rHVyBE
Cc: "l2vpn@ietf.org" <l2vpn@ietf.org>
X-BeenThere: l2vpn@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Layer 2 Virtual Private Networks <l2vpn.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/l2vpn>, <mailto:l2vpn-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/l2vpn/>
List-Post: <mailto:l2vpn@ietf.org>
List-Help: <mailto:l2vpn-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/l2vpn>, <mailto:l2vpn-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Sep 2014 17:53:29 -0000
Hi Jorge, Since we are using ³SHOULD² in the next section (8.3), I will change the sentence to the following to make it consistent: "If Single-Active redundancy mode is desired, then the "Single-Active² bit in the flags of the ESI Label Extended Community MUST be set to 1 and the ESI label SHOULD be set to a valid MPLS label value.² Cheers, Ali On 8/2/14, 2:49 AM, "Rabadan, Jorge (Jorge)" <jorge.rabadan@alcatel-lucent.com> wrote: >Ali, > >I just realized something: > >Page 19: >"If Single-Active redundancy mode is desired, then the "Single-Active² bit >in the flags of the ESI Label Extended Community MUST be set to 1 and the >ESI label MUST be set to zero." > >later in the same page: >³...The ESI label SHOULD be distributed by all PEs when operating in >Single-Active redundancy mode using a set of Ethernet A-D per ES route." > > >If the single-active PEs SHOULD distribute the ESI label, the ³ESI label >MUST be set to zero² statement sounds wrong. Can you please change it to >³MAY² if you agree? > >Thank you. >Jorge > > >-----Original Message----- >From: "Ali Sajassi (sajassi)" <sajassi@cisco.com> >Date: Sunday, July 20, 2014 at 9:55 PM >To: "adrian@olddog.co.uk" <adrian@olddog.co.uk>, >"draft-ietf-l2vpn-evpn.all@tools.ietf.org" ><draft-ietf-l2vpn-evpn.all@tools.ietf.org> >Cc: "l2vpn@ietf.org" <l2vpn@ietf.org>, "Ali Sajassi (sajassi)" ><sajassi@cisco.com> >Subject: Re: AD review of draft-ietf-l2vpn-evpn > >>Adrian, >> >>Thanks very much for your review. I will incorporate your comments into >>the next rev. For more details, please refer inline ... >> >>Regards, >>Ali >> >>On 7/18/14 3:56 PM, "Adrian Farrel" <adrian@olddog.co.uk> wrote: >> >>>Goodness, but there's a long and complicated document. But I think >>>you have made it as clear and concise as it could possibly have been. >>>Good job! >>> >>>I have done my AD review and found no substantive issues. I do, >>>however, have a little pile of nits. Actually, quite a large heap. >>>Nothing to worry about, but if you could clean them up i think it >>>would improve the document still further. >>> >>>The only topics that need real attention are those related to IANA. >>> >>>Let me know how you get on, and please object if my comments are wrong. >>> >>>Thanks, >>>Adrian >>> >>>=== >>> >>>It would be best to move the Introduction to be the first section in >>>the document. >>> >>>--- >>> >>>Section 5 >>> >>> Ethernet segments have an >>> identifier, called the "Ethernet Segment Identifier" (ESI) which is >>> encoded as a ten octets integer. >>> >>>It would help if you said "...in line format with the most significant >>>octet sent first." >> >>Done. >> >>> >>>--- >>> >>>Section 5 >>> >>> In general, an Ethernet segment MUST have a non-reserved ESI that is >>> unique network wide >>> >>>"In general" is not really consistent with "MUST" >> >>Will change "MUST" to "SHOULD" >> >>> >>>--- >>> >>>Do you want an IANA registry to track the values of the Type field of >>>the ESI? >> >>We don't anticipate any other ESI type besides the ones mentioned here. >> >>> >>> >>>--- >>> >>>There is some mixing of "octet" and "byte" in the document. This creates >>>the impression that you mean something different by the two words. >> >>Will make it consistent. >> >>> >>>--- >>> >>>Could you expand DF on first use. You have it in 8.3. >> >>Will do. >> >>> >>>--- >>> >>>Section 6 >>> >>>You use "Ethernet Tag ID", "Ethernet Tag", and "Ethernet Tag Identifier" >>>interchangeably. It would be helpful to use just one term and to check >>>usage in the rest of the document. >> >>Will do. >> >>> >>>--- >>> >>>Section 6.1 >>> >>> In such >>> scenarios, the Ethernet frames transported over MPLS/IP network >>> SHOULD remain tagged with the originating VID and a VID translation >>> MUST be supported in the data path and MUST be performed on the >>> disposition PE. >>> >>>I think you should add under what circumstances the frames MAY be re- >>>tagged with a different VID (or s/SHOULD/MUST). You don't need a >>>detailed explanation, but a guide to the implementer/operator. >> >>The sentence before this says: >>"If the VLAN is represented >> by different VIDs on different PEs, then each PE needs to perform VID >> translation for frames destined to its attached CEs." >> >>I thought this description is clear enough but I will try to make it more >>clear. >> >>> >>>--- >>> >>>Do you want IANA to create a registry and track the Route Types defined >>>for the EVPN NLRI in Section 7? >> >>We'll look into it. >> >>> >>>--- >>> >>>Section 7.1 and onwards... >>> >>>I know "RD" is a term of art in the context of BGP, but could you >>>please expand RD it on first use rather than leaving that to 8.2.1. >> >>Sure, we'll do. >> >>> >>>(All the forward references to later sections are good, thanks.) >>> >>>--- >>> >>>A small inconsistency between sections 7 and 8. In the figures in >>>Section 7 you have "MPLS Label" and "MPLS Label1" etc. In the text >>>in Section 8 you have "MPLS label" etc. When you refer to the fields >>>you need to match the case. When you refer to the concept of an MPLS >>>label, you can (of course) use normal case. >> >>Agreed. >> >>> >>>--- >>> >>>Are you sure that the ESI Label extended community and subtypes don't >>>need IANA intervention here? >> >>We have registered these values with IANA. We will reflect that in IANA >>section. >> >>> >>>--- >>> >>>It would be nice if 7.5 included a hint as to what an "ESI label" is. >> >>Agreed. >> >>> >>>--- >>> >>>In 7.10 >>> >>> If a PE uses RT-Constrain, the PE SHOULD advertise all such RTs using >>> RT Constraints. >>> >>>Is this a general restatement of RFC 4684 (if so add "As described in >>>[RFC4684]...") or new guidance for implementers of this spec (if so, >>>what is the reason for SHOULD? is there a MAY to counter it?) >> >>I'll add RFC4684 reference. >> >>> >>>--- >>> >>>8.1.1 >>> >>> The Ethernet Segment Identifier MUST be set to the ten octet ESI >>> identifier described in section 5. >>> >>>Would that be the ESII? :-) >> >>Nice catch :-) >> >>> >>>--- >>> >>>8.2.1 has "MANDATORY" I guess you are inventing a 2119 term to counter- >>>point "OPTIONAL". Please use "REQUIRED." >> >>Agreed. >> >>> >>>--- >>> >>>In Section 13.1 >>> >>> In certain >>> environments the source MAC address MAY be used to authenticate the >>> CE and determine that traffic from the host can be allowed into the >>> network. >>> >>>Want to hint which environments they would be. Possibly more important, >>>want to say in which environments this would be a damn fool idea? >> >>We'll do :-) >> >>> >>>--- >>> >>>14.1.2 >>> >>> The MPLS label stack to send the packets to PE1 is the MPLS LSP stack >>> to get to PE1 and the EVPN label advertised by PE1 for CE1's MAC. >>> >>>and >>> >>> The MPLS label stack to send packets to PE2 is the MPLS LSP stack to >>> get to PE2 and the MPLS label in the Ethernet A-D route advertised by >>> PE2 for <ES1, VLAN1>, if PE2 has not advertised MAC1 in BGP. >>> >>>It *should* be perfectly obvious to the implementer, but perhaps you >>>should say what order the labels appear on the stack since "and" is non- >>>specific. >> >>OK. >> >>> >>>--- >>> >>>Section 18 >>> >>>I wish you would add a reference to 4385 and use that control word with >>>the various fields set to zero. This would keep us from increasing the >>>number of different control word definitions in the wild. I think that >>>the impact on your spec would be zero. >> >>We'll do. >> >>> >>>--- >>> >>>Section 21 should be renamed "Contributors" >> >>We'll do. >> >>> >>>--- >>> >>>I think RFC 2119 is a normative reference. >> >>OK. >> >>> >> >
- AD review of draft-ietf-l2vpn-evpn Adrian Farrel
- Re: AD review of draft-ietf-l2vpn-evpn Ali Sajassi (sajassi)
- Re: AD review of draft-ietf-l2vpn-evpn Rabadan, Jorge (Jorge)
- Re: AD review of draft-ietf-l2vpn-evpn Ali Sajassi (sajassi)
- Re: AD review of draft-ietf-l2vpn-evpn Rabadan, Jorge (Jorge)
- Re: AD review of draft-ietf-l2vpn-evpn Ali Sajassi (sajassi)