Re: [MIB-DOCTORS] Fwd: Re: Request for MIB review of draft-ietf-storm-iscsimib

Michael MacFaden <mrm@macfaden.com> Mon, 28 January 2013 06:53 UTC

Return-Path: <macfaden@gmail.com>
X-Original-To: mib-doctors@ietfa.amsl.com
Delivered-To: mib-doctors@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D380B21F88F0 for <mib-doctors@ietfa.amsl.com>; Sun, 27 Jan 2013 22:53:52 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.973
X-Spam-Level:
X-Spam-Status: No, score=-0.973 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, FM_FORGED_GMAIL=0.622, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-1, TRACKER_ID=2.003]
Received: from mail.ietf.org ([64.170.98.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JqbvPvtrOrrV for <mib-doctors@ietfa.amsl.com>; Sun, 27 Jan 2013 22:53:52 -0800 (PST)
Received: from mail-ee0-f41.google.com (mail-ee0-f41.google.com [74.125.83.41]) by ietfa.amsl.com (Postfix) with ESMTP id E669621F87CB for <mib-doctors@ietf.org>; Sun, 27 Jan 2013 22:53:51 -0800 (PST)
Received: by mail-ee0-f41.google.com with SMTP id c13so1102632eek.14 for <mib-doctors@ietf.org>; Sun, 27 Jan 2013 22:53:51 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=VJFQIPNBp+3LL7clrFaS012E2lFhxjHz/iq/mlHNQbM=; b=WkKiGZL+Sn15+dEd2/Cz9OlJW3XkgOT536De2GPphnAmt3AeMMsxu4csxddjjUZotf +NWxTLydsmv1Z1GzowWrIVFWQmH+a62ASurPMTFEDzm+Ca06xUwngSXK2LEJwF4j52NH eMmNromYXkidToaVXmA0/u/3wFRjv+6J5M8JdC22Sg2Y1GuaCJw32KhvrOPQAymlZihF EFpsDs/i5qdpAKbwdXQZvCOw12AUpC6ASf9oMDa5yyNzb5J/uhLOrQBUcmGTV0WdYMIt stTjJKqrqnqKAA8hZO/L70xddIMpsq0HgGQ4vrdhBa5A9RYAa1D4zR0SoQzuaXti84ow 1QGQ==
MIME-Version: 1.0
X-Received: by 10.14.175.70 with SMTP id y46mr48521378eel.6.1359356031059; Sun, 27 Jan 2013 22:53:51 -0800 (PST)
Sender: macfaden@gmail.com
Received: by 10.223.15.72 with HTTP; Sun, 27 Jan 2013 22:53:50 -0800 (PST)
In-Reply-To: <50FDCD01.6080508@cisco.com>
References: <50F3EB1D.1040801@cisco.com> <50FCF2E8.1070300@cisco.com> <CAD3a8T=pF=Qb-0tYSx-6+9i4JCQUN0Wno=bM-M+eeodBeLHvcA@mail.gmail.com> <50FDCD01.6080508@cisco.com>
Date: Sun, 27 Jan 2013 22:53:50 -0800
X-Google-Sender-Auth: pNUt5bn5mj4CVh2QELxqsz-LD8Q
Message-ID: <CAD3a8TkEUFo9AGCjX7sCN2n2guurrmo3sCzxZ9u3uNFP_1ijdg@mail.gmail.com>
From: Michael MacFaden <mrm@macfaden.com>
To: Benoit Claise <bclaise@cisco.com>
Content-Type: multipart/alternative; boundary="047d7b5dbe205ac6c204d453bd69"
Cc: "MIB Doctors (E-mail)" <mib-doctors@ietf.org>
Subject: Re: [MIB-DOCTORS] Fwd: Re: Request for MIB review of draft-ietf-storm-iscsimib
X-BeenThere: mib-doctors@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: MIB Doctors list <mib-doctors.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mib-doctors>, <mailto:mib-doctors-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/mib-doctors>
List-Post: <mailto:mib-doctors@ietf.org>
List-Help: <mailto:mib-doctors-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mib-doctors>, <mailto:mib-doctors-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Jan 2013 06:53:52 -0000

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Benoit,

I reviewed the current #3 draft at
https://datatracker.ietf.org/doc/draft-ietf-storm-iscsimib/
the nits checker had a few items to review:
http://tools.ietf.org/idnits?url=http://tools.ietf.org/id/draft-ietf-storm-iscsimib-03.tx

There exist editorial comments to clean up, some noted below

- -- <a
href="./draft-ietf-storm-iscsi-cons-03">draft-ietf-storm-iscsi-cons-03</a>
&amp; remove this note.

but otherwise looks good to me.

Tests performed:
prunus% smistrip draft-ietf-storm-iscsimib-03
smistrip draft-ietf-storm-iscsimib-03
ISCSI-MIB: 3761 lines.
prunus% smilint -l9 ISCSI-MIB
smilint -l9 ISCSI-MIB
prunus% smidump -f tree ISCSI-MIB

Compared output of smidump -f identifiers from 01 draft to 03, no changes.
Verified all nonscalars begin with iscsiInstIndex index as described per
section 4 (Relationship to SNMP Contexts)
Verified marker objects were deprecated as stated in section 5.
Verified all three new objects added
  iscsiInstXNodeArchitecture
 iscsiSsnTaskReporting
  iscsiSsnProtocolLevel

items resolved from last review.
- - 4. IANA Considerations - check
- - 8. Intellectual property section -check
Rest of issues I reported in prior review were resolved previously on the
list.

s/
Mike MacFaden

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFRBiAsxTVOqsYmDtERAn2VAKDN/uPXEyiz5tAjgozx98ovFDyIUQCg0kBB
eK3FpOr48h6yIl59BmoZtyo=
=UDYf
-----END PGP SIGNATURE-----