Re: [mpls] MPLS-RT Review of draft-gandhi-mpls-ioam-sr-04

"Rakesh Gandhi (rgandhi)" <rgandhi@cisco.com> Mon, 04 January 2021 14:38 UTC

Return-Path: <rgandhi@cisco.com>
X-Original-To: mpls@ietfa.amsl.com
Delivered-To: mpls@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5F8323A0D88; Mon, 4 Jan 2021 06:38:08 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.7
X-Spam-Level:
X-Spam-Status: No, score=-7.7 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=ltroErNf; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=q3aNTm9c
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CEW7-SZtx92p; Mon, 4 Jan 2021 06:38:06 -0800 (PST)
Received: from alln-iport-1.cisco.com (alln-iport-1.cisco.com [173.37.142.88]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 547323A0D87; Mon, 4 Jan 2021 06:38:06 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=6921; q=dns/txt; s=iport; t=1609771086; x=1610980686; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=ReVTnN80rktaFOUPpsSAdoiKNkM5w40PaUaaXWzndWc=; b=ltroErNfae06UshMhpqmTcUdB9cHshbYLtDUfgp2oLg8AeDgVCiloigi Qe53J2zDg0iDTsTmYXqyA4IC2g8ir2QZWhEIfN1o930XpM+TIQX9vcDIE LcpAlT6EKRnKomWSK+fuAdOiVYg5Q3KBPl0qNSIlt4TAJBeq4pQYhGtQ8 w=;
X-IPAS-Result: A0AkAACTJvNfkIsNJK1iHAEBAQEBAQcBARIBAQQEAQFAgTsHAQELAYEiMFF9Wy8uCod9A4RZiQsDlBuEcoEuFIERA1QLAQEBDQEBLQIEAQGESgKBbwIlNAkOAgMBAQEDAgMBAQEBBQEBAQIBBgQUAQEBAQEBhjgMhXMBAQEEEi4BATcBDwIBCBEDAQIvMh0IAgQBDQUIGoMEAYF+VwMuAaREAoE8iGl0gTSDBAEBBoUCGIIQCYE4AYJ0hkKDciYbgUE/gRABQ4JWPoQJARIBIx4GgyaCLIFpWQZgBIEZgQQNKRCPdIp8jDGRPQqCdpt6gymKK5R8lAuCAp8xAgQCBAUCDgEBBoFWOCw9cHAVgyRQFwINjiEMDgmDTopYdDcCBgoBAQMJfIwNAYEQAQE
IronPort-PHdr: 9a23:IXbBGRMC4TcXhLCYXhsl6mtXPHoupqn0MwgJ65Eul7NJdOG58o//OFDEvKwz3l/UVJrW6rRPjO+F+6zjWGlV55GHvThCdZFXTBYKhI0QmBBoG8+KD0D3bZuIJyw3FchPThlpqne8N0UGGNv3eFDT5Ha16G1aFhD2LwEgIOPzF8bbhNi20Obn/ZrVbk1IiTOxbKk0Ig+xqFDat9Idhs1pLaNixw==
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-AV: E=Sophos;i="5.78,474,1599523200"; d="scan'208,217";a="622456311"
Received: from alln-core-6.cisco.com ([173.36.13.139]) by alln-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 04 Jan 2021 14:38:05 +0000
Received: from XCH-RCD-004.cisco.com (xch-rcd-004.cisco.com [173.37.102.14]) by alln-core-6.cisco.com (8.15.2/8.15.2) with ESMTPS id 104Ec2gm020781 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 4 Jan 2021 14:38:04 GMT
Received: from xhs-rtp-001.cisco.com (64.101.210.228) by XCH-RCD-004.cisco.com (173.37.102.14) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 4 Jan 2021 08:38:03 -0600
Received: from xhs-rtp-002.cisco.com (64.101.210.229) by xhs-rtp-001.cisco.com (64.101.210.228) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 4 Jan 2021 09:38:02 -0500
Received: from NAM10-MW2-obe.outbound.protection.outlook.com (64.101.32.56) by xhs-rtp-002.cisco.com (64.101.210.229) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Mon, 4 Jan 2021 09:38:02 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YZEFDtSF6VwZdc5k+oDYQA8FeNS8WAF9inPfTacxH5wxttpp/wdm/pTNjSyLCZOeDcMaxAHKNxGhDdbWpoVV1rPUX3PmALCSEdHMPdNqn8U7k8BkEy9/yJDIRWEIqvps4pD5NXyFakttJBn8CLFETuOID6XlgURI9RQ/XKG2Btw8haZR8kRDdB6LRilJu2x4NPR78r5kHk80lPEi0Q3gX8Z2tJgMZPxkmQbkf6VerEH6JqNoAhGdzCmilk+518kDzPVjXQ0k1LV6H0Ey+KXMYbBhoFuYzqxtob9uMYLC3h+yJ9h1rajnsxMpenvwU8oqJ4gSNfcmTQLhV6ZtZRhUMw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4o0Qebwlu3KD2Af+39CaE2QEnwBdjKqUsungFFcR3YQ=; b=BGgZT7F6aRqUROjbSrBVqDP2slj0hyLXVUIjH5IrvVonWdPNTdgl2JGmKfzQHtmfvFlBd9+XPkEnBSKKM9nc4iFvYtKFz53pPczH5l41Fb6cppefuA+ydq4i5T/WB6U3deE++f5hqQozb38jehLFlrMu/qHK6OWv50YtkQK6w2zIYwupNiaaC576k3ILMz+/nkic9pWQs8kay+195hpafJqBs0NHS40svtF7hMYgVs1iuCGpMHwXPUdZahnMLYRZ/xElzDHMkNUny90zzoHIq1+RTBNgSMv6VrZF1wgHT1m4k0eEs7dKAV9vPsH86k44wQMwx49pl9x9zMOrBJ/xaQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4o0Qebwlu3KD2Af+39CaE2QEnwBdjKqUsungFFcR3YQ=; b=q3aNTm9cG8Q4CbydHscaCAYEQ/T4k8Mmhigas5p4bxxBNSSEQrv0G4BY9M/KbYnupjTyD9EnMiYFOukFvATV/NMvNRGB1NYclcBEJgpajW79xzTJ5CwEdXHOQhtn4PqNX3v6uVPNxBR7zLHowd1JAF9f97ai9qaKMMf3qa3WjZQ=
Received: from DM6PR11MB3115.namprd11.prod.outlook.com (2603:10b6:5:66::33) by DM6PR11MB3883.namprd11.prod.outlook.com (2603:10b6:5:19f::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.23; Mon, 4 Jan 2021 14:38:01 +0000
Received: from DM6PR11MB3115.namprd11.prod.outlook.com ([fe80::b0:395a:1430:79d3]) by DM6PR11MB3115.namprd11.prod.outlook.com ([fe80::b0:395a:1430:79d3%5]) with mapi id 15.20.3721.024; Mon, 4 Jan 2021 14:38:01 +0000
From: "Rakesh Gandhi (rgandhi)" <rgandhi@cisco.com>
To: Mach Chen <mach.chen@huawei.com>, mpls <mpls@ietf.org>, mpls-chairs <mpls-chairs@ietf.org>
CC: "draft-gandhi-mpls-ioam-sr@ietf.org" <draft-gandhi-mpls-ioam-sr@ietf.org>
Thread-Topic: MPLS-RT Review of draft-gandhi-mpls-ioam-sr-04
Thread-Index: AQHW2hyE7dWc8KJ1EUG9/rtKvDGItqoPZZgAgAgyj5k=
Date: Mon, 04 Jan 2021 14:38:01 +0000
Message-ID: <DM6PR11MB3115122E45D5D9734E2A7023BFD20@DM6PR11MB3115.namprd11.prod.outlook.com>
References: <CAA=duU21PHQoJP0cEX6o1K=EwUFqeH19YvcDPNJVKE9c2szS6w@mail.gmail.com>, <F73A3CB31E8BE34FA1BBE3C8F0CB2AE2980ACEB1@dggeml530-mbs.china.huawei.com>
In-Reply-To: <F73A3CB31E8BE34FA1BBE3C8F0CB2AE2980ACEB1@dggeml530-mbs.china.huawei.com>
Accept-Language: en-CA, en-US
Content-Language: en-CA
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=cisco.com;
x-originating-ip: [174.112.172.213]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: cde17b9a-c332-4777-1a40-08d8b0be566e
x-ms-traffictypediagnostic: DM6PR11MB3883:
x-microsoft-antispam-prvs: <DM6PR11MB388354F0888EA99FCC9871B2BFD20@DM6PR11MB3883.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: K9lHlJFZbBAYtj93qu/UM/f2ONfAEdD2s55ZB2tMGgdQar5IQHH0tJQ6GCIjgh0VXnsgJEr3dqSU6+6Ruq8HCW1vBf/DFH51ITYOupi01FphR8iprNGqPI4ueRN9IATmCiBkI5OZPDSqQ3RBy8lUPSQfTXUK3U3aI/xp2Yv2OfqHHFeCu9okYMPiGwTFd3EkfNS1gxG58jZ4qnyWCBYsBCgTgC12risII16qqa4Nu+d7zejT57KMSfL60xjzwrnM0so6mHupOKQ9MaTg1kUrATglgeZeVQnANu2yinZ5e0szaBl1LzJjMeqV0yfOw/Y10WUN2Mp2B/uRmrLwUgJsx0S3/DfQHpUop5g7vuzwD/KhRuEudn5BMyvaEVzfivhIyUJO5GZZGDjbyzlJoQshkA==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3115.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(396003)(346002)(39860400002)(376002)(366004)(478600001)(83380400001)(7696005)(8936002)(55016002)(9686003)(76116006)(66476007)(66556008)(64756008)(66446008)(5660300002)(91956017)(66946007)(71200400001)(86362001)(33656002)(53546011)(6506007)(8676002)(316002)(4326008)(186003)(2906002)(52536014)(110136005)(26005); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: vsyah4XXx85uELh/AjlptxQnJVcO2Vb0SF5CD2d51csOq/+jKmg6OqFgVeXTMkxksz0wyeeyqre6HKDGq512FJIrvUO0lfprHijVTYhKxuDVgXDHiY+KTsFL0dJjjIKKN63CYD133Qz+DhNQjuYRvF/LMfv+6TRsbz6I7uct0Snevk1uNoTeMwiZZuu2AIhPNcT+nlQgKh+ESwrqYl9IX6SAyMbaTo3cRBUCSy6QUoA71fh0eKT0nomuHFBc77olyvTZNmLMPF2uDy+rRur72Ref3tdvzYfEomzlDAMyKUNFoMseHB/TA4ut+Zh5FUFQxcB6aqgzwEc2ppmxkcFC7YC8aXWzXbCMsIGpVnLFT+BeVCP/kzCKQVdH95rXaDtPmswAkcHQkdTVCKJ3ifC67W4eQSgpD0kq/kQxMxXx7cBGlHCyFR+9ashnYV0zoiHzoA74PU3yffPkTA5yBpK84KMPd/2e0xw9tkaV704wlymeHntNWJ6C3+tlTKCPBWIzUwMuPAZttsa/OVb8MB9lqniTMrjGW/cbxDqDG8zHTTR3YFzuTwD9I0sUtmWEuCSjbKr8XrMykLM1bOEUtxQseHMEQ0fu2o7Z2hXJVRlEPKKdViwWOphAfDDLgFo4uPMY/i6x41rTugDpqct5vgf2hUJwGiHeAcf+nNlT5wbEMgYoVbNOpowtRfkBgnyQl+mKGO53nwvpnVqP1kQFnXOMUMtdqqTbv8HrnI5gVwmL1MozQx07HNiuYyP9iV191Sfj4ZZekJaw5aHVuUxUOt6OnWVNY5RD3YUPZUZPkKob+4unSUzCMVyxzugNnKhe5yYkjjOrUf2KHQpgBrO3ONkddV5qDW7mRbbl1IkH0U+SQJlLj5nnq66LpEGLXNTB85gwIh1Ib8Q1NM4aAbb13k2mzI/9kLS4U5V55hjjWy9HXou38LxchfD9pYtuDcAXCgGZ6JPR1TyF+OLtshP9xfkzhGqRtvQ9lhwLY0tNstVUtil5ydf8xeUmgcv4kgj4JUSwkOl1222HdjJp0MLrOzOH2w==
x-ms-exchange-transport-forked: True
Content-Type: multipart/alternative; boundary="_000_DM6PR11MB3115122E45D5D9734E2A7023BFD20DM6PR11MB3115namp_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3115.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cde17b9a-c332-4777-1a40-08d8b0be566e
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jan 2021 14:38:01.2906 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xLSazrdn58jXLIDXSBKJkdIQ7ZqiI5X8fLA74BslJhlo1RD7nR1WzepxmfM1LI8el/SqCLTGbaVUkpE9oRrrMA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3883
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.37.102.14, xch-rcd-004.cisco.com
X-Outbound-Node: alln-core-6.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/mpls/xNrb9td72oK1Gu2MF5I9DHmV998>
Subject: Re: [mpls] MPLS-RT Review of draft-gandhi-mpls-ioam-sr-04
X-BeenThere: mpls@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Multi-Protocol Label Switching WG <mpls.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mpls>, <mailto:mpls-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/mpls/>
List-Post: <mailto:mpls@ietf.org>
List-Help: <mailto:mpls-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mpls>, <mailto:mpls-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Jan 2021 14:38:09 -0000

Happy New Year!

Many thanks Mach for the MPLS-RT review. Please see comments inline with <RG>..

From: Mach Chen <mach.chen@huawei.com>
Date: Wednesday, December 30, 2020 at 4:20 AM
To: mpls <mpls@ietf.org>, mpls-chairs <mpls-chairs@ietf.org>
Cc: draft-gandhi-mpls-ioam-sr@ietf.org <draft-gandhi-mpls-ioam-sr@ietf.org>
Subject: MPLS-RT Review of draft-gandhi-mpls-ioam-sr-04
Hi,

I've been asked to provide a pre-adoption MPLS-RT review of draft-gandhi-mpls-ioam-sr-04.

Below are my review comments:

1. I agree that it's more reasonable to leverage GAL/gACH with one or two new dedicated channel types for indicating the presence of iOAM data.

<RG> Yes, we will change to use ACH with IOAM Indicator Label, as agreed on another email thread.

2. In addition, the draft proposes to support both E2E and hop-by-hop (HBH) options. It's nature to use GAL/gACH or the IOAM Indicator Label (IIL) to indicate the presence of iOAM data.  But for HBH case, each intermediate LSR is supposed to process the iOAM data, and the GAL or IIL is put at the bottom of the stack, how does an intermediate LSR know whether there is iOAM data present and it should process the iOAM data?  To scan the whole label stack to find the GAL/IIL or through other means (e.g., put an indicator label on the top the label stack, this may require that each LSR need to pop the IIL label firstly, then process the next label, and put the IIL label back onto the top when forwarding the packet to the next hop) ?  For either way, this needs to be explicitly defined in the document.

<RG> Yes, this is similar to the entropy label where a mid-point node needs to scan the label stack to find the indicator label. We can add some text to clarify this. There is already an optimization to use a different indicator label for HbH compared to E2E case to unnecessarily avoid parsing the IOAM data fields.

Thanks,
Rakesh

I am OK with other parts of the draft, but the above comments would result in non-trivial updates to the draft, I would see an update before the WG adoption call.

Best regards,
Mach