Re: [netmod] comments on draft-ietf-netmod-yang-instance-file-format-04

Balázs Lengyel <balazs.lengyel@ericsson.com> Wed, 06 November 2019 23:07 UTC

Return-Path: <balazs.lengyel@ericsson.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2CBC71201B7 for <netmod@ietfa.amsl.com>; Wed, 6 Nov 2019 15:07:51 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.001
X-Spam-Level:
X-Spam-Status: No, score=-2.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JBtRI_-0dEeS for <netmod@ietfa.amsl.com>; Wed, 6 Nov 2019 15:07:48 -0800 (PST)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10076.outbound.protection.outlook.com [40.107.1.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2BC36120052 for <netmod@ietf.org>; Wed, 6 Nov 2019 15:07:48 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dWvQt4ZwCj/DNUCa0XYIEXj5xU8+kKTfa+u+t0D01vcvzSn2Tysc2ok8f4VrCH1U/1rEGFOkE3ysoszwlUdb3f2VJCBQzD7FdeO+S2fDXTk5iPKw1NCtzCct9u/giTgEA6G6LTdx9i+hS+81aJ244GeBglYKtDUgn2p+UATyiBfAog5FeGVL1fDVMxMnWXymXudVcqi8J75FrhYZ8d4PacypGlEn7rPJgw6Nusajzy3va0HOo4wd8qha+ROY9rwQNB2TFDNNY7A8Y3KrEvLEQnQypfZKs064kWRLVkv2O0c9pAXd/n9oVGvAbmyoffgf905gQF1p1OFRClMMqCm93w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hd7j24zvyasYT61qQNBVaVHAXK5hi0wZYs6mqX7p1sM=; b=OyZaHUgLjRs+9HtPAdGuxhfwU9zew92ooAnr3OX2Det/vKe/P9YjBsgMBSdeeIlHyOHF/40OReFpdPq6QRvGgB/x/ErccntUxzaWMjw1/Lgy0K/7fvD5uu4LZGYCPadXpHb7SFhSQKA/sTc08k5dDIKjvCCguCazUBhzuFoV4AFg8Zf2izpnfWC2+uybb6EIxmq40l66J3lwduKsffcRCBR+epBEAuRFDFYHYK5mzJ3B1jISKUt9t7rIBIWta29NqHGvgxDPVmKK4SXeSti0IuSjQN9JnnlAOINR/kp2sBIqnrz2rXJiucKpNwdi81RakeJa8bk8ZkuQE6XC/6rAnA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hd7j24zvyasYT61qQNBVaVHAXK5hi0wZYs6mqX7p1sM=; b=eCEp4mcdJJHlYYmLhaBlrZI3Ncq9Pq0zLAwc9hRd/lzL5aSITLXHQ7bcY69c2cEKIcQriCYXC/pZbHItrDHsVND8IFQE6hmty9Nxm2NgZXp/j0z46cstHeJqu0YTl6oIGnGASBJzt4x3ducLOxA6pv8dLbXn+Z/aVs/nZTHFSHQ=
Received: from AM7PR07MB6214.eurprd07.prod.outlook.com (10.186.170.77) by AM7PR07MB6278.eurprd07.prod.outlook.com (10.186.171.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.16; Wed, 6 Nov 2019 23:07:44 +0000
Received: from AM7PR07MB6214.eurprd07.prod.outlook.com ([fe80::3c4a:6fb:4b5a:8a]) by AM7PR07MB6214.eurprd07.prod.outlook.com ([fe80::3c4a:6fb:4b5a:8a%7]) with mapi id 15.20.2430.020; Wed, 6 Nov 2019 23:07:44 +0000
From: =?utf-8?B?QmFsw6F6cyBMZW5neWVs?= <balazs.lengyel@ericsson.com>
To: Andy Bierman <andy@yumaworks.com>, Martin Bjorklund <mbj@tail-f.com>
CC: NetMod WG <netmod@ietf.org>
Thread-Topic: [netmod] comments on draft-ietf-netmod-yang-instance-file-format-04
Thread-Index: AQHVf2MbQga78mSle0Opwa3noseNw6dUAaKAgAAieICAKsPXIA==
Date: Wed, 6 Nov 2019 23:07:43 +0000
Message-ID: <AM7PR07MB621401A82C579C14C2D42C82F0790@AM7PR07MB6214.eurprd07.prod.outlook.com>
References: <20191010.140525.904627955349075516.mbj@tail-f.com> <CABCOCHShFd41gcGLTSjJQMWCA4Ak_QX2iHpng_6DBqLRf23vqw@mail.gmail.com> <CABCOCHQsuHR_Y_LR53_VVLSAeuMQWG8Ae_-C2v-GSj-9RELGTg@mail.gmail.com>
In-Reply-To: <CABCOCHQsuHR_Y_LR53_VVLSAeuMQWG8Ae_-C2v-GSj-9RELGTg@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=balazs.lengyel@ericsson.com;
x-originating-ip: [80.98.34.204]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 4faab8de-c9e3-421b-f02b-08d7630e2190
x-ms-traffictypediagnostic: AM7PR07MB6278:
x-microsoft-antispam-prvs: <AM7PR07MB6278491495EFFF32955CF9EDF0790@AM7PR07MB6278.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:3276;
x-forefront-prvs: 02135EB356
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(136003)(39860400002)(346002)(376002)(396003)(189003)(199004)(81156014)(26005)(6246003)(8676002)(7736002)(186003)(66066001)(86362001)(53546011)(102836004)(236005)(606006)(76176011)(6506007)(790700001)(6116002)(3846002)(33656002)(7696005)(2906002)(74316002)(478600001)(229853002)(316002)(110136005)(11346002)(81166006)(25786009)(966005)(99286004)(66556008)(71190400001)(71200400001)(4326008)(99936001)(66946007)(64756008)(9686003)(6436002)(52536014)(66476007)(66446008)(476003)(76116006)(446003)(54896002)(66616009)(6306002)(5660300002)(85182001)(85202003)(55016002)(256004)(8936002)(486006)(14454004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM7PR07MB6278; H:AM7PR07MB6214.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: gnXx6abPJ8rX4buz4AihcjCZY3gO2mjoiNcpHflJUnjeJ5UZqa9hMCfVlh7n2GPxYoRd8zVhIh3yHSKkEUVvpbn6daduia5eIVeqwbeq/Dym+RRuMy7TgLIrNa9zUmkChWvdsjFsCGTavGfrXl0+vzTjIxBhyMwwyh9w7c/BvZtzf/ZZQNv+SiqiOeVLsdQllTNzqt/oluvfQ2GvOl+55NrmwYkzMHdgXaCDGON8bbceNhsZEC6LyjFSMpry2eO2WimNuZrZW3CEiWyOKoq/pwpUIsp6f51AsjwP5POOOfjSks/PTbcFY/DmL5MfVoqi61TnIjJ6nNgXGRVkZRcjW3wWvKaAqXL/OwUt0p7GQRv95PQwJqcEYHuzu8fMFcu8mD9qoG8NLY/6V/VJtT2KfGcE6UruTHaAeNdw5iVlWqP6deWf5DD+/TntAToxOxoO
x-ms-exchange-transport-forked: True
Content-Type: multipart/signed; protocol="application/x-pkcs7-signature"; micalg=SHA1; boundary="----=_NextPart_000_0950_01D594FF.5FC0CD60"
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4faab8de-c9e3-421b-f02b-08d7630e2190
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Nov 2019 23:07:43.8460 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XOyhSGbp/1iFDHjTfFRwsgxyKVx9WEPn+Eu/kwZEFgV2xaGTwhKpsPoU42wKc3ufmFMexY4vp3v2QxDBgLrvjXKE8DtCLPMuiKYolD9chQ8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR07MB6278
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/EdSjItPqMWUkpsKWHmBi8ge2rSk>
Subject: Re: [netmod] comments on draft-ietf-netmod-yang-instance-file-format-04
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Nov 2019 23:07:51 -0000

See below, Balazs

 

From: netmod <netmod-bounces@ietf.org>; On Behalf Of Andy Bierman
Sent: 2019. október 10., csütörtök 19:38
To: Martin Bjorklund <mbj@tail-f.com>;
Cc: NetMod WG <netmod@ietf.org>;
Subject: Re: [netmod] comments on draft-ietf-netmod-yang-instance-file-format-04

 

 

 

On Thu, Oct 10, 2019 at 8:34 AM Andy Bierman <andy@yumaworks.com <mailto:andy@yumaworks.com> > wrote:

 

 

On Thu, Oct 10, 2019 at 5:06 AM Martin Bjorklund <mbj@tail-f.com <mailto:mbj@tail-f.com> > wrote:

Hi,

I have some mostly cosmetic comments on this draft.

  o  "YANG" should be spelled "YANG".  Not Yang etc.


  o  "NETCONF" should be spelled "NETCONF".


  o  leaf-list module

    The type of this leaf-list is a string with:

      pattern '.+@\d{4}-\d{2}-\d{2}\.yang';;

    I think the revision needs to be optional, and the suffix ".yang"
    dropped, since it doesn't add any value:

      pattern '.+(@\d{4}-\d{2}-\d{2})?';

   (same for inline-spec).



 

 

IMO the filespec SHOULD follow the pattern in  https://tools.ietf.org/html/rfc7950#section-5.2

 

Except a new file extension SHOULD be used.

Suggest: .yif == YANG Instance File

 

Obviously it would be a horrible idea to use .yang since that extension

is already used to identify a YANG schema file.

 

 

 

Sorry about the confusion over this comment.

 

There should be reusable typedefs defined in rfc6991bis representing the format in 7950, sec. 5.2

 

There should also be file extensions defined for an XML or JSON file that is expected to

follow the YIF structure.  

 

 

Andy

BALAZS: 

For the modules listed in leaf-list module: These are real YANG schema files so IMO the “.yang” extension should be used.

For the instance data files: In the -00 version of the draft it was stated that the files should have their own extension “.yid” . 

“.yid-json” and “.yid-xml” was also discussed.

However, the group requested that I just use .json and .xml  as extensions (as described in section 3.)