Re: [netmod] comments on draft-ietf-netmod-yang-instance-file-format-04

Balázs Lengyel <balazs.lengyel@ericsson.com> Sun, 17 November 2019 13:52 UTC

Return-Path: <balazs.lengyel@ericsson.com>
X-Original-To: netmod@ietfa.amsl.com
Delivered-To: netmod@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CA88A12010C for <netmod@ietfa.amsl.com>; Sun, 17 Nov 2019 05:52:18 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.001
X-Spam-Level:
X-Spam-Status: No, score=-2.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XVqYs2tMt3S2 for <netmod@ietfa.amsl.com>; Sun, 17 Nov 2019 05:52:16 -0800 (PST)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40053.outbound.protection.outlook.com [40.107.4.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4FE6A1200CD for <netmod@ietf.org>; Sun, 17 Nov 2019 05:52:16 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a0CM8lDdFcnjBzIxBfyewytXHP4rlLD6ylumvfYE9YiXQ5Oj0tsebGpt8zDU8INHdmMfWvexNHWd4tvk5VqL3gEk+Cza4YWSwgjO774a9Q3uL+qnHyqPylpX3XTurwqRTb1irU8qtc3gtLYLMmtSp32PlxgHN6DcAoiglqYmH6MXsfGKJCR1Xd4W8QqSmr+rw8/DtzuOxRlM6aNQorHf7wpmwzvFqQT1AbEjic/JaD0QBQ0vxrAP/yLNaqkFewgSa+V5Pe1k8GylgTTLNY4yIMERCWCGffPuqruWiGDfOJDOFp3r46+OonmRu4qPg+nI155wMivbnuwgvpBPa2d+Tg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dzRO7yrI83abZzTtHkab7/YaG3zNevtFThna1gk31tc=; b=mRSnymzqQ6mqCPaLw64TgHm0LSEtaciwimqfFUemklhawnNkm3knSLbxvrSyzjZiTifZ5PEmN8Y0uT04AvlaSvg9alqHABJK7PsSrBqJV5sh+yP0gGLTokItbV58/z+QB7DlHL6QqM12xy9B1Mp4YzxD4W6ojkLeQnw4U4kuZY3m1jyNx8bhzVpTPQ0uTk0QMVbuv3376gLueu67t02MBbIVfwcEWT6kB6bf6/ikfV9MW68Qrlq1LTgsTLinGkkXIy7iglop7Rtmn1zkg20t4srIttSYt6Rk9kR6+bpwDagjpWCWeCuMFtRUWD97cEmSSGNnoZjZ0/5yjwqQiZyq1w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dzRO7yrI83abZzTtHkab7/YaG3zNevtFThna1gk31tc=; b=kdsZUK8aESvGNj3gpW8j1XzPg/WRBnGFJ9oYeiUr30nKNmtqk0ccWpDMjlgLcAXX61T+sLWkpslnemlRQ2TQweFLXrvGGsRX8u2dOkmpQtdMo3ilDVBoTVVUeMs4EEt8AzhZxf5u4Cb/EuvUcL6F809P7Z0Q3GguZaMOI21Ha00=
Received: from AM7PR07MB6214.eurprd07.prod.outlook.com (10.186.170.77) by AM7PR07MB6328.eurprd07.prod.outlook.com (10.186.169.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.12; Sun, 17 Nov 2019 13:52:14 +0000
Received: from AM7PR07MB6214.eurprd07.prod.outlook.com ([fe80::749e:982d:1c62:367b]) by AM7PR07MB6214.eurprd07.prod.outlook.com ([fe80::749e:982d:1c62:367b%4]) with mapi id 15.20.2474.012; Sun, 17 Nov 2019 13:52:14 +0000
From: =?iso-8859-1?Q?Bal=E1zs_Lengyel?= <balazs.lengyel@ericsson.com>
To: Martin Bjorklund <mbj@tail-f.com>
CC: "netmod@ietf.org" <netmod@ietf.org>
Thread-Topic: [netmod] comments on draft-ietf-netmod-yang-instance-file-format-04
Thread-Index: AQHVf2MbQga78mSle0Opwa3noseNw6d+f8qggAEGaACAEAq0IA==
Date: Sun, 17 Nov 2019 13:52:13 +0000
Message-ID: <AM7PR07MB6214ECE71D6D610B3EE9DBA3F0720@AM7PR07MB6214.eurprd07.prod.outlook.com>
References: <20191010.140525.904627955349075516.mbj@tail-f.com> <AM7PR07MB621477C933EE522C6C2EA3B2F0790@AM7PR07MB6214.eurprd07.prod.outlook.com> <20191107.090806.62241800390258021.mbj@tail-f.com>
In-Reply-To: <20191107.090806.62241800390258021.mbj@tail-f.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=balazs.lengyel@ericsson.com;
x-originating-ip: [2001:67c:1232:144:110e:633f:b6cd:de19]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 290af1c2-ff7f-4271-649c-08d76b6559ef
x-ms-traffictypediagnostic: AM7PR07MB6328:
x-microsoft-antispam-prvs: <AM7PR07MB6328ABEF5F27DD5670F9F883F0720@AM7PR07MB6328.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6790;
x-forefront-prvs: 02243C58C6
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(346002)(396003)(376002)(366004)(136003)(189003)(199004)(13464003)(316002)(76116006)(6436002)(86362001)(55016002)(8676002)(99286004)(81166006)(74316002)(81156014)(71190400001)(71200400001)(305945005)(9686003)(7736002)(4326008)(6916009)(5660300002)(66574012)(6246003)(66616009)(66446008)(64756008)(66556008)(66476007)(66946007)(33656002)(8936002)(52536014)(229853002)(478600001)(46003)(2906002)(11346002)(446003)(486006)(14454004)(476003)(6116002)(14444005)(7696005)(76176011)(53546011)(6506007)(102836004)(25786009)(186003)(256004)(21314003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM7PR07MB6328; H:AM7PR07MB6214.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: ucNTSl23nyathBIjGNTL9RZDZQzLvQDlzdq9eoUpzaVcRNECKFNHXu/ec03uLGYm4/Br0Petnw2koV+v5KaVrIuWdnh+YQMgRjpZgga4Ja6+LhjDCyKLcjNqr2lDpF8E8CtZPYqUXBfnVg1bo83PEDcC0KDkwavpui36B7BpjiGQuAPa4VCTk64UVtblh8Ebxws+uo55LLzDAshtt/An8mmzeEXb0rk0AKeVqXodSuFV+eH5UYw6g89UUv6cU/u9fiDzXaZBgbw+ihEMh/M2uD5U99aOUoDrKjbTJhruZ/IewQnPuZ7lY9mVkjjbB0iFZBpOlGo/z42t7AYW/U+rbJUPzFMYsP4LtAv/xSrJtpdSSzwyw4G/qyoAyXcGK0Wv34UiU6DopBbIhDG3jzOLDa/xsh7dYVsdYgoSRqUu34pTb+xXQKTbSzA7KhmZ2Op6
x-ms-exchange-transport-forked: True
Content-Type: multipart/signed; protocol="application/x-pkcs7-signature"; micalg=SHA1; boundary="----=_NextPart_000_02A5_01D59D8B.82508E30"
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 290af1c2-ff7f-4271-649c-08d76b6559ef
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2019 13:52:13.9640 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0/kOasrNXVBEiNaxe2enFdZUxLEj0QivwD1xWQ2YuWudUnfj9FAUnH7IKaPnf9mYorK/YT7kjB6cHx4iTh0kYvgkW8gFtB+H7wbXsiHfd2g=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR07MB6328
Archived-At: <https://mailarchive.ietf.org/arch/msg/netmod/mpcCQSqmAbD4V75TUkwHjZQfKdw>
Subject: Re: [netmod] comments on draft-ietf-netmod-yang-instance-file-format-04
X-BeenThere: netmod@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: NETMOD WG list <netmod.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/netmod>, <mailto:netmod-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/netmod/>
List-Post: <mailto:netmod@ietf.org>
List-Help: <mailto:netmod-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/netmod>, <mailto:netmod-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 17 Nov 2019 13:52:19 -0000

See below BALAZS2.

-----Original Message-----
From: Martin Bjorklund <mbj@tail-f.com> 
Sent: 2019. november 7., csütörtök 16:08
To: Balázs Lengyel <balazs.lengyel@ericsson.com>
Cc: netmod@ietf.org
Subject: Re: [netmod] comments on
draft-ietf-netmod-yang-instance-file-format-04

Hi,

>   o  leaf-list module
>     The type of this leaf-list is a string with:
>       pattern '.+@\d{4}-\d{2}-\d{2}\.yang'yang';
>     I think the revision needs to be optional, and the suffix ".yang"
>     dropped, since it doesn't add any value:
>       pattern '.+(@\d{4}-\d{2}-\d{2})?';
>    (same for inline-spec).
> BALAZS: I disagree, IMHO we need the revision date. We want to know 
> the exact version the data was produced against. If the version would 
> be unknown it might become very hard to understand whether the 
> instance data is correct or not.

The point is that the revision statement is optional in YANG.  If the module
doesn't have a revision statement I can't list it here.
BALAZS2: OK, I will update the pattern  to make the date optional, and will
add in the description, that if it is available it must be used.

> 
>   o  schema-uri
>     The description says:
>           A reference to another YANG instance data file.
>           This instance data file will use the same set of target
>           YANG modules, revisions, supported features and deviations
>           as the referenced YANG instance data file.
> 
>    I don't understand what this means.  Does it mean that the schema
>    for this document is the same as the schema defined in the
>    schema-uri file, or that the schema-uri file defines the schema in
>    its content-data?
> 
>    I *think* it is the former.  In either case, the name of the leaf
>    can perhaps be changed to reflect the semantics, rather than the
>    syntax (i.e., don't call it xxx-uri just b/c its type is an uri).
>    Perhaps 'same-schema-as-file'.
> BALAZS:  OK, I changed the description hope it is easier to understand
now.
>             description
>               "A reference to another YANG instance data file.
>                This instance data file will use the same
>                content schema as the referenced file.";

Thanks, better.  Perhaps: s/will use/uses/
BALAZS2: OK

/martin