Re: [netmod] comments on draft-ietf-netmod-yang-instance-file-format-04

[Balázs Lengyel <[e-mail]>]

See below BALAZS2.

-----Original Message-----
From: Martin Bjorklund <[e-mail]> 
Sent: 2019. november 7., csütörtök 16:08
To: Balázs Lengyel <[e-mail]>
Cc: [e-mail]
Subject: Re: [netmod] comments on
draft-ietf-netmod-yang-instance-file-format-04

Hi,

>   o  leaf-list module
>     The type of this leaf-list is a string with:
>       pattern '.+@\d{4}-\d{2}-\d{2}\.yang';
>     I think the revision needs to be optional, and the suffix ".yang"
>     dropped, since it doesn't add any value:
>       pattern '.+(@\d{4}-\d{2}-\d{2})?';
>    (same for inline-spec).
> BALAZS: I disagree, IMHO we need the revision date. We want to know 
> the exact version the data was produced against. If the version would 
> be unknown it might become very hard to understand whether the 
> instance data is correct or not.

The point is that the revision statement is optional in YANG.  If the module
doesn't have a revision statement I can't list it here.
BALAZS2: OK, I will update the pattern  to make the date optional, and will
add in the description, that if it is available it must be used.

> 
>   o  schema-uri
>     The description says:
>           A reference to another YANG instance data file.
>           This instance data file will use the same set of target
>           YANG modules, revisions, supported features and deviations
>           as the referenced YANG instance data file.
> 
>    I don't understand what this means.  Does it mean that the schema
>    for this document is the same as the schema defined in the
>    schema-uri file, or that the schema-uri file defines the schema in
>    its content-data?
> 
>    I *think* it is the former.  In either case, the name of the leaf
>    can perhaps be changed to reflect the semantics, rather than the
>    syntax (i.e., don't call it xxx-uri just b/c its type is an uri).
>    Perhaps 'same-schema-as-file'.
> BALAZS:  OK, I changed the description hope it is easier to understand
now.
>             description
>               "A reference to another YANG instance data file.
>                This instance data file will use the same
>                content schema as the referenced file.";

Thanks, better.  Perhaps: s/will use/uses/
BALAZS2: OK

/martin