Re: [quicwg/base-drafts] No RTT samples, no persistent congestion (#3889)

Martin Thomson <notifications@github.com> Sun, 19 July 2020 23:49 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1C5D93A0B5B for <quic-issues@ietfa.amsl.com>; Sun, 19 Jul 2020 16:49:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.483
X-Spam-Level:
X-Spam-Status: No, score=-1.483 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NvOLIWC92QYi for <quic-issues@ietfa.amsl.com>; Sun, 19 Jul 2020 16:49:56 -0700 (PDT)
Received: from out-17.smtp.github.com (out-17.smtp.github.com [192.30.252.200]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D04B23A0B59 for <quic-issues@ietf.org>; Sun, 19 Jul 2020 16:49:55 -0700 (PDT)
Received: from github-lowworker-c5134a3.ac4-iad.github.net (github-lowworker-c5134a3.ac4-iad.github.net [10.52.23.55]) by smtp.github.com (Postfix) with ESMTP id EDFCB6E0A51 for <quic-issues@ietf.org>; Sun, 19 Jul 2020 16:49:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1595202594; bh=+h4VnUzxhE3KRtKRjUev7GvAD/6pGfcC155Cjb4CeKo=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=egDBqYry0NnBZYSmor2UpWs1AouNqsTxpXF9ZwgaHXrABXkoNWthHSOqAps6k5xQ1 8ycVun29CW5YrYxHX7ANDcK3ZFiM7BP39AKu3w5Aw6tHSqVEMHQC5Q0uskUElJ07rH f7D7X0PaDgI/GVJHhvzC7XfLzZCF6brnBq3I2Q9c=
Date: Sun, 19 Jul 2020 16:49:54 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2QSSA65JTREZQXBZV5EC6SFEVBNHHCOAK6ZQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3889/review/451174759@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3889@github.com>
References: <quicwg/base-drafts/pull/3889@github.com>
Subject: Re: [quicwg/base-drafts] No RTT samples, no persistent congestion (#3889)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f14dc22de2fa_1a703fafe82cd9682741a8"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/-yyBJdIl2PKbOhGrQy7XPkpMCVs>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 19 Jul 2020 23:49:57 -0000

@martinthomson commented on this pull request.



> +The persistent congestion period SHOULD NOT start until there is at
+least one RTT sample, both because the length of the period is unknown and
+the PTO may be excessively conservative.

Maybe a wordier version is clearer:

"Persistent congestion SHOULD NOT consider packets that were sent prior to obtaining an RTT sample.  Correctly detecting persistent congestion can depend on packets being sent on PTO expiration.  The initial RTT, which is used to set the PTO timer, might be too conservative.  If the first RTT sample results in a much smaller RTT, the resulting persistent congestion interval might contain too few packets for their loss to be indicative of congestion."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3889#pullrequestreview-451174759