Re: [quicwg/base-drafts] No RTT samples, no persistent congestion (#3889)

[Martin Thomson <[e-mail]>]

@martinthomson approved this pull request.

It took me quite a while to confirm that "is first rtt sample" is good.  It's slightly more expansive than what I had implemented (which records 

This has the effect of including packets sent prior to getting that sample.  But as this is only packets sent within a single RTT, it's guaranteed to be less than a PTO.

> @@ -1580,14 +1586,18 @@ Invoked when an ACK frame with an ECN section is received from the peer.
 Invoked when DetectAndRemoveLostPackets deems packets lost.
 
 ~~~
-   InPersistentCongestion(lost_packets):
+   InPersistentCongestion(largest_lost):
+     // Persistent congestion cannot be declared on the
+     // first RTT sample.
+     if (is first rtt sample):

```suggestion
     if (is first RTT sample):
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3889#pullrequestreview-452913580