Re: [quicwg/base-drafts] No RTT samples, no persistent congestion (#3889)
Martin Thomson <notifications@github.com> Wed, 22 July 2020 00:18 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5F0B13A0888 for <quic-issues@ietfa.amsl.com>; Tue, 21 Jul 2020 17:18:51 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.483
X-Spam-Level:
X-Spam-Status: No, score=-1.483 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3fYO0cYTrLPR for <quic-issues@ietfa.amsl.com>; Tue, 21 Jul 2020 17:18:50 -0700 (PDT)
Received: from out-26.smtp.github.com (out-26.smtp.github.com [192.30.252.209]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 077F23A0887 for <quic-issues@ietf.org>; Tue, 21 Jul 2020 17:18:50 -0700 (PDT)
Received: from github-lowworker-ca235ff.ash1-iad.github.net (github-lowworker-ca235ff.ash1-iad.github.net [10.56.110.15]) by smtp.github.com (Postfix) with ESMTP id 516C3282C0D for <quic-issues@ietf.org>; Tue, 21 Jul 2020 17:18:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1595377129; bh=WaGKD0s2uAoePkpn4x8Ek9O0rUVA/+mn3NTpHU3Mv9M=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=GzA22ZTY5cCrXuCEt+M9VDFWWomYM0QcYhuGKE4YHkYKLhQPmRHofKQ0LUh81HKI4 BTyEfJvtupDFtlbz/ytfZ0RPqWJTGkyi0kVpyK22i7MWPzaKTiDBjGtAhrNY8WC81z YtKDUcLo+W3BEdw/f9bN+parfOdFnIbfJuis5jR0=
Date: Tue, 21 Jul 2020 17:18:49 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2B7B2TWEBPX6OFHHN5ENTOTEVBNHHCOAK6ZQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3889/review/452913580@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3889@github.com>
References: <quicwg/base-drafts/pull/3889@github.com>
Subject: Re: [quicwg/base-drafts] No RTT samples, no persistent congestion (#3889)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f1785e941ae8_57513ff1fb8cd96c2048c3"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/3DQIgPNuK_6IPoPBbrW2B6sJjBE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Jul 2020 00:18:51 -0000
@martinthomson approved this pull request. It took me quite a while to confirm that "is first rtt sample" is good. It's slightly more expansive than what I had implemented (which records This has the effect of including packets sent prior to getting that sample. But as this is only packets sent within a single RTT, it's guaranteed to be less than a PTO. > @@ -1580,14 +1586,18 @@ Invoked when an ACK frame with an ECN section is received from the peer. Invoked when DetectAndRemoveLostPackets deems packets lost. ~~~ - InPersistentCongestion(lost_packets): + InPersistentCongestion(largest_lost): + // Persistent congestion cannot be declared on the + // first RTT sample. + if (is first rtt sample): ```suggestion if (is first RTT sample): ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3889#pullrequestreview-452913580
- [quicwg/base-drafts] No RTT samples, no persisten… ianswett
- Re: [quicwg/base-drafts] No RTT samples, no persi… Kazuho Oku
- Re: [quicwg/base-drafts] No RTT samples, no persi… Martin Thomson
- Re: [quicwg/base-drafts] No RTT samples, no persi… Marten Seemann
- Re: [quicwg/base-drafts] No RTT samples, no persi… Kazuho Oku
- Re: [quicwg/base-drafts] No RTT samples, no persi… Marten Seemann
- Re: [quicwg/base-drafts] No RTT samples, no persi… Kazuho Oku
- Re: [quicwg/base-drafts] No RTT samples, no persi… Jana Iyengar
- Re: [quicwg/base-drafts] No RTT samples, no persi… ianswett
- Re: [quicwg/base-drafts] No RTT samples, no persi… Martin Thomson
- Re: [quicwg/base-drafts] No RTT samples, no persi… Kazuho Oku
- Re: [quicwg/base-drafts] No RTT samples, no persi… ianswett
- Re: [quicwg/base-drafts] No RTT samples, no persi… Jana Iyengar
- Re: [quicwg/base-drafts] No RTT samples, no persi… Kazuho Oku
- Re: [quicwg/base-drafts] No RTT samples, no persi… Jana Iyengar
- Re: [quicwg/base-drafts] No RTT samples, no persi… Marten Seemann
- Re: [quicwg/base-drafts] No RTT samples, no persi… Jana Iyengar
- Re: [quicwg/base-drafts] No RTT samples, no persi… Martin Thomson
- Re: [quicwg/base-drafts] No RTT samples, no persi… ianswett
- Re: [quicwg/base-drafts] No RTT samples, no persi… ianswett
- Re: [quicwg/base-drafts] No RTT samples, no persi… ianswett
- Re: [quicwg/base-drafts] No RTT samples, no persi… ianswett
- Re: [quicwg/base-drafts] No RTT samples, no persi… ianswett
- Re: [quicwg/base-drafts] No RTT samples, no persi… Jana Iyengar
- Re: [quicwg/base-drafts] No RTT samples, no persi… Kazuho Oku
- Re: [quicwg/base-drafts] No RTT samples, no persi… ianswett
- Re: [quicwg/base-drafts] No RTT samples, no persi… ianswett
- Re: [quicwg/base-drafts] No RTT samples, no persi… ianswett
- Re: [quicwg/base-drafts] No RTT samples, no persi… ianswett
- Re: [quicwg/base-drafts] No RTT samples, no persi… ianswett
- Re: [quicwg/base-drafts] No RTT samples, no persi… Jana Iyengar
- Re: [quicwg/base-drafts] No RTT samples, no persi… Kazuho Oku
- Re: [quicwg/base-drafts] No RTT samples, no persi… Martin Thomson
- Re: [quicwg/base-drafts] No RTT samples, no persi… ianswett
- Re: [quicwg/base-drafts] No RTT samples, no persi… Marten Seemann
- Re: [quicwg/base-drafts] No RTT samples, no persi… Marten Seemann
- Re: [quicwg/base-drafts] No RTT samples, no persi… Kazuho Oku
- Re: [quicwg/base-drafts] No RTT samples, no persi… Marten Seemann
- Re: [quicwg/base-drafts] No RTT samples, no persi… Kazuho Oku
- Re: [quicwg/base-drafts] No RTT samples, no persi… Kazuho Oku
- Re: [quicwg/base-drafts] No RTT samples, no persi… Marten Seemann
- Re: [quicwg/base-drafts] No RTT samples, no persi… Marten Seemann
- Re: [quicwg/base-drafts] No RTT samples, no persi… Kazuho Oku
- Re: [quicwg/base-drafts] No RTT samples, no persi… Kazuho Oku
- Re: [quicwg/base-drafts] No RTT samples, no persi… Marten Seemann
- Re: [quicwg/base-drafts] No RTT samples, no persi… mjoras
- Re: [quicwg/base-drafts] No RTT samples, no persi… mjoras
- Re: [quicwg/base-drafts] No RTT samples, no persi… Kazuho Oku
- Re: [quicwg/base-drafts] No RTT samples, no persi… Kazuho Oku
- Re: [quicwg/base-drafts] No RTT samples, no persi… Marten Seemann
- Re: [quicwg/base-drafts] No RTT samples, no persi… mjoras
- Re: [quicwg/base-drafts] No RTT samples, no persi… Kazuho Oku
- Re: [quicwg/base-drafts] No RTT samples, no persi… Marten Seemann
- Re: [quicwg/base-drafts] No RTT samples, no persi… Kazuho Oku
- Re: [quicwg/base-drafts] No RTT samples, no persi… Kazuho Oku
- Re: [quicwg/base-drafts] No RTT samples, no persi… Jana Iyengar
- Re: [quicwg/base-drafts] No RTT samples, no persi… Jana Iyengar
- Re: [quicwg/base-drafts] No RTT samples, no persi… ianswett
- Re: [quicwg/base-drafts] No RTT samples, no persi… ianswett