IETF Logo Mail Archive

Re: [quicwg/base-drafts] No RTT samples, no persistent congestion (#3889)

Marten Seemann <notifications@github.com> Wed, 22 July 2020 02:08 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4AF7A3A0873 for <quic-issues@ietfa.amsl.com>; Tue, 21 Jul 2020 19:08:49 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.555
X-Spam-Level:
X-Spam-Status: No, score=-1.555 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mcwwQwrA017J for <quic-issues@ietfa.amsl.com>; Tue, 21 Jul 2020 19:08:47 -0700 (PDT)
Received: from out-21.smtp.github.com (out-21.smtp.github.com [192.30.252.204]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8B0933A086F for <quic-issues@ietf.org>; Tue, 21 Jul 2020 19:08:47 -0700 (PDT)
Received: from github-lowworker-6b40fdd.va3-iad.github.net (github-lowworker-6b40fdd.va3-iad.github.net [10.48.16.64]) by smtp.github.com (Postfix) with ESMTP id DF6E4A0DFD for <quic-issues@ietf.org>; Tue, 21 Jul 2020 19:08:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1595383726; bh=IW3Vbv+JixT0SWnKA99F1eVF0PiEGzrpPNxClq7cfTw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=fE01rL6rbf0U2cj0M5xDjQxEL0FQwmSRmTSLFCmzMKEcM1qoXNAOQDjogJl+/dEX2 9HaQuNiFrPUeCiBtE/C/BONV4sUxW/enOIsEqYsRxhr3VrSlgolI0wbRNd9bHPYpqL 2sBeQTwVcjD7nMiqorvVGsYpUeUz5zjAc+Z54QsY=
Date: Tue, 21 Jul 2020 19:08:46 -0700
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5PGBWO3CQYK7PWONF5EOAK5EVBNHHCOAK6ZQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3889/review/452946337@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3889@github.com>
References: <quicwg/base-drafts/pull/3889@github.com>
Subject: Re: [quicwg/base-drafts] No RTT samples, no persistent congestion (#3889)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f179faecea88_1ee3fcaaa4cd95c266694"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/8mNTgeTG8DsevUjgjHm0ObOWh6o>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Jul 2020 02:08:49 -0000

@marten-seemann commented on this pull request.



> @@ -1580,14 +1586,18 @@ Invoked when an ACK frame with an ECN section is received from the peer.
 Invoked when DetectAndRemoveLostPackets deems packets lost.
 
 ~~~
-   InPersistentCongestion(lost_packets):
+   InPersistentCongestion(largest_lost):
+     // Persistent congestion cannot be declared on the
+     // first RTT sample.
+     if (is first RTT sample):
+       return false

I'm not sure if that's correct. What matters is that the packet you use for the start of the persistent congestion period was sent after you already had an RTT sample.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3889#pullrequestreview-452946337

v2.23.0 | Report a Bug | By Email