IETF Logo Mail Archive

Re: [quicwg/base-drafts] No RTT samples, no persistent congestion (#3889)

mjoras <notifications@github.com> Wed, 22 July 2020 05:28 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C55663A0DE8 for <quic-issues@ietfa.amsl.com>; Tue, 21 Jul 2020 22:28:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.483
X-Spam-Level:
X-Spam-Status: No, score=-1.483 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yqPBtd2BPJ5t for <quic-issues@ietfa.amsl.com>; Tue, 21 Jul 2020 22:28:13 -0700 (PDT)
Received: from out-16.smtp.github.com (out-16.smtp.github.com [192.30.254.199]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B37C43A0DE5 for <quic-issues@ietf.org>; Tue, 21 Jul 2020 22:28:13 -0700 (PDT)
Received: from github-lowworker-cf59896.ash1-iad.github.net (github-lowworker-cf59896.ash1-iad.github.net [10.56.112.26]) by smtp.github.com (Postfix) with ESMTP id 2289912130B for <quic-issues@ietf.org>; Tue, 21 Jul 2020 22:28:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1595395693; bh=IQpMAm8FJxbn3/SIlD71wrTAJgkMZprasKRTpe4t/7I=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=dSrbEr7yxatKgolylVgUNClt44xlggwakuO3XEfjIewOcpv515mzrwUtGRQDAveyQ DIdgYqc06y8xC8xECHQa0UjNuuXrD+C2ZqFcsgfPOIOyNH9QtaAu7xqmSZubtMD1Au kb0boj51aPZBVW6Jvv7sQM4f/nHN1LhHN839dMm8=
Date: Tue, 21 Jul 2020 22:28:12 -0700
From: mjoras <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYPVD74FMPAUD4NLZF5EOXWZEVBNHHCOAK6ZQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3889/review/453003984@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3889@github.com>
References: <quicwg/base-drafts/pull/3889@github.com>
Subject: Re: [quicwg/base-drafts] No RTT samples, no persistent congestion (#3889)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f17ce6cec7a5_219b3f824f2cd95c39999"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mjoras
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/dh4jBN4CazWwAUBsL6WMyhrxJTM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Jul 2020 05:28:15 -0000

@mjoras commented on this pull request.



> @@ -1580,14 +1586,18 @@ Invoked when an ACK frame with an ECN section is received from the peer.
 Invoked when DetectAndRemoveLostPackets deems packets lost.
 
 ~~~
-   InPersistentCongestion(lost_packets):
+   InPersistentCongestion(largest_lost):
+     // Persistent congestion cannot be declared on the
+     // first RTT sample.
+     if (is first RTT sample):
+       return false

@kazuho can you explain your reasoning around "edges" being sufficient?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3889#discussion_r458542680

v2.23.0 | Report a Bug | By Email