IETF Logo Mail Archive

Re: [quicwg/base-drafts] Clarify OnAckReceived pseudocode (#2140)

ianswett <notifications@github.com> Mon, 17 December 2018 19:50 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E9E6C130F49 for <quic-issues@ietfa.amsl.com>; Mon, 17 Dec 2018 11:50:05 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.056
X-Spam-Level:
X-Spam-Status: No, score=-8.056 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Siu0io2t0VQu for <quic-issues@ietfa.amsl.com>; Mon, 17 Dec 2018 11:50:04 -0800 (PST)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 39209130F97 for <quic-issues@ietf.org>; Mon, 17 Dec 2018 11:50:04 -0800 (PST)
Date: Mon, 17 Dec 2018 11:50:03 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1545076203; bh=Pgmsun0qWm0qFaF4Ld3ylMCt8j7FRJqPgFo/z320c04=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=O4seggD9wY52GqVKqeOQmX66+4qR6BRxflB077brAh9A9f4P500iTBO/oi8+Xexmu jqkxZ/FedJPYON+QZSeHdjzTUpvXb7KRaNi79OGWd6w+ckuxUoDWC5NV2Ne8ODK7D2 HuWWHEY74x+0u/3Mt0tZvkDlD3jL6burLiiGYJc0=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab0702d98b68a7f97868687029aebcf1b5776318e392cf00000001182fbfeb92a169ce174729c1@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2140/review/185768633@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2140@github.com>
References: <quicwg/base-drafts/pull/2140@github.com>
Subject: Re: [quicwg/base-drafts] Clarify OnAckReceived pseudocode (#2140)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c17fdeb26185_30363fa4c12d45c4835b1"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/5lSj9rS8FISbrprgDuS3wEAE0_c>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Dec 2018 19:50:13 -0000

ianswett approved this pull request.



> @@ -716,6 +717,9 @@ Pseudocode for OnAckReceived and UpdateRtt follow:
 
 ~~~
   OnAckReceived(ack):
+    largest_acked_packet = max(largest_acked_packet,

I think this accurately describes the text we have, but I think we should add some text that you MAY use the largest acked from the most recent ACK, which could reduce spurious retransmits when one packet arrives far out of order?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2140#pullrequestreview-185768633

v2.23.0 | Report a Bug | By Email