IETF Logo Mail Archive

Re: [quicwg/base-drafts] Clarify OnAckReceived pseudocode (#2140)

janaiyengar <notifications@github.com> Thu, 13 December 2018 19:39 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DBCBC130E3F for <quic-issues@ietfa.amsl.com>; Thu, 13 Dec 2018 11:39:30 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.056
X-Spam-Level:
X-Spam-Status: No, score=-3.056 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id w5g7ru5G0F_7 for <quic-issues@ietfa.amsl.com>; Thu, 13 Dec 2018 11:39:29 -0800 (PST)
Received: from o9.sgmail.github.com (o9.sgmail.github.com [167.89.101.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B9CBA130E3C for <quic-issues@ietf.org>; Thu, 13 Dec 2018 11:39:28 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=ISFNhksA+aoMPRsQwIRFAOJP8SQ=; b=wdlJoP0SMBYUNUki vOBhSTIbdGDWdIDzBpNQ8PEga6nyrOO3e35Q+d/whw6kCviGw0IGG6BnNJ9nyIz0 k6kzLTB4KtIwZlOS+WzUQ5qlloC03T5Ds/DhKfRCzhpNXY9tFabXYxe6aTBp9oG1 PgSwI034DtFe/sieR0kGXH+BgWs=
Received: by filter0035p1iad2.sendgrid.net with SMTP id filter0035p1iad2-8741-5C12B56F-11 2018-12-13 19:39:27.368225497 +0000 UTC m=+245200.866557417
Received: from github-lowworker-89d05ac.cp1-iad.github.net (unknown [192.30.252.35]) by ismtpd0030p1iad2.sendgrid.net (SG) with ESMTP id YzlIHKE2Sl67dyelt5jCww for <quic-issues@ietf.org>; Thu, 13 Dec 2018 19:39:27.303 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-89d05ac.cp1-iad.github.net (Postfix) with ESMTP id 48A37AE0431 for <quic-issues@ietf.org>; Thu, 13 Dec 2018 11:39:27 -0800 (PST)
Date: Thu, 13 Dec 2018 19:39:27 +0000
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abb15ed7cd0c0e60f1fff62141dd04e83d634266e392cf00000001182a776f92a169ce174729c1@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2140/review/184834092@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2140@github.com>
References: <quicwg/base-drafts/pull/2140@github.com>
Subject: Re: [quicwg/base-drafts] Clarify OnAckReceived pseudocode (#2140)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c12b56f46ddb_57983fe8ccad45b8307555"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1jl4wo1Tviayb+ROODMIYS5679t7Ic6OANVI guEVspRKOlQz6yK2loh/FuazVC4ne/u6codhd+WB7FYBPDRPz14K4f+GvPgPrkMyxWaV1A6DxL1oRu nvnjmYdDTNjJOeC170WMoJeLX60mUIj//WjyZxpVDVnrr3QMyen2vHtA3r29J/qXq8LWPnoZvy84Bl o=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/v_iaS6nij-1Z5IihyTP4qgmO-iI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Dec 2018 19:39:31 -0000

janaiyengar approved this pull request.

A minor nit, but this is a nice cleanup. Thanks! I'll approve, but @ianswett should take a look as well.

> @@ -634,7 +634,7 @@ largest_sent_packet:
 : The packet number of the most recently sent packet.
 
 largest_acked_packet:
-: The largest packet number acknowledged in an ACK frame.
+: The largest packet number acknowledged by any ACK frame.

```suggestion
: The largest packet number acknowledged in the connection so far.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2140#pullrequestreview-184834092

v2.23.0 | Report a Bug | By Email