Re: [quicwg/base-drafts] Restore CID sequence numbers (#1465)

Mike Bishop <notifications@github.com> Fri, 22 June 2018 18:03 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 72F5D130EDD for <quic-issues@ietfa.amsl.com>; Fri, 22 Jun 2018 11:03:22 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CqlkOCv1z_Ss for <quic-issues@ietfa.amsl.com>; Fri, 22 Jun 2018 11:03:18 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A943F130EF0 for <quic-issues@ietf.org>; Fri, 22 Jun 2018 11:03:18 -0700 (PDT)
Date: Fri, 22 Jun 2018 11:03:17 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1529690597; bh=phuBNy+oVd+O773+KrbpmdXHkt6pQGy4JQNcqytg6pM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=dLzJoOxQDK01/L2sTtVbI06ciF7kgBlg5ViGlP0B7VlDLUqywcWXxig2gJUcLOrpw ejOCWw+ZBvbuw+Lj+Bu0ayCwBO5vOqGlopmyUw4fFetJOx1Ij/pO0UUVQofsjky0LG 2L9X0ZLA0TPU5Scp96F7uvhcbS6WN9hWTpB3UFsk=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab357753fb9db330990ccfcc3a6e494126aefe184c92cf000000011744fbe592a169ce13ec6080@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1465/review/131292451@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1465@github.com>
References: <quicwg/base-drafts/pull/1465@github.com>
Subject: Re: [quicwg/base-drafts] Restore CID sequence numbers (#1465)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b2d39e5e8a4f_47602b0a39140f501372e7"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/7lgiz8pIVjcsNRMlHJVVDLRdfyc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Jun 2018 18:03:32 -0000

MikeBishop commented on this pull request.



> @@ -2613,6 +2627,14 @@ The NEW_CONNECTION_ID is as follows:
 
 The fields are:
 
+Sequence:
+
+: A variable-length integer.  This value starts at 0 and increases by 1 for each
+  connection ID that is provided by the server.  The connection ID that is
+  assigned during the handshake is assumed to have a sequence of -1.  That is,

What if we just eliminate this statement and let it be implementation-local?  The new text I added to the CID section says that "The series of
connection IDs issued by an endpoint is ordered, with the final connection ID
selected during the handshake coming first."

We could also fix this by removing the CID from SPA and simply saying that the server needs to send the client a CID it can use for the probe pretty promptly if it wants the client to do so.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1465#discussion_r197525078