Re: [quicwg/base-drafts] Restore CID sequence numbers (#1465)

Mike Bishop <notifications@github.com> Tue, 26 June 2018 18:03 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6F60F13112B for <quic-issues@ietfa.amsl.com>; Tue, 26 Jun 2018 11:03:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.009
X-Spam-Level:
X-Spam-Status: No, score=-3.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id t-g9aGbFZnV3 for <quic-issues@ietfa.amsl.com>; Tue, 26 Jun 2018 11:03:46 -0700 (PDT)
Received: from o7.sgmail.github.com (o7.sgmail.github.com [167.89.101.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0DA7013111E for <quic-issues@ietf.org>; Tue, 26 Jun 2018 11:03:45 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=h036Ury8DLV2ASS0NfjnP1no9kk=; b=qW5QnocfF/SGsF6q GRpWm9QyPT1l7VAStAKgx9TjkaDQUDfexCCNMQt2+UqSxwbInqeJf9DVnwveuvfl O8Ynp1aK7Vvq4rKCOMCnHkqX6aNBpB9oiqCL877AoPQxpo3H+c3SgN+MjrYCHjPn KUeD1Sk2b7Pt4NR5cebE20ToWhY=
Received: by filter1325p1mdw1.sendgrid.net with SMTP id filter1325p1mdw1-10775-5B327FFE-7 2018-06-26 18:03:42.079710862 +0000 UTC
Received: from github-lowworker10-cp1-prd.iad.github.net (unknown [192.30.252.38]) by ismtpd0004p1iad1.sendgrid.net (SG) with ESMTP id RCAH-Pa2RUiknLFrsJySuQ for <quic-issues@ietf.org>; Tue, 26 Jun 2018 18:03:41.932 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker10-cp1-prd.iad.github.net (Postfix) with ESMTP id E0F743FFCF for <quic-issues@ietf.org>; Tue, 26 Jun 2018 11:03:41 -0700 (PDT)
Date: Tue, 26 Jun 2018 18:03:42 +0000
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab189dafbb9ba3506f32068e8014368cfecc1c139a92cf00000001174a41fd92a169ce13ec6080@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1465/review/132140602@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1465@github.com>
References: <quicwg/base-drafts/pull/1465@github.com>
Subject: Re: [quicwg/base-drafts] Restore CID sequence numbers (#1465)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b327ffddf2c9_29a13fc4f7d08f802558f1"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2PjSULZ4EkbwYoBiWOeo9J8xb0cSl3vZMDp2 Dob92ZE4FQrU07AULCyUI44HQ+eKJrMuaVOzDwlq3q8Gt9oMRA4kkZ7FVGMxYN/sY/vl2zUPo2x1Zz 7IlOfAcAICclGPDVbmPKpB3jQXpZa8GLOENP/UFk0q4ZY5TgT7jPlXMoa8lQ84AnzHOGBZwRhL4DJp g=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/rX7bkJ4EdQylCqI7MKlh71VLoaI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Jun 2018 18:03:50 -0000

MikeBishop commented on this pull request.



> +selected during the handshake coming first.  Additional connection IDs are
+provided using the NEW_CONNECTION_ID frame ({{frame-new-connection-id}}), each
+with a specified sequence number.  The series of connection IDs issued SHOULD be
+contiguous, but might not appear to be upon receipt due to reordering or loss.
+
+Each connection ID MUST be used on only one local address. When packets are sent
+for the first time on a new local address, a new connection ID MUST be used with
+a higher sequence number than any connection ID previously used on any local
+address.  At any time, an endpoint MAY change to a new connection ID on a local
+address already in use.
+
+An endpoint MUST NOT send packets with a connection ID which has a lower
+sequence number than the highest sequence number of any connection ID ever sent
+or received on that local address.
+
+Implementations SHOULD ensure that peers have a connection ID with a matching

But the trade-off is that lost packets can cause a peer to appear to violate this temporarily, so it's not realistically enforceable by a peer.  You can't "MUST ensure" something has arrived on the other side, only detect whether it has or not.  And the connection doesn't actually break; the peer will have to advance to a higher-order CID, which will force the endpoint to move off of the one that doesn't have a match (assuming it still hasn't arrived).

Actually, what a smart implementation could do is to bundle the NEW_CONNECTION_ID frame with the corresponding CID in every packet between when it changes to a new CID until *something* gets ACK'd.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1465#discussion_r198244528