Re: [quicwg/base-drafts] Clarify QPACK eviction races (#1237)
afrind <notifications@github.com> Mon, 19 March 2018 22:54 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CD27012D7F2 for <quic-issues@ietfa.amsl.com>; Mon, 19 Mar 2018 15:54:06 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.009
X-Spam-Level:
X-Spam-Status: No, score=-7.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dmwl5dvDTi9F for <quic-issues@ietfa.amsl.com>; Mon, 19 Mar 2018 15:54:04 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5381012AF84 for <quic-issues@ietf.org>; Mon, 19 Mar 2018 15:54:04 -0700 (PDT)
Date: Mon, 19 Mar 2018 15:54:03 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1521500043; bh=csQvDhcBJIRMJrna2Hy72DMAuBA20gF0Qa/g6o62eOY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=IG9tY+B/tzKaN09oneXUCXvCJKIlFNPYfI7vCDKDZpzeMhEU12wnVYpFUv99aye9F RDX+bgr0czr9eamoLdCXI7uyqgS4nEq/OYm6iuk9OlP3hNIn7xBzsSvClH4/+SRTJd 2qaLt9jTqYX7vn/ByY9tADd9Pv5TU0Z1V/ubk6H8=
From: afrind <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab258b6b8ce21fb68a689ae9a122008e05e427eb1592cf0000000116c8018b92a169ce12443a1c@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1237/review/105168729@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1237@github.com>
References: <quicwg/base-drafts/pull/1237@github.com>
Subject: Re: [quicwg/base-drafts] Clarify QPACK eviction races (#1237)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ab03f8b56d3a_4523f9a5d84ef2c374cb"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: afrind
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/7zPh_pKNiyAtiR4NUivkEHP3B6U>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Mar 2018 22:54:07 -0000
afrind commented on this pull request. > desired. -To ensure that the blocked eviction case is rare, references to the oldest -entries in the dynamic table SHOULD be avoided. When one of the oldest entries -in the table is still actively used for references, the encoder SHOULD emit an -Indexed-Duplicate representation instead (see {{indexed-duplicate}}). +To ensure that blocked evictions are rare, the encoder SHOULD avoid +referencing any eviction-prone entries, which are dynamic table entries that may +be evicted soon. Rather than reference an eviction-prone entry, the encoder +SHOULD emit an Indexed-Duplicate representation (see {{indexed-duplicate}}), +and reference the duplicate instead. + +To identify eviction-prone entries, the encoder may maintain a draining index, +which is the smallest index in the dynamic table that it will emit a +reference for. As new entries are inserted, the encoder increments the +draining index such that the amount of free and draining space in the dyanmic +table is larger than its target threshold. Sorry, I meant the smallest absolute index. I wouldn't call it a base, since I think of a base as an absolute index that you encode against. I'm guessing that alone isn't enough to clarify? I think of draining space as space in the table occupied by valid entries that the encoder chooses not to use. Here's the little snippet of code that I use to implement, where `minUsable_` represents my draining index: ``` while (capacity_ - bytes_ + drainedBytes_ < table_->minFree() && minUsable_ <= baseIndex_) { VLOG(5) << "Draining absolute index " << minUsable_; drainedBytes_ += (*table_)[absoluteToInternal(minUsable_++)].bytes(); } ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1237#discussion_r175610917
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Mike Bishop
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Martin Thomson
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… afrind
- [quicwg/base-drafts] Clarify QPACK eviction races… afrind
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Martin Thomson
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… afrind
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Mike Bishop
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Mike Bishop
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… afrind
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… afrind
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Martin Thomson
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Martin Thomson
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… afrind
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Mike Bishop
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Martin Thomson
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Martin Thomson
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… afrind