Re: [quicwg/base-drafts] Notify the congestion controller of losses first (#3540)

ianswett <> Mon, 30 March 2020 00:05 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id C49563A106A for <>; Sun, 29 Mar 2020 17:05:47 -0700 (PDT)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -0.5
X-Spam-Status: No, score=-0.5 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=0.7, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id y1Oh-d_mBvPk for <>; Sun, 29 Mar 2020 17:05:46 -0700 (PDT)
Received: from ( []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id A56943A1068 for <>; Sun, 29 Mar 2020 17:05:46 -0700 (PDT)
Date: Sun, 29 Mar 2020 17:05:45 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1585526746; bh=PU7UqxSJcL7Y6nMgN7Kt8jnzRtyM0srfI9T0Thmfbdo=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=OZiGBWOxML0ruVZtE7A4YM5oY2LBG65sJDBjeHxRuIt/7GaQlwx6XaoLdmdd2MSQv 2syM5dlf3JDambRoB9jW+6vZP/xE/LRuqmbAlWb0TWkFe9GkoFFipSN4pcs+HktBd3 ptSo1SnlFlfUGWp3m1x8tpqQv+/zQHaELx5k36H8=
From: ianswett <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/pull/3540/>
In-Reply-To: <quicwg/base-drafts/pull/>
References: <quicwg/base-drafts/pull/>
Subject: Re: [quicwg/base-drafts] Notify the congestion controller of losses first (#3540)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e8137d9eaac7_13c03f8b6d4cd9606070db"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Mon, 30 Mar 2020 00:05:48 -0000

@martinduke  I think I addressed your comment by commenting that DetectNewlyAckedPackets is responsible for removing packets from sent_packets.  This aligns with the API for DetectLostPackets.  I also changed OnPacketAcked to OnPacketsAcked.

"// Determine which packets have been acknowledged and remove
  // them from sent_packets.
  newly_acked_packets = DetectNewlyAckedPackets(ack, pn_space)"

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: