Re: [quicwg/base-drafts] consider making the varint encoding unique (#2299)

MikkelFJ <notifications@github.com> Sun, 06 January 2019 11:04 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 53A36130E3F for <quic-issues@ietfa.amsl.com>; Sun, 6 Jan 2019 03:04:55 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.447
X-Spam-Level:
X-Spam-Status: No, score=-1.447 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1FRGcPyxjuwI for <quic-issues@ietfa.amsl.com>; Sun, 6 Jan 2019 03:04:53 -0800 (PST)
Received: from o7.sgmail.github.com (o7.sgmail.github.com [167.89.101.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D1087130E0A for <quic-issues@ietf.org>; Sun, 6 Jan 2019 03:04:53 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=rmL8XVJrrGCEAwod42vT5xqgpc0=; b=VhoEEF3ws/cAwHvJ u1yYWzNNdJk15QZN5Qtw7e4EpeLqBY3P7HIHb9QeyrqJd1NzYd/pk1DZH28mcjoh i3Aw9fw1JbvB939bQ8Sn6qydev6MzAtN7bmVuai3HFjJuUt9vQv1zEqYjeBYASdk 0T3eJ7BvXU4PeCga7vVGGNajF1Y=
Received: by filter1229p1las1.sendgrid.net with SMTP id filter1229p1las1-6515-5C31E0D4-21 2019-01-06 11:04:53.018646379 +0000 UTC m=+671484.625832576
Received: from github-lowworker-63e61ec.cp1-iad.github.net (unknown [192.30.252.36]) by ismtpd0010p1iad2.sendgrid.net (SG) with ESMTP id ysFdeS9bQ8OdMujGesBPZQ for <quic-issues@ietf.org>; Sun, 06 Jan 2019 11:04:52.934 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-63e61ec.cp1-iad.github.net (Postfix) with ESMTP id D8FE02A1405 for <quic-issues@ietf.org>; Sun, 6 Jan 2019 03:04:52 -0800 (PST)
Date: Sun, 06 Jan 2019 11:04:53 +0000
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abf79b0b2d3da32c33538c088782b1a44a83efaf1192cf000000011849a2d492a169ce179e43e2@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2299/451732895@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2299@github.com>
References: <quicwg/base-drafts/issues/2299@github.com>
Subject: Re: [quicwg/base-drafts] consider making the varint encoding unique (#2299)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c31e0d4d79e7_47b83fe214cd45c01241620"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2hKpC+gq+mTpQKuB64RHwAcnhGK2l5uQtO2O ssTReDZ7fTeZX8CkmrTlRheZOE9xQuJyhSAT6oBVB6YX3m3EiB4ycGQHE4nS8DvdZvvGKeR3lOhXSu efrfv0YTTINVjNn7tqT8FMZPzQdDH1nYljEPB0MUFSKtRJku1wYP8vSmKQ==
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/8ylgLxhPaK599dVUEsMEaYWpp-8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Jan 2019 11:04:55 -0000

I have also argued for this in the past, but it breaks down when conservatively allocate to bytes for a length that is unknown. Then you'd have to memmove if the length only require one byte.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2299#issuecomment-451732895