Re: [quicwg/base-drafts] consider making the varint encoding unique (#2299)

Marten Seemann <notifications@github.com> Sun, 06 January 2019 16:25 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6A41A128BCC for <quic-issues@ietfa.amsl.com>; Sun, 6 Jan 2019 08:25:50 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.064
X-Spam-Level:
X-Spam-Status: No, score=-8.064 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id APl55Qx33y1R for <quic-issues@ietfa.amsl.com>; Sun, 6 Jan 2019 08:25:48 -0800 (PST)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 94E2412894E for <quic-issues@ietf.org>; Sun, 6 Jan 2019 08:25:48 -0800 (PST)
Date: Sun, 06 Jan 2019 08:25:47 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1546791947; bh=dHScHxkyMGYBRIvh4LIm+b8v0xcLcoTE5yi56pjlShk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=TPUNQrAoaa+mbYZD9IXln7jPCa655fhjEj+wrnZX6rxn8wfjfMbyeQJfcmD9dn3QM 3aYxv+8qmairkPU5hQU5sQieBPz+njxJn4S9EJBxtNRQ+ol7VsYC+gJ/fNoCECVLOU YXRuIXUoOyQbldsSsdm/XLSetiivVrsIDTRaPXqg=
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab4086e0228cbdeae6cdc1f670f1afef09e15ab0d192cf000000011849ee0b92a169ce179e43e2@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2299/451754606@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2299@github.com>
References: <quicwg/base-drafts/issues/2299@github.com>
Subject: Re: [quicwg/base-drafts] consider making the varint encoding unique (#2299)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c322c0b94c3e_61373fa85a4d45bc9410cc"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/HcHuvfGzNa0JNEY2tdFuwFaivds>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Jan 2019 16:25:51 -0000

> Losing the flexibility afforded by allowing fixed-size varints is one way to fix the clumsy language. The other way is to fix the clumsy language.

It's not only the language that's clumsy. The fact that we have to make this distinction at all is clumsy.
I see little value in having flexibility where it's not needed, especially if it adds weird corner cases elsewhere. I'm aware that reserving a longer value and filling it in later is a lazy way to implement the varint encoding, but I didn't find it particularly hard to write my code in a way that allows me to always use the optimal encoding.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2299#issuecomment-451754606