IETF Logo Mail Archive

Re: [quicwg/base-drafts] QPACK editorial revision (#2759)

Mike Bishop <notifications@github.com> Thu, 20 June 2019 17:34 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 016CF1200F3 for <quic-issues@ietfa.amsl.com>; Thu, 20 Jun 2019 10:34:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.391
X-Spam-Level:
X-Spam-Status: No, score=-6.391 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qJr3XsUD4wIq for <quic-issues@ietfa.amsl.com>; Thu, 20 Jun 2019 10:34:03 -0700 (PDT)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 43D60120026 for <quic-issues@ietf.org>; Thu, 20 Jun 2019 10:34:03 -0700 (PDT)
Date: Thu, 20 Jun 2019 10:34:02 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1561052042; bh=nHLfFXa/gy65EVCYe7wsnxOtnnZGEfdrU3WPwIaAbZM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=1NGbVEAP65ly6x1UA5m2zSy9WFKgShHiy9Jj9nBpfGW+pTRv2mRbH9LQTJFxqsrmB Avav6A12/XrKC56VCn0lq3JDuqsq55TRvUVYMeZkgYIhmYN90KtZ1RqD7Enn/gqKso O9i3yYcgUyQ5T2TMs4u/TxxLanvffrr9uRPO1efM=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4SOA3437KKRRCOCCN3DD3AVEVBNHHBVUIAB4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2759/review/252432670@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2759@github.com>
References: <quicwg/base-drafts/pull/2759@github.com>
Subject: Re: [quicwg/base-drafts] QPACK editorial revision (#2759)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d0bc38a43578_5ead3fe020ccd96473666"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/HsE2GxFdsgKW8ZV0iEW9XZMEo0Y>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Jun 2019 17:34:05 -0000

MikeBishop commented on this pull request.



> @@ -344,7 +337,7 @@ MUST treat this as a connection error of type HTTP_QPACK_DECOMPRESSION_FAILED.
 
 ### State Synchronization
 
-The decoder signals key events by emitting decoder instructions
+The decoder signals the following key events by emitting decoder instructions

You can probably just replace "key" instead of adding.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2759#pullrequestreview-252432670

v2.23.0 | Report a Bug | By Email