Re: [quicwg/base-drafts] QPACK editorial revision (#2759)

afrind <notifications@github.com> Wed, 26 June 2019 17:51 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EF5F4120446 for <quic-issues@ietfa.amsl.com>; Wed, 26 Jun 2019 10:51:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UyKExYMYm3wl for <quic-issues@ietfa.amsl.com>; Wed, 26 Jun 2019 10:51:30 -0700 (PDT)
Received: from out-9.smtp.github.com (out-9.smtp.github.com [192.30.254.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AD0BE120464 for <quic-issues@ietf.org>; Wed, 26 Jun 2019 10:51:10 -0700 (PDT)
Date: Wed, 26 Jun 2019 10:51:10 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1561571470; bh=23x52s62BniiGNkWp9g4UoqFfaQ2P4PTtz0jg8aMmE8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Z7BCGNIZCob+2v7eTOJxX330CKZwaz+h0fyi8iGo0sW3jiixAOg+qWpLvS5snrAuL WdAW+7ojZL6e4dh+eCpkppcNZX3xw2cAR7UA4M+q1qXMtcERuWSstZGCccJv1zthE/ kXD6r4vZ93axHr9f8s81lEyajKKE1RYJQnlJTiyM=
From: afrind <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK434NOCBE5GPRW5OA53EDRQ5EVBNHHBVUIAB4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2759/review/254776951@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2759@github.com>
References: <quicwg/base-drafts/pull/2759@github.com>
Subject: Re: [quicwg/base-drafts] QPACK editorial revision (#2759)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d13b08e83c8_1bbf3ff1bf0cd960950ed"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: afrind
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/SfZnM0Yag4m-o7fYn-3fZy_q5Xk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Jun 2019 17:51:32 -0000

afrind commented on this pull request.



>  
 An encoder MUST NOT insert an entry into the dynamic table (or duplicate an
-existing entry) if doing so would evict a blocking entry.  In this case, the
-encoder can send literal representations of header fields.
+existing entry) if doing so would evict a blocking entry.  An encoder can always
+send literal representations of header fields when the dynamic table is full

This is covered in the "Encoder" section: 

> An encoder converts a header list into a header block by emitting either an indexed or a literal representation for each header field in the list
...
References to the static table and literal representations do not require any dynamic state and never risk head-of-line blocking

I guess it doesn't specifically state the encoder "can always send" these representations, but I'm going for less=more here.  Maybe we can add it later, if really needed.  I don't think it belongs in Avoiding Blocked Insertions, since optimistic insertions could also be blocked, and have nothing to do with literal representations.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2759#discussion_r297792420