Re: [quicwg/base-drafts] QPACK editorial revision (#2759)
Mike Bishop <notifications@github.com> Thu, 20 June 2019 16:55 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 93ADA12008A for <quic-issues@ietfa.amsl.com>; Thu, 20 Jun 2019 09:55:25 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1FE9o18ie78l for <quic-issues@ietfa.amsl.com>; Thu, 20 Jun 2019 09:55:23 -0700 (PDT)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7AD2F120019 for <quic-issues@ietf.org>; Thu, 20 Jun 2019 09:55:23 -0700 (PDT)
Date: Thu, 20 Jun 2019 09:55:22 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1561049722; bh=TA5omdo8PL+XYm3hU4Z4SVrQvVsCAps2DYvS7fKYtiY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=mDuCuOw2ML0/dWBu9tdI29MKakn0nM7eoh2fMROFnXN4U7oRjovanCytIRa2N2y4S Ylm749ccxT7MpfTcN18Rkkk8sYZDvXuQm+U4YyduRDUqyP6jO0/SKSH9Rlbrhn3hKS 0S3d17NJHcIdZ6GmiJtxVhLr7ZorxUG+Txl1WrA8=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK47Y524EDG7YLRPGEN3DDWPVEVBNHHBVUIAB4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2759/review/252404774@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2759@github.com>
References: <quicwg/base-drafts/pull/2759@github.com>
Subject: Re: [quicwg/base-drafts] QPACK editorial revision (#2759)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d0bba7a2b73e_22bc3fd4460cd96022287a"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/msvMP_XLUoH0RbGx30QHbH4Am9g>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Jun 2019 16:55:25 -0000
MikeBishop approved this pull request. > ## Encoder -An encoder compresses a header list by emitting either an indexed or a literal -representation for each header field in the list. References to the static -table and literal representations do not require any dynamic state and never -risk head-of-line blocking. References to the dynamic table risk head-of-line +An encoder compresses a header list into a header block by emitting either an +indexed or a literal representation for each header field in the list (see "encodes," "represents"? But regardless, this isn't new text in this change. > An encoder MUST NOT insert an entry into the dynamic table (or duplicate an -existing entry) if doing so would evict a blocking entry. In this case, the -encoder can send literal representations of header fields. +existing entry) if doing so would evict a blocking entry. An encoder can always +send literal representations of header fields when the dynamic table is full Perhaps just omit "when the dynamic table..."? It's true universally, regardless of the dynamic table state. > -The decoder chooses when to emit Insert Count Increment instructions (see +After receiving new table entries on the encoder stream, the decoder chooses +when to emit Insert Count Increment instructions (see {{insert-count-increment}}). Emitting an instruction after adding each new This instruction, you're right. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2759#pullrequestreview-252404774
- [quicwg/base-drafts] QPACK editorial revision (#2… afrind
- Re: [quicwg/base-drafts] QPACK editorial revision… ianswett
- Re: [quicwg/base-drafts] QPACK editorial revision… Bence Béky
- Re: [quicwg/base-drafts] QPACK editorial revision… Bence Béky
- Re: [quicwg/base-drafts] QPACK editorial revision… Martin Thomson
- Re: [quicwg/base-drafts] QPACK editorial revision… Lucas Pardue
- Re: [quicwg/base-drafts] QPACK editorial revision… Mike Bishop
- Re: [quicwg/base-drafts] QPACK editorial revision… Mike Bishop
- Re: [quicwg/base-drafts] QPACK editorial revision… Mike Bishop
- Re: [quicwg/base-drafts] QPACK editorial revision… Mike Bishop
- Re: [quicwg/base-drafts] QPACK editorial revision… Mike Bishop
- Re: [quicwg/base-drafts] QPACK editorial revision… afrind
- Re: [quicwg/base-drafts] QPACK editorial revision… Mike Bishop
- Re: [quicwg/base-drafts] QPACK editorial revision… Mike Bishop
- Re: [quicwg/base-drafts] QPACK editorial revision… Mike Bishop
- Re: [quicwg/base-drafts] QPACK editorial revision… afrind
- Re: [quicwg/base-drafts] QPACK editorial revision… afrind
- Re: [quicwg/base-drafts] QPACK editorial revision… afrind