Re: [quicwg/base-drafts] QPACK editorial revision (#2759)

Mike Bishop <notifications@github.com> Tue, 25 June 2019 16:34 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5BB4C120411 for <quic-issues@ietfa.amsl.com>; Tue, 25 Jun 2019 09:34:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tGK2kO3_-o7A for <quic-issues@ietfa.amsl.com>; Tue, 25 Jun 2019 09:34:11 -0700 (PDT)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B60B8120322 for <quic-issues@ietf.org>; Tue, 25 Jun 2019 09:34:11 -0700 (PDT)
Date: Tue, 25 Jun 2019 09:34:10 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1561480450; bh=97BWFb0DDWJWW9JVi4arhdAt6AN2H2m/r6EduzQdn3k=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=yn0uqLS1lWVdbIqUEo0aLTCPchYjcq5vRqPxphfyvAzxJQzMP+tbJlMWyGeouw+qK Hpk1SgkOItOyGEm2Hp1/tQzRNXf+Y3taX2eA8xOwwH/RsjB/1RnHcZ/r53v3+G0aPj /T0VYtlM8g8WksnKPURzrVxiyg1uLK+NIFkqK0II=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4M2574ROA62EU4OZ53D57YFEVBNHHBVUIAB4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2759/review/254129160@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2759@github.com>
References: <quicwg/base-drafts/pull/2759@github.com>
Subject: Re: [quicwg/base-drafts] QPACK editorial revision (#2759)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d124d0272591_5c8e3ff058acd964516b6"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/WahHRglRoS3bps0JOLSQKWLIM_k>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Jun 2019 16:34:13 -0000

MikeBishop commented on this pull request.



>  
 While blocked, header block data SHOULD remain in the blocked stream's flow
 control window.  A stream becomes unblocked when the Insert Count becomes
 greater than or equal to the Required Insert Count for all header blocks the
 decoder has started reading from the stream.
 <!-- doesn't the stream become unblocked when the encoder receives the acks? -->
 
-If the decoder encounters a header block with a Required Insert Count value
-larger than defined in {{blocked-streams}}, it MAY treat this as a connection
-error of type HTTP_QPACK_DECOMPRESSION_FAILED.  If the decoder encounters a
-header block with a Required Insert Count value smaller than defined in
-{{blocked-streams}}, it MUST treat this as a connection error of type
-HTTP_QPACK_DECOMPRESSION_FAILED as prescribed in {{invalid-references}}.
+When processing header blocks, the decoder expects the Required Insert Count
+value to exactly match the value defined in {{blocked-streams}. If it encounters
+a smaller value, it MUST treat this as a connection error of type
+HTTP_QPACK_DECOMPRESSION_FAILED (see {{invalid-references}}). If it encounters a
+larger value, it MAY treat this as a connection error of type
+HTTP_QPACK_DECOMPRESSION_FAILED.

I worry slightly that people might get confused about which "value" is smaller or larger than which other "value", because that term is used to describe both.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2759#pullrequestreview-254129160