Re: [quicwg/base-drafts] QPACK editorial revision (#2759)

Mike Bishop <notifications@github.com> Thu, 20 June 2019 17:32 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 27089120026 for <quic-issues@ietfa.amsl.com>; Thu, 20 Jun 2019 10:32:36 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qGaGuCxU2Owp for <quic-issues@ietfa.amsl.com>; Thu, 20 Jun 2019 10:32:34 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EABB71200F3 for <quic-issues@ietf.org>; Thu, 20 Jun 2019 10:32:33 -0700 (PDT)
Date: Thu, 20 Jun 2019 10:32:32 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1561051952; bh=EkHsMnm25m3QG34OsxNjQbOU/4BpZ3Hg7gbQL7ckocs=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=TLI2Lp1IokV+Bq84uroDSNlCdtrMA6yvJST6N1lCGwm2dk3s6ks1jkdzwFJuh88Ll lswdxMoa9zDbqZnlJmLA+CEH6Ahj9xBBtMa4IzumfRR1it2OBqK9v3AB0n8m9tinME 3uoekyOPXBTTu0QeuRCeTFdnRzNz7iT/uDqW8zDc=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4YNIVBMPD7F7FJBOF3DD23BEVBNHHBVUIAB4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2759/review/252428023@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2759@github.com>
References: <quicwg/base-drafts/pull/2759@github.com>
Subject: Re: [quicwg/base-drafts] QPACK editorial revision (#2759)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d0bc33071fb4_23853fc51b2cd95c1187c1"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/N6JlmJP3OqBStNIGzg7pUzWincc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Jun 2019 17:32:36 -0000

MikeBishop commented on this pull request.



> @@ -795,8 +797,10 @@ already been acknowledged, that MUST be treated as a connection error of type
 
 ### Stream Cancellation
 
-The instruction begins with the '01' two-bit pattern. The instruction includes
-the stream ID of the affected stream encoded as a 6-bit prefix integer.
+When a stream is reset, the decoder emits a Stream Cancellation instruction. The

...or reading is abandoned (i.e. STOP_SENDING)

> @@ -1035,17 +1038,19 @@ values that are not to be put at risk by compressing them (see Section 7.1 of
 ~~~~~~~~~~
 {: title="Literal Header Field With Name Reference"}
 
-For entries in the static table or in the dynamic table with an absolute index
-less than the Base, the header field name is represented using the relative
-index of that entry, which is represented as an integer with a 4-bit prefix (see
-Section 5.1 of [RFC7541]). The `S` bit indicates whether the reference is to the
-static (S=1) or dynamic (S=0) table.
+The fourth (`S`) bit indicates whether the reference is to the static (S=1) or
+dynamic (S=0) table.  Finally, the header field name is represented using the
+static or relative index of that entry, which is represented as an integer with

We define relative, absolute, and post-base indices.  We talk about "static table index" and "index into the static table".  "Static table index" is used on line 656 of the current doc.  This use of "static index" is a new variation.  I suspect a reader could reasonably infer that they all mean the same thing -- obviously we all have -- but it might be nice to align the terminology and make sure it's defined somewhere.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2759#pullrequestreview-252428023