Re: [quicwg/base-drafts] Massive batch of probably-editorial nits (#3805)

[Jana Iyengar <[e-mail]>]

@janaiyengar commented on this pull request.

Doing this in chunks.

> +: When used without qualification, the tuple of IP version, IP address, and UDP
+  port number that represents one end of a network path.

This is supposed to say that the IP protocol number indicates UDP. We discussed this when adding the text, and couldn't come up with a better way to say it.

> +  endpoint.  Each endpoint sets one or more values for its peer to include in
+  packets sent towards the endpoint.

I don't feel great about this ... it is slightly better than the old text but it's still unclear exactly what is meant. How about "This identifier is set by an endpoint for its peer ..."

>  
 An endpoint SHOULD copy the error code from the STOP_SENDING frame to the
 RESET_STREAM frame it sends, but MAY use any application error code.  The
 endpoint that sends a STOP_SENDING frame MAY ignore the error code carried in
 any RESET_STREAM frame it receives.
 
-If the STOP_SENDING frame is received on a stream that is already in the
-"Data Sent" state, an endpoint that wishes to cease retransmission of
-previously-sent STREAM frames on that stream MUST first send a RESET_STREAM
-frame.

They are very slightly different -- this para says that an endpoint that wants to stop retransmitting MUST send a RESET_STREAM first. The earlier para says that a RESET_STREAM is sent instead of a retransmission.

That said, I think this is basically redundant. I would replace the language in the earlier para with the one from here, which is more accurate. We don't need the endpoint to send RESET_STREAM every time it detects a loss. Only that it send a RESET_STREAM before stopping retrnamissions.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3805#pullrequestreview-441360363