Re: [quicwg/base-drafts] Massive batch of probably-editorial nits (#3805)
Jana Iyengar <notifications@github.com> Thu, 02 July 2020 05:47 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1128B3A0D14 for <quic-issues@ietfa.amsl.com>; Wed, 1 Jul 2020 22:47:06 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.101
X-Spam-Level:
X-Spam-Status: No, score=-3.101 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ApV2fOBNRr8U for <quic-issues@ietfa.amsl.com>; Wed, 1 Jul 2020 22:47:04 -0700 (PDT)
Received: from out-14.smtp.github.com (out-14.smtp.github.com [192.30.254.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DD8CC3A0D0D for <quic-issues@ietf.org>; Wed, 1 Jul 2020 22:47:04 -0700 (PDT)
Received: from github-lowworker-edec459.ac4-iad.github.net (github-lowworker-edec459.ac4-iad.github.net [10.52.18.32]) by smtp.github.com (Postfix) with ESMTP id 59B0D120292 for <quic-issues@ietf.org>; Wed, 1 Jul 2020 22:47:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1593668824; bh=CY3UmGU3ov025Eo31HGfzAvq37aNvq4aSqk1u8cpq40=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=icaZKhXB2lS8ybgGtiMIvwwgnuttsE6TqGjrXc6BruX91/8BrD9fRyAqyQDuQkyUj um3WCh9wPWhYOCFinto4iTY+SY1F1Lfkk6y8E/2QYRWo8OmIwj/YN/AFbaYKNIofCP pEtst+GR5HNhm7mdAzn62mve/20bCoTTVmUHzONA=
Date: Wed, 01 Jul 2020 22:47:04 -0700
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5O4PY6MEIXUQEUETV5BFK5REVBNHHCNKDJHI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3805/review/441360363@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3805@github.com>
References: <quicwg/base-drafts/pull/3805@github.com>
Subject: Re: [quicwg/base-drafts] Massive batch of probably-editorial nits (#3805)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5efd74d813733_6cf73fbc1e4cd9604788c4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/NnDiKOD5woAdnpC-WQLAMiX7yyE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Jul 2020 05:47:06 -0000
@janaiyengar commented on this pull request. Doing this in chunks. > +: When used without qualification, the tuple of IP version, IP address, and UDP + port number that represents one end of a network path. This is supposed to say that the IP protocol number indicates UDP. We discussed this when adding the text, and couldn't come up with a better way to say it. > + endpoint. Each endpoint sets one or more values for its peer to include in + packets sent towards the endpoint. I don't feel great about this ... it is slightly better than the old text but it's still unclear exactly what is meant. How about "This identifier is set by an endpoint for its peer ..." > An endpoint SHOULD copy the error code from the STOP_SENDING frame to the RESET_STREAM frame it sends, but MAY use any application error code. The endpoint that sends a STOP_SENDING frame MAY ignore the error code carried in any RESET_STREAM frame it receives. -If the STOP_SENDING frame is received on a stream that is already in the -"Data Sent" state, an endpoint that wishes to cease retransmission of -previously-sent STREAM frames on that stream MUST first send a RESET_STREAM -frame. They are very slightly different -- this para says that an endpoint that wants to stop retransmitting MUST send a RESET_STREAM first. The earlier para says that a RESET_STREAM is sent instead of a retransmission. That said, I think this is basically redundant. I would replace the language in the earlier para with the one from here, which is more accurate. We don't need the endpoint to send RESET_STREAM every time it detects a loss. Only that it send a RESET_STREAM before stopping retrnamissions. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3805#pullrequestreview-441360363
- [quicwg/base-drafts] Massive batch of probably-ed… Mike Bishop
- Re: [quicwg/base-drafts] Massive batch of probabl… Mike Bishop
- Re: [quicwg/base-drafts] Massive batch of probabl… Mike Bishop
- Re: [quicwg/base-drafts] Massive batch of probabl… Martin Thomson
- Re: [quicwg/base-drafts] Massive batch of probabl… Jana Iyengar
- Re: [quicwg/base-drafts] Massive batch of probabl… Mike Bishop
- Re: [quicwg/base-drafts] Massive batch of probabl… Mike Bishop
- Re: [quicwg/base-drafts] Massive batch of probabl… Mike Bishop
- Re: [quicwg/base-drafts] Massive batch of probabl… Martin Thomson
- Re: [quicwg/base-drafts] Massive batch of probabl… Mike Bishop
- Re: [quicwg/base-drafts] Massive batch of probabl… Mike Bishop
- Re: [quicwg/base-drafts] Massive batch of probabl… Martin Thomson
- Re: [quicwg/base-drafts] Massive batch of probabl… Mike Bishop
- Re: [quicwg/base-drafts] Massive batch of probabl… Mike Bishop
- Re: [quicwg/base-drafts] Massive batch of probabl… Martin Thomson
- Re: [quicwg/base-drafts] Massive batch of probabl… Mike Bishop
- Re: [quicwg/base-drafts] Massive batch of probabl… Dmitri Tikhonov
- Re: [quicwg/base-drafts] Massive batch of probabl… Dmitri Tikhonov
- Re: [quicwg/base-drafts] Massive batch of probabl… Dmitri Tikhonov
- Re: [quicwg/base-drafts] Massive batch of probabl… Mike Bishop
- Re: [quicwg/base-drafts] Massive batch of probabl… Dmitri Tikhonov
- Re: [quicwg/base-drafts] Massive batch of probabl… Martin Thomson
- Re: [quicwg/base-drafts] Massive batch of probabl… Martin Thomson
- Re: [quicwg/base-drafts] Massive batch of probabl… Mike Bishop
- Re: [quicwg/base-drafts] Massive batch of probabl… Mike Bishop
- Re: [quicwg/base-drafts] Massive batch of probabl… Martin Thomson