Re: [quicwg/base-drafts] Massive batch of probably-editorial nits (#3805)

Martin Thomson <notifications@github.com> Fri, 10 July 2020 00:28 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 27E783A0A55 for <quic-issues@ietfa.amsl.com>; Thu, 9 Jul 2020 17:28:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.697
X-Spam-Level:
X-Spam-Status: No, score=-1.697 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id I1XYax4G7bUu for <quic-issues@ietfa.amsl.com>; Thu, 9 Jul 2020 17:28:55 -0700 (PDT)
Received: from out-27.smtp.github.com (out-27.smtp.github.com [192.30.252.210]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B24A03A0A49 for <quic-issues@ietf.org>; Thu, 9 Jul 2020 17:28:55 -0700 (PDT)
Received: from github-lowworker-5fb2734.va3-iad.github.net (github-lowworker-5fb2734.va3-iad.github.net [10.48.19.27]) by smtp.github.com (Postfix) with ESMTP id 0D16AE16C0 for <quic-issues@ietf.org>; Thu, 9 Jul 2020 17:28:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1594340935; bh=1FkEbFIsfYGzbvUFHSBLPdmEzHjomRh12HaJMuRIX44=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Y1TlO7GxKcDO2AVAbDsnj+flkS0+qfm07fzyVyPoXeaAsa7HlZSnEnXLM21uDJIWG cjhKpDbYxGMHbndVJTN3myTMPbXPDjv/bhu3xxeYr5tS9aKKQWnsBHEljRYWZQJc3T YE8SNdItNjQekzHt5sv0frO+kbzCzOAAOdwxRf2c=
Date: Thu, 09 Jul 2020 17:28:54 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYXCZNULI4BCI7VHG55COLUNEVBNHHCNKDJHI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3805/review/446051365@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3805@github.com>
References: <quicwg/base-drafts/pull/3805@github.com>
Subject: Re: [quicwg/base-drafts] Massive batch of probably-editorial nits (#3805)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f07b646f3043_579b3f8f5a2cd96c2045fc"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/eXCIwjeENibEfxvtolVdzKaETs4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Jul 2020 00:28:57 -0000

@martinthomson commented on this pull request.



> @@ -4008,8 +3992,8 @@ off-path injection as specified in {{!RFC8201}} and Section 5.2 of {{!RFC8085}}.
 This validation SHOULD use the quoted packet supplied in the payload of an ICMP
 message to associate the message with a corresponding transport connection (see
 Section 4.6.1 of {{!DPLPMTUD}}).  ICMP message validation MUST include matching
-IP addresses and UDP ports {{!RFC8085}} and, when possible, connection IDs to an
-active QUIC session.  The endpoint SHOULD ignore all ICMP messages that fail
+IP addresses and UDP ports ({{!RFC8085}}) and, when possible, connection IDs to

I think that the prevailing use of external references - those that appear in brackets - is both inline "defined in [REF]" and not as an automatic parenthetical, but an annotation of a noun in cases like "such as UDP [REF]", which you would convert to something like `<a href="REF">UDP</a>` were this text.  That's harder to codify though.  In many ways this is a limitation of markdown, but I don't see it as a serious shortcoming, because fixes (such as those in HTML or XML) just transfer the problem to the presentation layer.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3805#discussion_r452560291