Re: [quicwg/base-drafts] Limit RCID state (#3547)

ianswett <notifications@github.com> Wed, 08 April 2020 23:38 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 28A9A3A19D2 for <quic-issues@ietfa.amsl.com>; Wed, 8 Apr 2020 16:38:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.863
X-Spam-Level:
X-Spam-Status: No, score=-6.863 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.168, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pnPRDXhcWI3I for <quic-issues@ietfa.amsl.com>; Wed, 8 Apr 2020 16:38:08 -0700 (PDT)
Received: from out-26.smtp.github.com (out-26.smtp.github.com [192.30.252.209]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0A1D43A19D1 for <quic-issues@ietf.org>; Wed, 8 Apr 2020 16:38:08 -0700 (PDT)
Date: Wed, 08 Apr 2020 16:38:06 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1586389087; bh=Ofn0rQHgVNgp9a8COQxiRkvJWWgCT9Kk4fyVd731Vt0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=uR6elBA9gUFvcz6otvUJqQtVu/FNFpp9RkN/ovSn2hXuV9nLRV4GJ6h6guXfTDx44 IdWD4gHGgjcAwVU+/kc/ITLsNglyog1aBIQcM8iQt2qs7UDuuUZ3WKEclYT96aGZOI YCOq04G9A5caf+wwVcyc9ApFPBWEKLacAp/D0Vns=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5ZWDGNVD6VMISD5T54TJAV5EVBNHHCGFYIAU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3547/review/390401240@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3547@github.com>
References: <quicwg/base-drafts/pull/3547@github.com>
Subject: Re: [quicwg/base-drafts] Limit RCID state (#3547)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e8e605ee6a1e_367b3f9fcdccd95c1133b8"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/P4rczqqgKjpuDYHwav4tOMVwLaw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Apr 2020 23:38:09 -0000

@ianswett commented on this pull request.



> +An endpoint SHOULD limit the
+state it commits to retiring connection IDs using RETIRE_CONNECTION_ID by
+limiting the number of connection IDs that it tracks for
+retirement to at least twice the active_connection_id_limit. An endpoint MUST
+NOT forget a connection ID without retiring it, though MAY choose to treat
+having too many connection IDs in need of retirement as a connection error of
+type CONNECTION_ID_LIMIT_ERROR.

```suggestion
An endpoint SHOULD limit the state it commits to retiring connection IDs
using RETIRE_CONNECTION_ID by limiting the number of connection IDs that
it tracks for retirement to at least twice the active_connection_id_limit. An
endpoint MUST NOT forget a connection ID without retiring it, though MAY
choose to treat having too many connection IDs in need of retirement as a
connection error of type CONNECTION_ID_LIMIT_ERROR.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3547#pullrequestreview-390401240