Re: [quicwg/base-drafts] Limit RCID state (#3547)

[ekr <[e-mail]>]

@ekr requested changes on this pull request.



> @@ -1069,6 +1069,15 @@ to cease using the connection IDs when requested can result in connection
 failures, as the issuing endpoint might be unable to continue using the
 connection IDs with the active connection.
 
+An endpoint SHOULD limit the state it commits to retiring connection IDs using
+RETIRE_CONNECTION_ID by limiting the number of connection IDs that it tracks for
+retirement to at least twice the active_connection_id_limit. An endpoint MUST
+NOT forget a connection ID without retiring it, though MAY choose to treat
+having too many connection IDs in need of retirement as a connection error of
+type CONNECTION_ID_LIMIT_ERROR.
+
+Endpoints SHOULD NOT issue updates of the Retire Prior To field before receiving
+RETIRE_CONNECTION_ID frames for the previous update of Retire Prior To.

```suggestion
RETIRE_CONNECTION_ID frames that retire all connection IDs indicated by the previous Retire Prior To value.
```

> +An endpoint SHOULD limit the state it commits to retiring connection IDs using
+RETIRE_CONNECTION_ID by limiting the number of connection IDs that it tracks for
+retirement to at least twice the active_connection_id_limit. An endpoint MUST

```suggestion
An endpoint SHOULD limit the number of connection IDs for which it has issued an outstanding RETIRE_CONNECTION_ID to at least twice the active_connection_id limit.
```

> +An endpoint SHOULD limit the state it commits to retiring connection IDs using
+RETIRE_CONNECTION_ID by limiting the number of connection IDs that it tracks for
+retirement to at least twice the active_connection_id_limit. An endpoint MUST

I tried to rewrite the text to make it clearer, but in doing so, I realize that the original text is unclear.

Ignoring the details it says: "It should limit value X to no less than Y."

But I can achieve this by not limiting it at all, which is not the advice we seem to want to give. Is what you are trying to say:

1. There should be a fixed limit.
1. It should be no lower than Y.

What's the rationale for > 2xactive_connection_id.



> @@ -1069,6 +1069,15 @@ to cease using the connection IDs when requested can result in connection
 failures, as the issuing endpoint might be unable to continue using the
 connection IDs with the active connection.
 
+An endpoint SHOULD limit the state it commits to retiring connection IDs using
+RETIRE_CONNECTION_ID by limiting the number of connection IDs that it tracks for
+retirement to at least twice the active_connection_id_limit. An endpoint MUST
+NOT forget a connection ID without retiring it, though MAY choose to treat
+having too many connection IDs in need of retirement as a connection error of

"too many" seems non-specific here. I think we need more detail.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3547#pullrequestreview-408507339