IETF Logo Mail Archive

Re: [quicwg/base-drafts] Send complete SETTINGS (#2972)

Kazuho Oku <notifications@github.com> Mon, 19 August 2019 06:41 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3E50E12022A for <quic-issues@ietfa.amsl.com>; Sun, 18 Aug 2019 23:41:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.597
X-Spam-Level:
X-Spam-Status: No, score=-6.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4_Ord-qPsOOM for <quic-issues@ietfa.amsl.com>; Sun, 18 Aug 2019 23:41:16 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6C72C12020A for <quic-issues@ietf.org>; Sun, 18 Aug 2019 23:41:16 -0700 (PDT)
Date: Sun, 18 Aug 2019 23:41:15 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1566196875; bh=9B8jAcTclP2X7lpryEDBerxmmU21UQiYhSE9f6OK13o=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Qb6T/e7HOdhfosCkwwKpTjzpVNHdelLCbuHKcUuqoo8leXK6ELu2HWuz1vxI5Asuu Qw4ZW87B6l2UBWfuRzZrqjma6Ha+s5OIx64l+lqAld4k3bpNZsMP2aGxzMdfte6dEQ zOMUP0vQWslVb1bblfHx+5rdiTpME7+6WJfGWj3E=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZHD6U4VUQOXRRMMJ53M53QXEVBNHHBZNSWTM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2972/review/276364001@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2972@github.com>
References: <quicwg/base-drafts/pull/2972@github.com>
Subject: Re: [quicwg/base-drafts] Send complete SETTINGS (#2972)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d5a448b8c466_d943ffa230cd96c528829"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/TLuN-qysD5XzFXv49hOSg4pp0xc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Aug 2019 06:41:18 -0000

kazuho commented on this pull request.

The proposed text looks good, though I do not think it covers all the issues being discussed in #2945. Specifically, the text does not update _when_ a SETTINGS frame is expected to be sent.

If we are to follow the design pattern of HTTP/2, I think that we should clarify that an endpoint MUST send a SETTINGS frame as soon as it becomes possible to send application data, even when the SETTINGS frame would be empty. Otherwise, we should clarify that a SETTINGS frame is to be sent only when one of the following conditions are met: a feature depending on non-default value of a settings parameter is to be used, or a frame other than a SETTINGS frame is to be transmitted on the control stream.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2972#pullrequestreview-276364001

v2.23.0 | Report a Bug | By Email