Re: [quicwg/base-drafts] Unidirectional Streams (#643)

MikkelFJ <notifications@github.com> Tue, 20 June 2017 07:24 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D88761287A3 for <quic-issues@ietfa.amsl.com>; Tue, 20 Jun 2017 00:24:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.801
X-Spam-Level:
X-Spam-Status: No, score=-4.801 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-2.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c1WUk-UAa4rq for <quic-issues@ietfa.amsl.com>; Tue, 20 Jun 2017 00:24:12 -0700 (PDT)
Received: from o4.sgmail.github.com (o4.sgmail.github.com [192.254.112.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D72501274D0 for <quic-issues@ietf.org>; Tue, 20 Jun 2017 00:24:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=otBOArm/G9cvDzyN8am+PEcQBDM=; b=gpK3I61dILssg7BI tivxZu0g4fY6w1IwMRhsBAcQp3uJksBL9sRkQLNLg6egLGRW50+UVcxp/TIkFQiK W6akp8PKDd723brJz3h08l+eaTQ1vWcFKPCP/wMtcdHn2PtPhztQTW83rv09Qkvn jDmdypiHN1uIwb5rx8QRByZZJ0o=
Received: by filter0554p1mdw1.sendgrid.net with SMTP id filter0554p1mdw1-27940-5948CD9A-D 2017-06-20 07:24:10.161023289 +0000 UTC
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2a-ext-cp1-prd.iad.github.net [192.30.253.16]) by ismtpd0001p1iad1.sendgrid.net (SG) with ESMTP id 1jgy1jcgT7iiJa_B55MdOQ for <quic-issues@ietf.org>; Tue, 20 Jun 2017 07:24:10.128 +0000 (UTC)
Date: Tue, 20 Jun 2017 00:24:10 -0700
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab4181eaeb3d9727669a261c187dfb72a731a7abff92cf0000000115608f9a92a169ce0e21ecbf@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/643/review/45050993@github.com>
In-Reply-To: <quicwg/base-drafts/pull/643@github.com>
References: <quicwg/base-drafts/pull/643@github.com>
Subject: Re: [quicwg/base-drafts] Unidirectional Streams (#643)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5948cd9aa513_54033fcf9f1e1c30127ad"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak18qu6XcCCR9vqk3PCOpwT4bPZcix2F2psjZo BVBOI6hfTYUcBA2PxQicRf0cp1ig2f+DGrcxnwQR+FtrqN2qGoaXi68P7I8+yxiXfaRZhcsa8zlUt9 VKkr8Zh/Q1CToVY5kZwqhvy06yLV5qQQTM4bG9KMNLV2tIgithY5xOt9eQ==
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/UPc-SWkhuyBDr--qpoO2JViTxrc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Jun 2017 07:24:14 -0000

mikkelfj commented on this pull request.



> -
-### closed {#state-closed}
-
-The "closed" state is the terminal state for a stream.
-
-Once a stream reaches this state, no frames can be sent that mention the stream.
-Reordering might cause frames to be received after closing, see
-{{state-hc-remote}}.
+An endpoint could continue receiving frames for the stream even after the stream
+is closed for sending if packets are reordered.  At the receiving endpoint,
+retransmissions of data in STREAM frames, or retransmissions of STREAM_BLOCKED
+and RST_STREAM frames might arrive after the stream becomes "closed".  At the
+sending endpoint, MAX_STREAM_DATA frames might be received after the stream
+becomes "closed".  Frames received on a "closed" stream SHOULD be discarded.  An
+endpoint MAY choose to limit the period over which it ignores frames and treat
+frames that arrive after this time as being in error.
 

Perhaps a note on fatal connection error if receiving frames at later offset than close - otherwise a transmitter might abuse flow control limits - though the benefit of that is unclear. Perhaps also a note here stating the both RST_STREAM and FIN defines a specific end offset - even if discussed in more detail in specific frames.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/643#pullrequestreview-45050993