Re: [quicwg/base-drafts] Allow servers to send a preferred address of each address family (#2296)

[ianswett <[e-mail]>]

ianswett commented on this pull request.

I like this idea, one suggestion.

> @@ -2116,6 +2116,9 @@ packets.
 A server conveys a preferred address by including the preferred_address
 transport parameter in the TLS handshake.
 
+Servers MAY communicate a preferred address of each address family (IPv4 and

If you're speaking of "preferred" address, this is consistent with the rest of the text.  If you want to change the name, I'd suggest opening a separate issue.

I'm happy with preferred, since if it's just alternate, why would the client change?  Alternate implies no preference, when in fact the server does prefer the other address.

>  
 ~~~
    struct {
-     enum { IPv4(4), IPv6(6), (15) } ipVersion;
-     opaque ipAddress<4..2^8-1>;
+     opaque ipv4Address<0..2^8-1>;

Aren't these two fields now fixed sizes?  If so, any reason not to specify those?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2296#pullrequestreview-189644456