Re: [quicwg/base-drafts] Add MaxAckDelay sub-section (#1574)
Mike Bishop <notifications@github.com> Fri, 27 July 2018 23:36 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3377B130E42 for <quic-issues@ietfa.amsl.com>; Fri, 27 Jul 2018 16:36:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qMYNo-Zcpzh7 for <quic-issues@ietfa.amsl.com>; Fri, 27 Jul 2018 16:36:38 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 082601277C8 for <quic-issues@ietf.org>; Fri, 27 Jul 2018 16:36:38 -0700 (PDT)
Date: Fri, 27 Jul 2018 16:36:37 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1532734597; bh=pQQvxmPxN1tYSGW6H3MLkB2FxE5UIh6PGJsvWhKcKnI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=if61Ez0Lh3ofCHmqpq0zff+asIGGjtXuBIGyBu7H/KZ/jaVJS6j6XjexzrRb2N9me WvZOag3BSeMdy+Nbhwc2LQkoXkHKJK1BwG/ijYIQ7ZjN2sfWvew+MfRr/0VeqlsJ+A rViSg4VzJjnuZje+D8sg6S7Mqh5HMRrd8M/r+pbM=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab5d16e6f0c3db9467af84fa9c225d881524cfbc9592cf0000000117736e8592a169ce1461f5c3@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1574/review/141295508@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1574@github.com>
References: <quicwg/base-drafts/pull/1574@github.com>
Subject: Re: [quicwg/base-drafts] Add MaxAckDelay sub-section (#1574)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b5bac85170c0_5b653fa5aa6be628541a8"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Y8gPJEi8LNXgAL5X1nqto2xvb40>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Jul 2018 23:36:41 -0000
MikeBishop commented on this pull request. > @@ -206,6 +206,19 @@ Min RTT is the minimum RTT measured over the connection, prior to adjusting by ack delay. Ignoring ack delay for min RTT prevents intentional or unintentional underestimation of min RTT, which in turn prevents underestimating smoothed RTT. +### Maximum Ack Delay + +QUIC is able to explicitly model delay at the receiver via the ack delay +field in the ACK frame. Therefore, QUIC diverges from TCP by calculating a +MaxAckDelay dynamically, instead of assuming a constant delayed ack timeout +for all connections. + +MaxAckDelay is the maximum ack delay supplied in an all incoming ACK frames. +MaxAckDelay excludes ack delays that aren't included in an RTT sample because +they're too large or the largest acked has already been acknowledged. +MaxAckDelay also excludes ack delays where the largest ack references an You've used "largest ack" and "largest acked" here. Elsewhere in the document, you also use "largest acknowledged." Might be worth picking one and using it consistently? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1574#pullrequestreview-141295508
- [quicwg/base-drafts] Add MaxAckDelay sub-section … ianswett
- Re: [quicwg/base-drafts] Add MaxAckDelay sub-sect… Marten Seemann
- Re: [quicwg/base-drafts] Add MaxAckDelay sub-sect… ianswett
- Re: [quicwg/base-drafts] Add MaxAckDelay sub-sect… Rui Paulo
- Re: [quicwg/base-drafts] Add MaxAckDelay sub-sect… ianswett
- Re: [quicwg/base-drafts] Add MaxAckDelay sub-sect… ianswett
- Re: [quicwg/base-drafts] Add MaxAckDelay sub-sect… Subodh Iyengar
- Re: [quicwg/base-drafts] Add MaxAckDelay sub-sect… ianswett
- Re: [quicwg/base-drafts] Add MaxAckDelay sub-sect… Mike Bishop
- Re: [quicwg/base-drafts] Add MaxAckDelay sub-sect… ianswett